Skip to content

[WIP] Fix JIT issue with equality-guarded derived long comparison - #133252

Closed
AndyAyersMS with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-jit-long-comparison-truncation
Closed

[WIP] Fix JIT issue with equality-guarded derived long comparison#133252
AndyAyersMS with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-jit-long-comparison-truncation

Conversation

CopilotAI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor
  • Read issue details and applicable repo/build/JIT/test instructions
  • Check recent GitHub Actions runs/logs for the required CI workflow; observed unrelated service-label failure on another PR
  • Establish required CoreCLR/runtime-test baseline before product changes
  • Add focused JIT regression test for JIT: equality-guarded derived long comparison can silently use a truncated 32-bit value on x64 #133251
  • Confirm the product-code fix is already present in this checkout and keep the repository change test-only
  • Run targeted build/test validation and formatting
  • Scan changed files for secrets
  • Run final automated validation

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 4, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Co-authored-by: AndyAyersMS <10121823+AndyAyersMS@users.noreply.github.com>
@AndyAyersMS

Copy link
Copy Markdown
Member

@copilot where is the fix?

CopilotAI commented Sep 4, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot where is the fix?

There isn’t a product-code fix in this PR. The failure is already fixed in the current base by the prior JIT change in #132849 (RangeCheck::ComputeDoesOverflow now checks operand def chains for overflow). This PR only adds the missing regression coverage for #133251, and I verified that the new test runs and passes on a fresh checked CoreCLR/Core_Root build.

@AndyAyersMS

Copy link
Copy Markdown
Member

Ah, ok. Good to know. I don't think we need another test.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT: equality-guarded derived long comparison can silently use a truncated 32-bit value on x64

2 participants

@AndyAyersMS