Uh oh!
There was an error while loading. Please reload this page.
Revert "[mono][interp] Preserve nullable boxing for GetType" - #133287
Conversation
This reverts commit bbe4da3.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Tagging subscribers to this area: @vitek-karas, @BrzVlad, @kotlarmilos |
There was a problem hiding this comment.
🟡 Changes recommended
The reverted optimization changes observable Nullable<T>.GetType() behavior in the interpreter and the revert also removes innerloop regression coverage for this scenario.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR reverts prior changes related to how the Mono interpreter recognizes and optimizes box + GetType() patterns, and it removes an accompanying regression test for boxed Nullable<T>.GetType() behavior.
Changes:
- Removes the
Nullable<T>exclusion from the interpreter’sbox+object.GetType()peephole intransform.c. - Removes a non-
[OuterLoop]xUnit regression test ingettype.cs(leaving only an[OuterLoop]entrypoint test). - Minor using-directive reshuffle/cleanup in the test file.
File summaries
| File | Description |
|---|---|
| src/mono/mono/mini/interp/transform.c | Re-enables the box+GetType folding for nullable types by removing the nullable guard. |
| src/tests/JIT/Directed/nullabletypes/gettype.cs | Drops the non-[OuterLoop] regression test that asserted correct boxed-nullable GetType() semantics. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reverts #132732
Contributes to #133207. The new test is failing on many CoreCLR legs.