Uh oh!
There was an error while loading. Please reload this page.
Disable Runtime_133209 narrowing cast test on Mono - #133295
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, correctly-scoped Mono-only test suppression that matches existing SkipOnMono usage and does not affect non-Mono test execution.
Pull request overview
Disables the Runtime_133209.CheckedNarrowingCast_WithNarrowedOperand theory when running on Mono by adding a [SkipOnMono] attribute, keeping the test enabled for CoreCLR and other runtimes.
Changes:
- Mark
CheckedNarrowingCast_WithNarrowedOperandwith[SkipOnMono("https://github.com/dotnet/runtime/issues/100368")]to avoid Mono CI failures. - Leave all existing test coverage and behavior unchanged for non-Mono runtimes.
File summaries
| File | Description |
|---|---|
| src/tests/JIT/Regression/JitBlue/Runtime_133209/Runtime_133209.cs | Adds a Mono-only skip annotation to the failing theory while preserving execution elsewhere. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to disabling only the failing theory on Mono using an established test attribute and a tracking issue link.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
jkotas
commented
Sep 5, 2026
/ba-g failures unrelated to the test being disabled |
Mono is failing
Runtime_133209.CheckedNarrowingCast_WithNarrowedOperandwith an unexpectedOverflowExceptionin CI.