Skip to content

Disable Runtime_133209 narrowing cast test on Mono - #133295

Merged
jkotas merged 3 commits into
mainfrom
copilot/fix-checked-narrowing-cast-test-failure
Sep 5, 2026
Merged

Disable Runtime_133209 narrowing cast test on Mono#133295
jkotas merged 3 commits into
mainfrom
copilot/fix-checked-narrowing-cast-test-failure

Conversation

CopilotAI commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Mono is failing Runtime_133209.CheckedNarrowingCast_WithNarrowedOperand with an unexpected OverflowException in CI.

  • Disable only the failing theory on Mono using the requested tracking issue:
    [SkipOnMono("https://github.com/dotnet/runtime/issues/100368")]
  • Leave the test enabled for CoreCLR and other runtimes.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI changed the title [WIP] Fix CheckedNarrowingCast_WithNarrowedOperand test failure in CIDisable Runtime_133209 narrowing cast test on MonoSep 5, 2026
CopilotAI requested a review from jkotasSeptember 5, 2026 07:29
@jkotas
jkotas marked this pull request as ready for review September 5, 2026 14:22
CopilotAI lite review requested due to automatic review settings September 5, 2026 14:22
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, correctly-scoped Mono-only test suppression that matches existing SkipOnMono usage and does not affect non-Mono test execution.

Pull request overview

Disables the Runtime_133209.CheckedNarrowingCast_WithNarrowedOperand theory when running on Mono by adding a [SkipOnMono] attribute, keeping the test enabled for CoreCLR and other runtimes.

Changes:

  • Mark CheckedNarrowingCast_WithNarrowedOperand with [SkipOnMono("https://github.com/dotnet/runtime/issues/100368")] to avoid Mono CI failures.
  • Leave all existing test coverage and behavior unchanged for non-Mono runtimes.
File summaries
FileDescription
src/tests/JIT/Regression/JitBlue/Runtime_133209/Runtime_133209.csAdds a Mono-only skip annotation to the failing theory while preserving execution elsewhere.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

CopilotAI review requested due to automatic review settings September 5, 2026 15:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped to disabling only the failing theory on Mono using an established test attribute and a tracking issue link.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@jkotas

Copy link
Copy Markdown
Member

/ba-g failures unrelated to the test being disabled

@jkotas
jkotas merged commit 967fac9 into mainSep 5, 2026
86 of 88 checks passed
@jkotas
jkotas deleted the copilot/fix-checked-narrowing-cast-test-failure branch September 5, 2026 21:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Mono] CheckedNarrowingCast_WithNarrowedOperand test failing in CI

6 participants

@jkotas@lewing@steveisok@jkoritzinsky