Skip to content

Address follow-up feedback from #1934 - #2028

Merged
ViktorHofer merged 2 commits into
dotnet:masterfrom
ViktorHofer:monocifollowup
Jan 23, 2020
Merged

Address follow-up feedback from #1934#2028
ViktorHofer merged 2 commits into
dotnet:masterfrom
ViktorHofer:monocifollowup

Conversation

@ViktorHofer

@ViktorHoferViktorHofer commented Jan 22, 2020

Copy link
Copy Markdown
Member

@ViktorHoferViktorHofer self-assigned this Jan 22, 2020
akoeplinger
akoeplinger reviewed Jan 22, 2020
View reviewed changes

@akoeplingerakoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some whitespace nits :)

Comment threadeng/pipelines/runtime.yml Outdated
Comment threadeng/pipelines/runtime.yml Outdated
Comment threadeng/pipelines/runtime.yml Outdated
safern
safern approved these changes Jan 22, 2020
View reviewed changes

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up.

@ViktorHofer
ViktorHofer merged commit 03f8ed5 into dotnet:masterJan 23, 2020
@ViktorHofer
ViktorHofer deleted the monocifollowup branch January 23, 2020 08:49
@ghostghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger left review comments
@stephentoubstephentoubstephentoub approved these changes
@safernsafernsafern approved these changes

Assignees

@ViktorHoferViktorHofer

Labels

area-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address feedback from Mono CI PR

4 participants

@ViktorHofer@akoeplinger@stephentoub@safern