Uh oh!
There was an error while loading. Please reload this page.
[mono][xunit tests] Move skipped tests out of rsp file#2087
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
| using Xunit; | ||
| [assembly: SkipOnMono("System.ComponentModel.Composition.Registration APIs are not supported on this platform")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
| using Xunit; | ||
| [assembly: SkipOnMono("Flaky tests: https://github.com/mono/mono/issues/16417")] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -10,6 +10,7 @@ | ||
| namespace System.ComponentModel.Composition.AttributedModel | ||
| { | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public class AttributedModelCompositionTests | ||
| { | ||
| [Fact] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -16,6 +16,7 @@ namespace System.ComponentModel.Composition.AttributedModel | ||
| public class AttributedModelDiscoveryTests | ||
| { | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void CreatePartDefinition_TypeWithExports_ShouldHaveMultipleExports() | ||
| { | ||
| var definition = CreateDefinition(typeof(PublicComponentWithPublicExports)); | ||
| @@ -34,6 +35,7 @@ public class DerivedClassWithInheritedPropertyExports : BaseClassWithPropertyExp | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void CreatePartDefinition_TypeWithImports_ShouldHaveMultipleImports() | ||
| { | ||
| var definition = CreateDefinition(typeof(PublicImportsExpectingPublicExports)); | ||
| @@ -156,6 +158,7 @@ public void CreatePartDefinition_MultipleMarkedConstructorsAsPartTypeArgument_Sh | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked() | ||
| { | ||
| var definition = CreateDefinition(typeof(SimpleConstructorInjectedObject)); | ||
| @@ -167,6 +170,7 @@ public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldS | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldSetConstructorToDefault() | ||
| { | ||
| var definition = CreateDefinition(typeof(PublicComponentWithPublicExports)); | ||
| @@ -179,6 +183,7 @@ public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldS | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void CreatePartDefinition_OneMarkedAndOneDefaultConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked() | ||
| { | ||
| var definition = CreateDefinition(typeof(ClassWithOneMarkedAndOneDefaultConstructor)); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -23,6 +23,7 @@ public void OnImportsSatisfied() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void ImportsSatisfiedOnComponentWithoutImports() | ||
| { | ||
| CompositionContainer container = ContainerFactory.CreateWithAttributedCatalog(typeof(PartWithoutImports)); | ||
| @@ -35,6 +36,7 @@ public void ImportsSatisfiedOnComponentWithoutImports() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void ImportCompletedTest() | ||
| { | ||
| var container = ContainerFactory.Create(); | ||
| @@ -56,6 +58,7 @@ public void ImportCompletedTest() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void ImportCompletedWithRecomposing() | ||
| { | ||
| var container = ContainerFactory.Create(); | ||
| @@ -94,6 +97,7 @@ public void ImportCompletedWithRecomposing() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void ImportCompletedAddPartAndBindComponent() | ||
| { | ||
| var container = ContainerFactory.Create(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -145,6 +145,7 @@ public void Imports_Throws_OnNullContractName() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void Imports() | ||
| { | ||
| ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); | ||
| @@ -158,6 +159,7 @@ public void Imports() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void Imports_CardinalityIgnored_WhenNotSpecified() | ||
| { | ||
| ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); | ||
| @@ -170,6 +172,7 @@ public void Imports_CardinalityIgnored_WhenNotSpecified() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void Imports_CardinalityNotIgnored_WhenSpecified() | ||
| { | ||
| ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); | ||
| @@ -200,6 +203,7 @@ public void ImportsGeneric_Throws_OnNullPart() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void ImportsGeneric() | ||
| { | ||
| ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); | ||
| @@ -213,6 +217,7 @@ public void ImportsGeneric() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified() | ||
| { | ||
| ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); | ||
| @@ -225,6 +230,7 @@ public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void ImportsGeneric_CardinalityNotIgnored_WhenSpecified() | ||
| { | ||
| ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -74,6 +74,7 @@ public void GetValuesTest() | ||
| } | ||
| [Fact] | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public void NoResolverExceptionTest() | ||
| { | ||
| var container = ContainerFactory.Create(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -13,6 +13,7 @@ | ||
| namespace System.ComponentModel.Composition | ||
| { | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public class CompositionContainerCollectionTests | ||
| { | ||
| public class SupportedImportCollectionAssignments<T> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -13,6 +13,7 @@ | ||
| namespace System.ComponentModel.Composition | ||
| { | ||
| [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] | ||
| public class CompositionContainerImportTests | ||
| { | ||
| // Exporting collectin values is not supported | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attribute 'ActiveIssue' is not valid on this declaration type. It is only valid on 'class, method' declarations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm interesting. I don't see a good reason not to allow
ActiveIssueon assembly, will file a PR in dotnet/arcade.