Skip to content

Add conditional dependency on LLVM packages for Mono - #2140

Merged
steveisok merged 15 commits into
dotnet:masterfrom
directhex:mono-llvm-enablement
Feb 10, 2020
Merged

Add conditional dependency on LLVM packages for Mono#2140
steveisok merged 15 commits into
dotnet:masterfrom
directhex:mono-llvm-enablement

Conversation

@directhex

@directhexdirecthex commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

These are only restored or used when /p:MonoEnableLLVM=true

Creating as draft for now - there's one breakage I want help with (the restore only copies LLVM to the staging tree the second time it's run)

@directhex

directhex commented Jan 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Oh, forgot to add it to CI, too. I'll do that...

marek-safar
marek-safar reviewed Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml Outdated
@directhex
directhexforce-pushed the mono-llvm-enablement branch 3 times, most recently from 7821c22 to 5eec654CompareJanuary 24, 2020 18:50
akoeplinger
akoeplinger reviewed Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml Outdated

@akoeplingerakoeplingerJan 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to list all platforms/architectures here, the runtime.native.System.IO.Ports on line 19 doesn't do it either. We might need to change how we're producing that package.

@directhexdirecthexJan 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime.native.System.IO.Ports is a metapackage, and we don't have a metapackage for LLVM. We can add one, sure

@akoeplingerakoeplingerJan 27, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should do that.

@marek-safarmarek-safarJan 27, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should as the same package will be used for AOT tooling packages

@directhexdirecthexJan 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to use one metapackage to pull in AOT support (i.e. llc and opt binaries) for every single supported architecture in one go?

@marek-safarmarek-safarJan 27, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be RID driven for host (and possibly target) but the package should be identical to our internal dependency

@directhexdirecthexJan 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the split already in place here - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk contains LLVM for build-time (i.e. what we need internally to compile LLVM JIT Mono), runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools contains opt and llc, the two binaries needed for LLVM AOT support (i.e. end users would receive this, one way or another). If we want to rename things, I'm open to suggestions.

@directhex
directhexforce-pushed the mono-llvm-enablement branch 2 times, most recently from 67a6a44 to 7069651CompareJanuary 24, 2020 20:48
Jo Shields added 3 commits January 27, 2020 09:29
@directhex

directhex commented Jan 29, 2020

Copy link
Copy Markdown
ContributorAuthor

Okay. We're green, and building LLVM Mono. I'm going to try and get LLVM metapackages generated today, for cleaner dependency handling, but will mark this PR as not-draft tomorrow regardless of status (the metapackage is a nice-to-have, but explicitly not a blocker on functional LLVM builds)

akoeplinger
akoeplinger reviewed Jan 29, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj Outdated
Comment threadsrc/mono/mono.proj Outdated
Comment threadsrc/mono/llvm/llvm-init.proj Outdated
Comment threadsrc/mono/llvm/llvm-init.proj
directhexand others added 4 commits January 29, 2020 10:41
@directhex@akoeplinger
Update src/mono/mono.proj
bdb0ba3
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
@directhex@akoeplinger
Update src/mono/mono.proj
80e8527
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Jo Shields
Don't GeneratePathProperty since it doesn't work in Restore task
d51f23f
Jo Shields
Create MonoLLVMDir property and use it
f5feb5d
@directhex

directhex commented Jan 29, 2020

Copy link
Copy Markdown
ContributorAuthor

Those aren't my failures, they're the usual infra breakage.

I'm trying & failing to figure out how to drive the metapackage ("lineup package") creation functionality in Arcade.

@directhex
directhex marked this pull request as ready for review January 29, 2020 19:03
akoeplinger
akoeplinger approved these changes Jan 30, 2020
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml Outdated
@directhex

directhex commented Jan 31, 2020

Copy link
Copy Markdown
ContributorAuthor

The hell are some of these failures? I haven't touched CoreCLR Windows

marek-safar
marek-safar reviewed Feb 3, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml
@steveisoksteveisok mentioned this pull request Feb 4, 2020
Closed
24 tasks
@directhex

directhex commented Feb 4, 2020

Copy link
Copy Markdown
ContributorAuthor

I can't get Helix to give me the failure log from that run, I just get blob not found errors

@directhex

directhex commented Feb 5, 2020

Copy link
Copy Markdown
ContributorAuthor

OK well I guess the failures I was getting were flakes

@jaredparjaredpar mentioned this pull request Feb 5, 2020
Closed
@steveisok
steveisok merged commit 8504477 into dotnet:masterFeb 10, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@EgorBoEgorBoEgorBo approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees

No one assigned

Labels

area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@directhex@marek-safar@EgorBo@akoeplinger@ViktorHofer@steveisok@CoffeeFlux
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add conditional dependency on LLVM packages for Mono by directhex · Pull Request #2140 · dotnet/runtime · GitHub
Skip to content
Add conditional dependency on LLVM packages for Mono - #2140
Merged
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Feb 10, 2020
Merged
Add conditional dependency on LLVM packages for Mono#2140
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Conversation
@directhex
@directhexdirecthex
commented
Jan 24, 2020

Copy link


Copy Markdown

Contributor
These are only restored or used when /p:MonoEnableLLVM=true
Creating as draft for now - there's one breakage I want help with (the restore only copies LLVM to the staging tree the second time it's run)
@directhex
directhex
commented
Jan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Oh, forgot to add it to CI, too. I'll do that...
marek-safar
marek-safar
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
3 times, most recently
from
7821c22 to
5eec654CompareJanuary 24, 2020 18:50
akoeplinger
akoeplinger
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@akoeplingerakoeplingerJan 24, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to list all platforms/architectures here, the runtime.native.System.IO.Ports on line 19 doesn't do it either. We might need to change how we're producing that package.
@directhexdirecthexJan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime.native.System.IO.Ports is a metapackage, and we don't have a metapackage for LLVM. We can add one, sure
@akoeplingerakoeplingerJan 27, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should do that.
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should as the same package will be used for AOT tooling packages
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to use one metapackage to pull in AOT support (i.e. llc and opt binaries) for every single supported architecture in one go?
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be RID driven for host (and possibly target) but the package should be identical to our internal dependency
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the split already in place here - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk contains LLVM for build-time (i.e. what we need internally to compile LLVM JIT Mono), runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools contains opt and llc, the two binaries needed for LLVM AOT support (i.e. end users would receive this, one way or another). If we want to rename things, I'm open to suggestions.
@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
2 times, most recently
from
67a6a44 to
7069651CompareJanuary 24, 2020 20:48
Jo Shields
added 3 commits
January 27, 2020 09:29
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Okay. We're green, and building LLVM Mono. I'm going to try and get LLVM metapackages generated today, for cleaner dependency handling, but will mark this PR as not-draft tomorrow regardless of status (the metapackage is a nice-to-have, but explicitly not a blocker on functional LLVM builds)
akoeplinger
akoeplinger
reviewed
Jan 29, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
directhexand others
added 4 commits
January 29, 2020 10:41
@directhex@akoeplinger
Update src/mono/mono.proj
bdb0ba3
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
@directhex@akoeplinger
Update src/mono/mono.proj
80e8527
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Jo Shields
Don't GeneratePathProperty since it doesn't work in Restore task
d51f23f
Jo Shields
Create MonoLLVMDir property and use it
f5feb5d
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Those aren't my failures, they're the usual infra breakage.
I'm trying & failing to figure out how to drive the metapackage ("lineup package") creation functionality in Arcade.
@directhex
directhex
marked this pull request as ready for review
January 29, 2020 19:03
akoeplinger
akoeplinger
approved these changes
Jan 30, 2020
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml
Outdated

@directhex
directhex
commented
Jan 31, 2020

Copy link


Copy Markdown

ContributorAuthor
The hell are some of these failures? I haven't touched CoreCLR Windows
marek-safar
marek-safar
reviewed
Feb 3, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml
@steveisoksteveisok
mentioned this pull request
Feb 4, 2020

Closed

24 tasks
@directhex
directhex
commented
Feb 4, 2020

Copy link


Copy Markdown

ContributorAuthor
I can't get Helix to give me the failure log from that run, I just get blob not found errors
@directhex
directhex
commented
Feb 5, 2020

Copy link


Copy Markdown

ContributorAuthor
OK well I guess the failures I was getting were flakes
@jaredparjaredpar
mentioned this pull request
Feb 5, 2020

Closed

@steveisok
steveisok
merged commit 8504477
into
dotnet:masterFeb 10, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@EgorBoEgorBoEgorBo approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees


No one assigned


Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@directhex@marek-safar@EgorBo@akoeplinger@ViktorHofer@steveisok@CoffeeFlux

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add conditional dependency on LLVM packages for Mono by directhex · Pull Request #2140 · dotnet/runtime · GitHub
Skip to content
Add conditional dependency on LLVM packages for Mono - #2140
Merged
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Feb 10, 2020
Merged
Add conditional dependency on LLVM packages for Mono#2140
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Conversation
@directhex
@directhexdirecthex
commented
Jan 24, 2020

Copy link


Copy Markdown

Contributor
These are only restored or used when /p:MonoEnableLLVM=true
Creating as draft for now - there's one breakage I want help with (the restore only copies LLVM to the staging tree the second time it's run)
@directhex
directhex
commented
Jan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Oh, forgot to add it to CI, too. I'll do that...
marek-safar
marek-safar
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
3 times, most recently
from
7821c22 to
5eec654CompareJanuary 24, 2020 18:50
akoeplinger
akoeplinger
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@akoeplingerakoeplingerJan 24, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to list all platforms/architectures here, the runtime.native.System.IO.Ports on line 19 doesn't do it either. We might need to change how we're producing that package.
@directhexdirecthexJan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime.native.System.IO.Ports is a metapackage, and we don't have a metapackage for LLVM. We can add one, sure
@akoeplingerakoeplingerJan 27, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should do that.
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should as the same package will be used for AOT tooling packages
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to use one metapackage to pull in AOT support (i.e. llc and opt binaries) for every single supported architecture in one go?
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be RID driven for host (and possibly target) but the package should be identical to our internal dependency
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the split already in place here - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk contains LLVM for build-time (i.e. what we need internally to compile LLVM JIT Mono), runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools contains opt and llc, the two binaries needed for LLVM AOT support (i.e. end users would receive this, one way or another). If we want to rename things, I'm open to suggestions.
@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
2 times, most recently
from
67a6a44 to
7069651CompareJanuary 24, 2020 20:48
Jo Shields
added 3 commits
January 27, 2020 09:29
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Okay. We're green, and building LLVM Mono. I'm going to try and get LLVM metapackages generated today, for cleaner dependency handling, but will mark this PR as not-draft tomorrow regardless of status (the metapackage is a nice-to-have, but explicitly not a blocker on functional LLVM builds)
akoeplinger
akoeplinger
reviewed
Jan 29, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
directhexand others
added 4 commits
January 29, 2020 10:41
@directhex@akoeplinger
Update src/mono/mono.proj
bdb0ba3
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
@directhex@akoeplinger
Update src/mono/mono.proj
80e8527
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Jo Shields
Don't GeneratePathProperty since it doesn't work in Restore task
d51f23f
Jo Shields
Create MonoLLVMDir property and use it
f5feb5d
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Those aren't my failures, they're the usual infra breakage.
I'm trying & failing to figure out how to drive the metapackage ("lineup package") creation functionality in Arcade.
@directhex
directhex
marked this pull request as ready for review
January 29, 2020 19:03
akoeplinger
akoeplinger
approved these changes
Jan 30, 2020
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml
Outdated

@directhex
directhex
commented
Jan 31, 2020

Copy link


Copy Markdown

ContributorAuthor
The hell are some of these failures? I haven't touched CoreCLR Windows
marek-safar
marek-safar
reviewed
Feb 3, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml
@steveisoksteveisok
mentioned this pull request
Feb 4, 2020

Closed

24 tasks
@directhex
directhex
commented
Feb 4, 2020

Copy link


Copy Markdown

ContributorAuthor
I can't get Helix to give me the failure log from that run, I just get blob not found errors
@directhex
directhex
commented
Feb 5, 2020

Copy link


Copy Markdown

ContributorAuthor
OK well I guess the failures I was getting were flakes
@jaredparjaredpar
mentioned this pull request
Feb 5, 2020

Closed

@steveisok
steveisok
merged commit 8504477
into
dotnet:masterFeb 10, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@EgorBoEgorBoEgorBo approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees


No one assigned


Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@directhex@marek-safar@EgorBo@akoeplinger@ViktorHofer@steveisok@CoffeeFlux

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add conditional dependency on LLVM packages for Mono by directhex · Pull Request #2140 · dotnet/runtime · GitHub
Skip to content
Add conditional dependency on LLVM packages for Mono - #2140
Merged
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Feb 10, 2020
Merged
Add conditional dependency on LLVM packages for Mono#2140
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Conversation
@directhex
@directhexdirecthex
commented
Jan 24, 2020

Copy link


Copy Markdown

Contributor
These are only restored or used when /p:MonoEnableLLVM=true
Creating as draft for now - there's one breakage I want help with (the restore only copies LLVM to the staging tree the second time it's run)
@directhex
directhex
commented
Jan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Oh, forgot to add it to CI, too. I'll do that...
marek-safar
marek-safar
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
3 times, most recently
from
7821c22 to
5eec654CompareJanuary 24, 2020 18:50
akoeplinger
akoeplinger
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@akoeplingerakoeplingerJan 24, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to list all platforms/architectures here, the runtime.native.System.IO.Ports on line 19 doesn't do it either. We might need to change how we're producing that package.
@directhexdirecthexJan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime.native.System.IO.Ports is a metapackage, and we don't have a metapackage for LLVM. We can add one, sure
@akoeplingerakoeplingerJan 27, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should do that.
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should as the same package will be used for AOT tooling packages
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to use one metapackage to pull in AOT support (i.e. llc and opt binaries) for every single supported architecture in one go?
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be RID driven for host (and possibly target) but the package should be identical to our internal dependency
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the split already in place here - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk contains LLVM for build-time (i.e. what we need internally to compile LLVM JIT Mono), runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools contains opt and llc, the two binaries needed for LLVM AOT support (i.e. end users would receive this, one way or another). If we want to rename things, I'm open to suggestions.
@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
2 times, most recently
from
67a6a44 to
7069651CompareJanuary 24, 2020 20:48
Jo Shields
added 3 commits
January 27, 2020 09:29
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Okay. We're green, and building LLVM Mono. I'm going to try and get LLVM metapackages generated today, for cleaner dependency handling, but will mark this PR as not-draft tomorrow regardless of status (the metapackage is a nice-to-have, but explicitly not a blocker on functional LLVM builds)
akoeplinger
akoeplinger
reviewed
Jan 29, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
directhexand others
added 4 commits
January 29, 2020 10:41
@directhex@akoeplinger
Update src/mono/mono.proj
bdb0ba3
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
@directhex@akoeplinger
Update src/mono/mono.proj
80e8527
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Jo Shields
Don't GeneratePathProperty since it doesn't work in Restore task
d51f23f
Jo Shields
Create MonoLLVMDir property and use it
f5feb5d
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Those aren't my failures, they're the usual infra breakage.
I'm trying & failing to figure out how to drive the metapackage ("lineup package") creation functionality in Arcade.
@directhex
directhex
marked this pull request as ready for review
January 29, 2020 19:03
akoeplinger
akoeplinger
approved these changes
Jan 30, 2020
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml
Outdated

@directhex
directhex
commented
Jan 31, 2020

Copy link


Copy Markdown

ContributorAuthor
The hell are some of these failures? I haven't touched CoreCLR Windows
marek-safar
marek-safar
reviewed
Feb 3, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml
@steveisoksteveisok
mentioned this pull request
Feb 4, 2020

Closed

24 tasks
@directhex
directhex
commented
Feb 4, 2020

Copy link


Copy Markdown

ContributorAuthor
I can't get Helix to give me the failure log from that run, I just get blob not found errors
@directhex
directhex
commented
Feb 5, 2020

Copy link


Copy Markdown

ContributorAuthor
OK well I guess the failures I was getting were flakes
@jaredparjaredpar
mentioned this pull request
Feb 5, 2020

Closed

@steveisok
steveisok
merged commit 8504477
into
dotnet:masterFeb 10, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@EgorBoEgorBoEgorBo approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees


No one assigned


Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@directhex@marek-safar@EgorBo@akoeplinger@ViktorHofer@steveisok@CoffeeFlux

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add conditional dependency on LLVM packages for Mono by directhex · Pull Request #2140 · dotnet/runtime · GitHub
Skip to content
Add conditional dependency on LLVM packages for Mono - #2140
Merged
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Feb 10, 2020
Merged
Add conditional dependency on LLVM packages for Mono#2140
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Conversation
@directhex
@directhexdirecthex
commented
Jan 24, 2020

Copy link


Copy Markdown

Contributor
These are only restored or used when /p:MonoEnableLLVM=true
Creating as draft for now - there's one breakage I want help with (the restore only copies LLVM to the staging tree the second time it's run)
@directhex
directhex
commented
Jan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Oh, forgot to add it to CI, too. I'll do that...
marek-safar
marek-safar
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
3 times, most recently
from
7821c22 to
5eec654CompareJanuary 24, 2020 18:50
akoeplinger
akoeplinger
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@akoeplingerakoeplingerJan 24, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to list all platforms/architectures here, the runtime.native.System.IO.Ports on line 19 doesn't do it either. We might need to change how we're producing that package.
@directhexdirecthexJan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime.native.System.IO.Ports is a metapackage, and we don't have a metapackage for LLVM. We can add one, sure
@akoeplingerakoeplingerJan 27, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should do that.
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should as the same package will be used for AOT tooling packages
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to use one metapackage to pull in AOT support (i.e. llc and opt binaries) for every single supported architecture in one go?
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be RID driven for host (and possibly target) but the package should be identical to our internal dependency
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the split already in place here - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk contains LLVM for build-time (i.e. what we need internally to compile LLVM JIT Mono), runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools contains opt and llc, the two binaries needed for LLVM AOT support (i.e. end users would receive this, one way or another). If we want to rename things, I'm open to suggestions.
@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
2 times, most recently
from
67a6a44 to
7069651CompareJanuary 24, 2020 20:48
Jo Shields
added 3 commits
January 27, 2020 09:29
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Okay. We're green, and building LLVM Mono. I'm going to try and get LLVM metapackages generated today, for cleaner dependency handling, but will mark this PR as not-draft tomorrow regardless of status (the metapackage is a nice-to-have, but explicitly not a blocker on functional LLVM builds)
akoeplinger
akoeplinger
reviewed
Jan 29, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
directhexand others
added 4 commits
January 29, 2020 10:41
@directhex@akoeplinger
Update src/mono/mono.proj
bdb0ba3
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
@directhex@akoeplinger
Update src/mono/mono.proj
80e8527
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Jo Shields
Don't GeneratePathProperty since it doesn't work in Restore task
d51f23f
Jo Shields
Create MonoLLVMDir property and use it
f5feb5d
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Those aren't my failures, they're the usual infra breakage.
I'm trying & failing to figure out how to drive the metapackage ("lineup package") creation functionality in Arcade.
@directhex
directhex
marked this pull request as ready for review
January 29, 2020 19:03
akoeplinger
akoeplinger
approved these changes
Jan 30, 2020
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml
Outdated

@directhex
directhex
commented
Jan 31, 2020

Copy link


Copy Markdown

ContributorAuthor
The hell are some of these failures? I haven't touched CoreCLR Windows
marek-safar
marek-safar
reviewed
Feb 3, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml
@steveisoksteveisok
mentioned this pull request
Feb 4, 2020

Closed

24 tasks
@directhex
directhex
commented
Feb 4, 2020

Copy link


Copy Markdown

ContributorAuthor
I can't get Helix to give me the failure log from that run, I just get blob not found errors
@directhex
directhex
commented
Feb 5, 2020

Copy link


Copy Markdown

ContributorAuthor
OK well I guess the failures I was getting were flakes
@jaredparjaredpar
mentioned this pull request
Feb 5, 2020

Closed

@steveisok
steveisok
merged commit 8504477
into
dotnet:masterFeb 10, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@EgorBoEgorBoEgorBo approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees


No one assigned


Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@directhex@marek-safar@EgorBo@akoeplinger@ViktorHofer@steveisok@CoffeeFlux

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add conditional dependency on LLVM packages for Mono by directhex · Pull Request #2140 · dotnet/runtime · GitHub
Skip to content
Add conditional dependency on LLVM packages for Mono - #2140
Merged
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Feb 10, 2020
Merged
Add conditional dependency on LLVM packages for Mono#2140
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Conversation
@directhex
@directhexdirecthex
commented
Jan 24, 2020

Copy link


Copy Markdown

Contributor
These are only restored or used when /p:MonoEnableLLVM=true
Creating as draft for now - there's one breakage I want help with (the restore only copies LLVM to the staging tree the second time it's run)
@directhex
directhex
commented
Jan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Oh, forgot to add it to CI, too. I'll do that...
marek-safar
marek-safar
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
3 times, most recently
from
7821c22 to
5eec654CompareJanuary 24, 2020 18:50
akoeplinger
akoeplinger
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@akoeplingerakoeplingerJan 24, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to list all platforms/architectures here, the runtime.native.System.IO.Ports on line 19 doesn't do it either. We might need to change how we're producing that package.
@directhexdirecthexJan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime.native.System.IO.Ports is a metapackage, and we don't have a metapackage for LLVM. We can add one, sure
@akoeplingerakoeplingerJan 27, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should do that.
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should as the same package will be used for AOT tooling packages
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to use one metapackage to pull in AOT support (i.e. llc and opt binaries) for every single supported architecture in one go?
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be RID driven for host (and possibly target) but the package should be identical to our internal dependency
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the split already in place here - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk contains LLVM for build-time (i.e. what we need internally to compile LLVM JIT Mono), runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools contains opt and llc, the two binaries needed for LLVM AOT support (i.e. end users would receive this, one way or another). If we want to rename things, I'm open to suggestions.
@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
2 times, most recently
from
67a6a44 to
7069651CompareJanuary 24, 2020 20:48
Jo Shields
added 3 commits
January 27, 2020 09:29
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Okay. We're green, and building LLVM Mono. I'm going to try and get LLVM metapackages generated today, for cleaner dependency handling, but will mark this PR as not-draft tomorrow regardless of status (the metapackage is a nice-to-have, but explicitly not a blocker on functional LLVM builds)
akoeplinger
akoeplinger
reviewed
Jan 29, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
directhexand others
added 4 commits
January 29, 2020 10:41
@directhex@akoeplinger
Update src/mono/mono.proj
bdb0ba3
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
@directhex@akoeplinger
Update src/mono/mono.proj
80e8527
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Jo Shields
Don't GeneratePathProperty since it doesn't work in Restore task
d51f23f
Jo Shields
Create MonoLLVMDir property and use it
f5feb5d
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Those aren't my failures, they're the usual infra breakage.
I'm trying & failing to figure out how to drive the metapackage ("lineup package") creation functionality in Arcade.
@directhex
directhex
marked this pull request as ready for review
January 29, 2020 19:03
akoeplinger
akoeplinger
approved these changes
Jan 30, 2020
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml
Outdated

@directhex
directhex
commented
Jan 31, 2020

Copy link


Copy Markdown

ContributorAuthor
The hell are some of these failures? I haven't touched CoreCLR Windows
marek-safar
marek-safar
reviewed
Feb 3, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml
@steveisoksteveisok
mentioned this pull request
Feb 4, 2020

Closed

24 tasks
@directhex
directhex
commented
Feb 4, 2020

Copy link


Copy Markdown

ContributorAuthor
I can't get Helix to give me the failure log from that run, I just get blob not found errors
@directhex
directhex
commented
Feb 5, 2020

Copy link


Copy Markdown

ContributorAuthor
OK well I guess the failures I was getting were flakes
@jaredparjaredpar
mentioned this pull request
Feb 5, 2020

Closed

@steveisok
steveisok
merged commit 8504477
into
dotnet:masterFeb 10, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@EgorBoEgorBoEgorBo approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees


No one assigned


Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@directhex@marek-safar@EgorBo@akoeplinger@ViktorHofer@steveisok@CoffeeFlux

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add conditional dependency on LLVM packages for Mono by directhex · Pull Request #2140 · dotnet/runtime · GitHub
Skip to content
Add conditional dependency on LLVM packages for Mono - #2140
Merged
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Feb 10, 2020
Merged
Add conditional dependency on LLVM packages for Mono#2140
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Conversation
@directhex
@directhexdirecthex
commented
Jan 24, 2020

Copy link


Copy Markdown

Contributor
These are only restored or used when /p:MonoEnableLLVM=true
Creating as draft for now - there's one breakage I want help with (the restore only copies LLVM to the staging tree the second time it's run)
@directhex
directhex
commented
Jan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Oh, forgot to add it to CI, too. I'll do that...
marek-safar
marek-safar
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
3 times, most recently
from
7821c22 to
5eec654CompareJanuary 24, 2020 18:50
akoeplinger
akoeplinger
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@akoeplingerakoeplingerJan 24, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to list all platforms/architectures here, the runtime.native.System.IO.Ports on line 19 doesn't do it either. We might need to change how we're producing that package.
@directhexdirecthexJan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime.native.System.IO.Ports is a metapackage, and we don't have a metapackage for LLVM. We can add one, sure
@akoeplingerakoeplingerJan 27, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should do that.
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should as the same package will be used for AOT tooling packages
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to use one metapackage to pull in AOT support (i.e. llc and opt binaries) for every single supported architecture in one go?
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be RID driven for host (and possibly target) but the package should be identical to our internal dependency
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the split already in place here - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk contains LLVM for build-time (i.e. what we need internally to compile LLVM JIT Mono), runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools contains opt and llc, the two binaries needed for LLVM AOT support (i.e. end users would receive this, one way or another). If we want to rename things, I'm open to suggestions.
@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
2 times, most recently
from
67a6a44 to
7069651CompareJanuary 24, 2020 20:48
Jo Shields
added 3 commits
January 27, 2020 09:29
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Okay. We're green, and building LLVM Mono. I'm going to try and get LLVM metapackages generated today, for cleaner dependency handling, but will mark this PR as not-draft tomorrow regardless of status (the metapackage is a nice-to-have, but explicitly not a blocker on functional LLVM builds)
akoeplinger
akoeplinger
reviewed
Jan 29, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
directhexand others
added 4 commits
January 29, 2020 10:41
@directhex@akoeplinger
Update src/mono/mono.proj
bdb0ba3
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
@directhex@akoeplinger
Update src/mono/mono.proj
80e8527
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Jo Shields
Don't GeneratePathProperty since it doesn't work in Restore task
d51f23f
Jo Shields
Create MonoLLVMDir property and use it
f5feb5d
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Those aren't my failures, they're the usual infra breakage.
I'm trying & failing to figure out how to drive the metapackage ("lineup package") creation functionality in Arcade.
@directhex
directhex
marked this pull request as ready for review
January 29, 2020 19:03
akoeplinger
akoeplinger
approved these changes
Jan 30, 2020
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml
Outdated

@directhex
directhex
commented
Jan 31, 2020

Copy link


Copy Markdown

ContributorAuthor
The hell are some of these failures? I haven't touched CoreCLR Windows
marek-safar
marek-safar
reviewed
Feb 3, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml
@steveisoksteveisok
mentioned this pull request
Feb 4, 2020

Closed

24 tasks
@directhex
directhex
commented
Feb 4, 2020

Copy link


Copy Markdown

ContributorAuthor
I can't get Helix to give me the failure log from that run, I just get blob not found errors
@directhex
directhex
commented
Feb 5, 2020

Copy link


Copy Markdown

ContributorAuthor
OK well I guess the failures I was getting were flakes
@jaredparjaredpar
mentioned this pull request
Feb 5, 2020

Closed

@steveisok
steveisok
merged commit 8504477
into
dotnet:masterFeb 10, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@EgorBoEgorBoEgorBo approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees


No one assigned


Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@directhex@marek-safar@EgorBo@akoeplinger@ViktorHofer@steveisok@CoffeeFlux

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add conditional dependency on LLVM packages for Mono by directhex · Pull Request #2140 · dotnet/runtime · GitHub
Skip to content
Add conditional dependency on LLVM packages for Mono - #2140
Merged
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Feb 10, 2020
Merged
Add conditional dependency on LLVM packages for Mono#2140
steveisok merged 15 commits into
dotnet:masterfrom 
directhex:mono-llvm-enablement
Conversation
@directhex
@directhexdirecthex
commented
Jan 24, 2020

Copy link


Copy Markdown

Contributor
These are only restored or used when /p:MonoEnableLLVM=true
Creating as draft for now - there's one breakage I want help with (the restore only copies LLVM to the staging tree the second time it's run)
@directhex
directhex
commented
Jan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Oh, forgot to add it to CI, too. I'll do that...
marek-safar
marek-safar
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
3 times, most recently
from
7821c22 to
5eec654CompareJanuary 24, 2020 18:50
akoeplinger
akoeplinger
reviewed
Jan 24, 2020
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@akoeplingerakoeplingerJan 24, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to list all platforms/architectures here, the runtime.native.System.IO.Ports on line 19 doesn't do it either. We might need to change how we're producing that package.
@directhexdirecthexJan 24, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime.native.System.IO.Ports is a metapackage, and we don't have a metapackage for LLVM. We can add one, sure
@akoeplingerakoeplingerJan 27, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should do that.
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should as the same package will be used for AOT tooling packages
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to use one metapackage to pull in AOT support (i.e. llc and opt binaries) for every single supported architecture in one go?
@marek-safarmarek-safarJan 27, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be RID driven for host (and possibly target) but the package should be identical to our internal dependency
@directhexdirecthexJan 27, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the split already in place here - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk contains LLVM for build-time (i.e. what we need internally to compile LLVM JIT Mono), runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools contains opt and llc, the two binaries needed for LLVM AOT support (i.e. end users would receive this, one way or another). If we want to rename things, I'm open to suggestions.
@directhex
directhexforce-pushed
the
mono-llvm-enablement
branch
2 times, most recently
from
67a6a44 to
7069651CompareJanuary 24, 2020 20:48
Jo Shields
added 3 commits
January 27, 2020 09:29
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Okay. We're green, and building LLVM Mono. I'm going to try and get LLVM metapackages generated today, for cleaner dependency handling, but will mark this PR as not-draft tomorrow regardless of status (the metapackage is a nice-to-have, but explicitly not a blocker on functional LLVM builds)
akoeplinger
akoeplinger
reviewed
Jan 29, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/mono.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
Outdated

Comment threadsrc/mono/llvm/llvm-init.proj
directhexand others
added 4 commits
January 29, 2020 10:41
@directhex@akoeplinger
Update src/mono/mono.proj
bdb0ba3
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
@directhex@akoeplinger
Update src/mono/mono.proj
80e8527
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Jo Shields
Don't GeneratePathProperty since it doesn't work in Restore task
d51f23f
Jo Shields
Create MonoLLVMDir property and use it
f5feb5d
@directhex
directhex
commented
Jan 29, 2020

Copy link


Copy Markdown

ContributorAuthor
Those aren't my failures, they're the usual infra breakage.
I'm trying & failing to figure out how to drive the metapackage ("lineup package") creation functionality in Arcade.
@directhex
directhex
marked this pull request as ready for review
January 29, 2020 19:03
akoeplinger
akoeplinger
approved these changes
Jan 30, 2020
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml
Outdated

@directhex
directhex
commented
Jan 31, 2020

Copy link


Copy Markdown

ContributorAuthor
The hell are some of these failures? I haven't touched CoreCLR Windows
marek-safar
marek-safar
reviewed
Feb 3, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml
@steveisoksteveisok
mentioned this pull request
Feb 4, 2020

Closed

24 tasks
@directhex
directhex
commented
Feb 4, 2020

Copy link


Copy Markdown

ContributorAuthor
I can't get Helix to give me the failure log from that run, I just get blob not found errors
@directhex
directhex
commented
Feb 5, 2020

Copy link


Copy Markdown

ContributorAuthor
OK well I guess the failures I was getting were flakes
@jaredparjaredpar
mentioned this pull request
Feb 5, 2020

Closed

@steveisok
steveisok
merged commit 8504477
into
dotnet:masterFeb 10, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@EgorBoEgorBoEgorBo approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees


No one assigned


Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@directhex@marek-safar@EgorBo@akoeplinger@ViktorHofer@steveisok@CoffeeFlux