Add public methods that remove path redundant segments by carlossanlop · Pull Request #2187 · dotnet/runtime

carlossanlop · 2020-01-25T02:39:28Z

MihaZupan · 2020-01-27T13:58:58Z

The purpose of TryRemoveRedundantSegments accepting a Span destination is to avoid allocations. As such, it can't delegate to the string-returning methods and only do a copy.

carlossanlop · 2020-02-20T23:17:01Z

I'll close this issue while it's in draft mode. I'll reopen when the unit tests are ready.

carlossanlop · 2020-02-22T04:58:41Z

@jkotas Need your help - I cannot rebase because your change #31991 deleted the file ref/System.Runtime.Extensions.cs.

Where should I put my new method references now?

jkotas · 2020-02-22T05:26:13Z

Where should I put my new method references now?

src/libraries/System.Runtime/ref/System.Runtime.cs

jkotas · 2020-02-22T15:31:24Z

ValueStringBuilder is meant to be used with stackallocated buffer for sizes up to certain limit. Getting a pooled buffer has too much overhead for small buffers.

carlossanlop · 2020-02-22T20:50:06Z

@JeremyKuhne - I'm investigating these tests where I put a comment next to them, because their behavior was slightly different than expected.
I also noticed the resulting path is different in Windows than in Unix, because of the separator char used.

I talked with Jeremy about the expected behavior on each edge case. I am adding tests to verify them.

carlossanlop · 2020-04-21T21:43:45Z

Currently blocked by a bug I found in Path.GetPathRoot, which is the reason why some of the unit tests are failing in the CI: #35260.
I'm investigating it.

…rt type 'string' to 'System.ReadOnlySpan<char>'.

…he span overloads of GetPathRoot and IsPathFullyQualified inside PathInternal.

…ute.

jkotas · 2020-04-22T22:02:23Z

 if (string.IsNullOrEmpty(path))
 return path;

+ Span<char> destination = stackalloc char[path.Length];


Unbounded stackallocs are prohibited in dotnet/runtime libraries

@stephentoub I don't see record of a discussion about trying to catch this with an analyzer. It's not generally possible to be sure (either way) whether it's unbounded. But an analyzer that forced a pattern of passing a constant value would be doable.
Looking at all our stackallocs, almost all of them already pass a constant directly or via a constant field or local. The few exceptions are not self evidently safe by eyeball, eg.,
privatestaticunsafeintEncryptDecryptHelper(OPop,ISSPIInterfacesecModule,SafeDeleteContextcontext,Span<SecurityBuffer>input,uintsequenceNumber){Interop.SspiCli.SecBufferDescsdcInOut=newInterop.SspiCli.SecBufferDesc(input.Length);Span<Interop.SspiCli.SecBuffer>unmanagedBuffer=stackallocInterop.SspiCli.SecBuffer[input.Length];
and it would be easy for one of them to be wrong. Would it be reasonable to have an analyzer that required them to be rewritten in constant terms, or at least something the analyzer could recognize like
Span<Interop.SspiCli.SecBuffer>unmanagedBuffer=stackallocInterop.SspiCli.SecBuffer[Math.Min(input.Length,BufferSize)];

Moved to #35382

carlossanlop · 2020-05-02T04:47:39Z

I'll close this while I address the Unix failures.

carlossanlop added the area-System.IO label Jan 25, 2020

carlossanlop added this to the 5.0 milestone Jan 25, 2020

carlossanlop requested review from Anipik and JeremyKuhne January 25, 2020 02:39

carlossanlop self-assigned this Jan 25, 2020

jkotas reviewed Jan 25, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

jkotas reviewed Jan 25, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

jkotas reviewed Jan 25, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.Windows.cs Outdated

jkotas reviewed Jan 25, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

jkotas reviewed Jan 25, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/PathInternal.cs Outdated

jkotas reviewed Jan 25, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/PathInternal.cs Outdated

jkotas reviewed Jan 25, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/PathInternal.cs Outdated

maryamariyan added the new-api-needs-documentation label Jan 27, 2020

carlossanlop commented Feb 8, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

Anipik reviewed Feb 13, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

ahsonkhan reviewed Feb 19, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

ahsonkhan reviewed Feb 19, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/PathInternal.cs Outdated

carlossanlop commented Feb 19, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

JeremyKuhne reviewed Feb 19, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/PathInternal.cs Outdated

ahsonkhan reviewed Feb 20, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

carlossanlop closed this Feb 20, 2020

carlossanlop reopened this Feb 22, 2020

carlossanlop marked this pull request as ready for review February 22, 2020 04:43

jkotas reviewed Feb 22, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

jkotas reviewed Feb 22, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

jkotas reviewed Feb 22, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

jkotas reviewed Feb 22, 2020
View reviewed changes

carlossanlop commented Feb 22, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/IO/Path.RemoveRedundantSegments.cs Outdated

carlossanlop commented Feb 22, 2020
View reviewed changes

drieseng reviewed Feb 22, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

jkotas reviewed Feb 22, 2020
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/Path.cs Outdated

carlossanlop mentioned this pull request Apr 21, 2020
Different output in Unix between Path.GetPathRoot overloads for redundant segments #35260
Closed

carlossanlop requested a review from a teamApril 22, 2020 03:57

carlossanlop added 6 commits April 22, 2020 12:53

Add methods that remove path redundant segments
5861033

Move refs from System.Runtime.Extensions.cs to System.Runtime.cs
2086bcc

Address ValueStringBuilder disposing cases
4f033d9

Fix Microsoft.IO.Redist build failure due to: Cannot implicitly conve…
cc0015e
…rt type 'string' to 'System.ReadOnlySpan<char>'.

Add support for non-fully qualified paths.
9dc4ada

Fix build break in net472 for Microsoft.IO.Redist by avoiding using t…
87c031d
…he span overloads of GetPathRoot and IsPathFullyQualified inside PathInternal.

carlossanlop removed the request for review from a teamApril 22, 2020 19:56

Made some methods span based. Added a missing PlatformSpecific attrib…
3cfbe45
…ute.

jkotas reviewed Apr 22, 2020
View reviewed changes

danmoseley mentioned this pull request Apr 24, 2020
Analyzer for potentially unbounded stackallocs #35382
Open

carlossanlop mentioned this pull request May 2, 2020
Fix Path.GetPathRoot wrong check in Unix #35734
Merged

carlossanlop closed this May 2, 2020

carlossanlop mentioned this pull request Jun 25, 2020
Add APIs that remove redundant segments from paths #37939
Closed

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Uh oh!

Conversation

carlossanlop commented Jan 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MihaZupan commented Jan 27, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlossanlop commented Feb 20, 2020

Uh oh!

carlossanlop commented Feb 22, 2020

Uh oh!

jkotas commented Feb 22, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotasFeb 22, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carlossanlopFeb 22, 2020

Choose a reason for hiding this comment

Uh oh!

carlossanlopMar 6, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

carlossanlop commented Apr 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkotasApr 22, 2020

Choose a reason for hiding this comment

Uh oh!

danmoseleyApr 22, 2020

Choose a reason for hiding this comment

Uh oh!

danmoseleyApr 24, 2020

Choose a reason for hiding this comment

Uh oh!

carlossanlop commented May 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

carlossanlop commented Jan 25, 2020•
edited
Loading

carlossanlop commented Apr 21, 2020•
edited
Loading