Add RunSample target to mono.proj

[EgorBo]

1. Delete src/mono/netcore/corerun/ folder, we can build/use coreclr's corerun (it has --clr-path)
2. Add RunSample to build & run HelloWorld with mono runtime.

[steveisok]

@EgorBo Can we add makefile targets in order to make it easier for some of us to use?

[akoeplinger]

Good start but we should move more of the logic into msbuild :)

outdated review

[marek-safar]

I am not sure it's worth it. I'd prefer to have better documentation for this instead

[EgorBo]

@marek-safar um.. what exactly is not worth it? -- having the RunSample target?

[marek-safar]

yeah, I'd much rather see documentation with working steps for dotnet new .... to run on MonoVM

[steveisok]

Wouldn't this have temporary value until we figure that part out? I know some people like to use RunSample as an easy way to test their stuff.

[marek-safar]

I guess we figure it out already if we can run the sample which is form of dotnet new console

[steveisok]

I see what you mean. Yeah, I agree.

[EgorBo]

it seems most of us use HelloWorld for experiments/fixes/improvements. Do you suggest to remove it and let everybody do:

dotnet new console
dotnet publish -c Release -r osx-x64
copy libcoreclr.dylib & SPC.dll by hands to the publish directory

instead of make run-sample ?

Currently run-sample doesn't require patching local .dotnet (which imo should be avoided if possible). Also there is a rule make run-sample-coreclr which does use local .dotnet (useful to compare results between both runtimes)

[marek-safar]

yep, I think having this document something is more valuable than having it in Makefile (although you can keep sample of this example if you think it's valuable)

[EgorBo]

I've simplified all the things so now runsample uses local dotnet. But I personally would prefer to keep it at least for a while.

[akoeplinger]

looks almost perfect, just needs a few little fixes :)

[akoeplinger]

missing parenthesis but looks good otherwise

[EgorBo]

Sorry, forgot to squash it 😢 (it used to be a default behavior in mono/mono)

[EgorBo]

1. Delete src/mono/netcore/corerun/ folder, we can build/use coreclr's corerun (it has --clr-path)
2. Add RunSample to build & run HelloWorld with mono runtime.

[steveisok]

@EgorBo Can we add makefile targets in order to make it easier for some of us to use?

[akoeplinger]

Good start but we should move more of the logic into msbuild :)

outdated review

[marek-safar]

I am not sure it's worth it. I'd prefer to have better documentation for this instead

[EgorBo]

@marek-safar um.. what exactly is not worth it? -- having the RunSample target?

[marek-safar]

yeah, I'd much rather see documentation with working steps for dotnet new .... to run on MonoVM

[steveisok]

Wouldn't this have temporary value until we figure that part out? I know some people like to use RunSample as an easy way to test their stuff.

[marek-safar]

I guess we figure it out already if we can run the sample which is form of dotnet new console

[steveisok]

I see what you mean. Yeah, I agree.

[EgorBo]

it seems most of us use HelloWorld for experiments/fixes/improvements. Do you suggest to remove it and let everybody do:

dotnet new console
dotnet publish -c Release -r osx-x64
copy libcoreclr.dylib & SPC.dll by hands to the publish directory

instead of make run-sample ?

Currently run-sample doesn't require patching local .dotnet (which imo should be avoided if possible). Also there is a rule make run-sample-coreclr which does use local .dotnet (useful to compare results between both runtimes)

[marek-safar]

yep, I think having this document something is more valuable than having it in Makefile (although you can keep sample of this example if you think it's valuable)

[EgorBo]

I've simplified all the things so now runsample uses local dotnet. But I personally would prefer to keep it at least for a while.

[akoeplinger]

looks almost perfect, just needs a few little fixes :)

[akoeplinger]

missing parenthesis but looks good otherwise

[EgorBo]

Sorry, forgot to squash it 😢 (it used to be a default behavior in mono/mono)

[EgorBo]

1. Delete src/mono/netcore/corerun/ folder, we can build/use coreclr's corerun (it has --clr-path)
2. Add RunSample to build & run HelloWorld with mono runtime.

[steveisok]

@EgorBo Can we add makefile targets in order to make it easier for some of us to use?

[akoeplinger]

Good start but we should move more of the logic into msbuild :)

outdated review

[marek-safar]

I am not sure it's worth it. I'd prefer to have better documentation for this instead

[EgorBo]

@marek-safar um.. what exactly is not worth it? -- having the RunSample target?

[marek-safar]

yeah, I'd much rather see documentation with working steps for dotnet new .... to run on MonoVM

[steveisok]

Wouldn't this have temporary value until we figure that part out? I know some people like to use RunSample as an easy way to test their stuff.

[marek-safar]

I guess we figure it out already if we can run the sample which is form of dotnet new console

[steveisok]

I see what you mean. Yeah, I agree.

[EgorBo]

it seems most of us use HelloWorld for experiments/fixes/improvements. Do you suggest to remove it and let everybody do:

dotnet new console
dotnet publish -c Release -r osx-x64
copy libcoreclr.dylib & SPC.dll by hands to the publish directory

instead of make run-sample ?

Currently run-sample doesn't require patching local .dotnet (which imo should be avoided if possible). Also there is a rule make run-sample-coreclr which does use local .dotnet (useful to compare results between both runtimes)

[marek-safar]

yep, I think having this document something is more valuable than having it in Makefile (although you can keep sample of this example if you think it's valuable)

[EgorBo]

I've simplified all the things so now runsample uses local dotnet. But I personally would prefer to keep it at least for a while.

[akoeplinger]

looks almost perfect, just needs a few little fixes :)

[akoeplinger]

missing parenthesis but looks good otherwise

[EgorBo]

Sorry, forgot to squash it 😢 (it used to be a default behavior in mono/mono)

[EgorBo]

1. Delete src/mono/netcore/corerun/ folder, we can build/use coreclr's corerun (it has --clr-path)
2. Add RunSample to build & run HelloWorld with mono runtime.

[steveisok]

@EgorBo Can we add makefile targets in order to make it easier for some of us to use?

[akoeplinger]

Good start but we should move more of the logic into msbuild :)

outdated review

[marek-safar]

I am not sure it's worth it. I'd prefer to have better documentation for this instead

[EgorBo]

@marek-safar um.. what exactly is not worth it? -- having the RunSample target?

[marek-safar]

yeah, I'd much rather see documentation with working steps for dotnet new .... to run on MonoVM

[steveisok]

Wouldn't this have temporary value until we figure that part out? I know some people like to use RunSample as an easy way to test their stuff.

[marek-safar]

I guess we figure it out already if we can run the sample which is form of dotnet new console

[steveisok]

I see what you mean. Yeah, I agree.

[EgorBo]

it seems most of us use HelloWorld for experiments/fixes/improvements. Do you suggest to remove it and let everybody do:

dotnet new console
dotnet publish -c Release -r osx-x64
copy libcoreclr.dylib & SPC.dll by hands to the publish directory

instead of make run-sample ?

Currently run-sample doesn't require patching local .dotnet (which imo should be avoided if possible). Also there is a rule make run-sample-coreclr which does use local .dotnet (useful to compare results between both runtimes)

[marek-safar]

yep, I think having this document something is more valuable than having it in Makefile (although you can keep sample of this example if you think it's valuable)

[EgorBo]

I've simplified all the things so now runsample uses local dotnet. But I personally would prefer to keep it at least for a while.

[akoeplinger]

looks almost perfect, just needs a few little fixes :)

[akoeplinger]

missing parenthesis but looks good otherwise

[EgorBo]

Sorry, forgot to squash it 😢 (it used to be a default behavior in mono/mono)

[EgorBo]

1. Delete src/mono/netcore/corerun/ folder, we can build/use coreclr's corerun (it has --clr-path)
2. Add RunSample to build & run HelloWorld with mono runtime.

[steveisok]

@EgorBo Can we add makefile targets in order to make it easier for some of us to use?

[akoeplinger]

Good start but we should move more of the logic into msbuild :)

outdated review

[marek-safar]

I am not sure it's worth it. I'd prefer to have better documentation for this instead

[EgorBo]

@marek-safar um.. what exactly is not worth it? -- having the RunSample target?

[marek-safar]

yeah, I'd much rather see documentation with working steps for dotnet new .... to run on MonoVM

[steveisok]

Wouldn't this have temporary value until we figure that part out? I know some people like to use RunSample as an easy way to test their stuff.

[marek-safar]

I guess we figure it out already if we can run the sample which is form of dotnet new console

[steveisok]

I see what you mean. Yeah, I agree.

[EgorBo]

it seems most of us use HelloWorld for experiments/fixes/improvements. Do you suggest to remove it and let everybody do:

dotnet new console
dotnet publish -c Release -r osx-x64
copy libcoreclr.dylib & SPC.dll by hands to the publish directory

instead of make run-sample ?

Currently run-sample doesn't require patching local .dotnet (which imo should be avoided if possible). Also there is a rule make run-sample-coreclr which does use local .dotnet (useful to compare results between both runtimes)

[marek-safar]

yep, I think having this document something is more valuable than having it in Makefile (although you can keep sample of this example if you think it's valuable)

[EgorBo]

I've simplified all the things so now runsample uses local dotnet. But I personally would prefer to keep it at least for a while.

[akoeplinger]

looks almost perfect, just needs a few little fixes :)

[akoeplinger]

missing parenthesis but looks good otherwise

[EgorBo]

Sorry, forgot to squash it 😢 (it used to be a default behavior in mono/mono)

[EgorBo]

1. Delete src/mono/netcore/corerun/ folder, we can build/use coreclr's corerun (it has --clr-path)
2. Add RunSample to build & run HelloWorld with mono runtime.

[steveisok]

@EgorBo Can we add makefile targets in order to make it easier for some of us to use?

[akoeplinger]

Good start but we should move more of the logic into msbuild :)

outdated review

[marek-safar]

I am not sure it's worth it. I'd prefer to have better documentation for this instead

[EgorBo]

@marek-safar um.. what exactly is not worth it? -- having the RunSample target?

[marek-safar]

yeah, I'd much rather see documentation with working steps for dotnet new .... to run on MonoVM

[steveisok]

Wouldn't this have temporary value until we figure that part out? I know some people like to use RunSample as an easy way to test their stuff.

[marek-safar]

I guess we figure it out already if we can run the sample which is form of dotnet new console

[steveisok]

I see what you mean. Yeah, I agree.

[EgorBo]

it seems most of us use HelloWorld for experiments/fixes/improvements. Do you suggest to remove it and let everybody do:

dotnet new console
dotnet publish -c Release -r osx-x64
copy libcoreclr.dylib & SPC.dll by hands to the publish directory

instead of make run-sample ?

Currently run-sample doesn't require patching local .dotnet (which imo should be avoided if possible). Also there is a rule make run-sample-coreclr which does use local .dotnet (useful to compare results between both runtimes)

[marek-safar]

yep, I think having this document something is more valuable than having it in Makefile (although you can keep sample of this example if you think it's valuable)

[EgorBo]

I've simplified all the things so now runsample uses local dotnet. But I personally would prefer to keep it at least for a while.

[akoeplinger]

looks almost perfect, just needs a few little fixes :)

[akoeplinger]

missing parenthesis but looks good otherwise

[EgorBo]

Sorry, forgot to squash it 😢 (it used to be a default behavior in mono/mono)

[EgorBo]

1. Delete src/mono/netcore/corerun/ folder, we can build/use coreclr's corerun (it has --clr-path)
2. Add RunSample to build & run HelloWorld with mono runtime.

[steveisok]

@EgorBo Can we add makefile targets in order to make it easier for some of us to use?

[akoeplinger]

Good start but we should move more of the logic into msbuild :)

outdated review

[marek-safar]

I am not sure it's worth it. I'd prefer to have better documentation for this instead

[EgorBo]

@marek-safar um.. what exactly is not worth it? -- having the RunSample target?

[marek-safar]

yeah, I'd much rather see documentation with working steps for dotnet new .... to run on MonoVM

[steveisok]

Wouldn't this have temporary value until we figure that part out? I know some people like to use RunSample as an easy way to test their stuff.

[marek-safar]

I guess we figure it out already if we can run the sample which is form of dotnet new console

[steveisok]

I see what you mean. Yeah, I agree.

[EgorBo]

it seems most of us use HelloWorld for experiments/fixes/improvements. Do you suggest to remove it and let everybody do:

dotnet new console
dotnet publish -c Release -r osx-x64
copy libcoreclr.dylib & SPC.dll by hands to the publish directory

instead of make run-sample ?

Currently run-sample doesn't require patching local .dotnet (which imo should be avoided if possible). Also there is a rule make run-sample-coreclr which does use local .dotnet (useful to compare results between both runtimes)

[marek-safar]

yep, I think having this document something is more valuable than having it in Makefile (although you can keep sample of this example if you think it's valuable)

[EgorBo]

I've simplified all the things so now runsample uses local dotnet. But I personally would prefer to keep it at least for a while.

[akoeplinger]

looks almost perfect, just needs a few little fixes :)

[akoeplinger]

missing parenthesis but looks good otherwise

[EgorBo]

Sorry, forgot to squash it 😢 (it used to be a default behavior in mono/mono)