Skip to content

Remove --buildXUnitWrappers from runtest.cmd/runtest.sh - #31798

Merged
jashook merged 1 commit into
dotnet:masterfrom
EgorBo:cleanup-runtest-py
Feb 25, 2020
Merged

Remove --buildXUnitWrappers from runtest.cmd/runtest.sh#31798
jashook merged 1 commit into
dotnet:masterfrom
EgorBo:cleanup-runtest-py

Conversation

@EgorBo

@EgorBoEgorBo commented Feb 5, 2020

Copy link
Copy Markdown
Member

It looks unused, it forwards --build_xunit_test_wrappers to runtests.py which is not handled there (see https://github.com/dotnet/runtime/blob/master/src/coreclr/tests/runtest.py)

so buildxunitwrappers passed to build.sh/cmd simply fails with unknown parameter --build_xunit_test_wrappers in the python script.

@Dotnet-GitSync-BotDotnet-GitSync-Bot added the area-Infrastructure-coreclr Only use for closed issues label Feb 5, 2020
@jashook
jashook merged commit 489ffcd into dotnet:masterFeb 25, 2020
@EgorBo
EgorBo deleted the cleanup-runtest-py branch May 25, 2020 11:57
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jashookjashookjashook approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EgorBo@jashook@Dotnet-GitSync-Bot