Uh oh!
There was an error while loading. Please reload this page.
[mono] Remove CoreFX.issues_windows.rsp file - #32592
Conversation
6d6236d to
cd11f87CompareMaximLipnin
commented
Mar 13, 2020
5c546fe to
d36caa8Compare@ViktorHofer Could you please help here? I'm trying to enable I don't have it locally, at least for some namespaces which I've tried |
MaximLipnin
commented
Mar 17, 2020
According to @lateralusX, the possible cause is that:
|
lateralusX
commented
Mar 17, 2020
I will do the change to build using static c-runtime for Mono runtime since that was in the plan aligning to CoreCLR redist requirements. Since the failing lane is running debug Mono runtime, I strongly believe issue is related to this, since debug c-runtime is seldom available on host that don't have full toolchain installed. |
lateralusX
commented
Mar 18, 2020
86c24c3 to
934fdecCompare@MaximLipnin sounds like your are unblocked? |
MaximLipnin
commented
Mar 19, 2020
@ViktorHofer Unfortunately, no. According to the latest log, there are over 400 errors, and the crashes mentioned above still occur. Perhaps, @lateralusX will try another fix for that (in addition to what he has already done). |
934fdec to
f30f946ComparelateralusX
commented
Mar 20, 2020
CoreCLR seems to static link vcruntime140.dll even in release builds (not default behaviour when using /MD compiler switch). Looking at the install package that library is not included and since we still need it, I believe that is why we still fail to load, due to missing dependency. Problem is not seen if the c-runtime redist exists and I believe CI don't have that installed. I will try to do same thing as CoreCLR does static link vcruntime140.dll to reduce dependencies not included in package. |
lateralusX
commented
Mar 20, 2020
This should get rid of the vcruntime140.dll runtime dependecy: |
f30f946 to
af4efc2Compareaf4efc2 to
93d2e0eCompare93d2e0e to
c58a82cCompare51d5fd4 to
aeca60eCompare811271d to
946c04aCompare…tsInOneStream and System.Runtime.Serialization.Formatters.Tests.ValidateBasicObjectsRoundtrip with ActiveIssue
… class with ActiveIssue
…meBufferExtensionsTests and System.Runtime.InteropServices.WindowsRuntime.Tests.WindowsRuntimeBufferTests test classes with ActiveIssue
Uh oh!
There was an error while loading. Please reload this page.
Changes:
runtime (Libraries Test Run release mono Windows_NT x64 Debug)CI lane (Windows Nano Server CI leg is disabled);ActiveIssueattribute using respective GH issues;Part of #1980