Add AzDO builds for iOS - #33424

Merged
akoeplinger merged 16 commits into
dotnet:masterfrom
directhex:akoeplinger-add-ios
Mar 17, 2020
Merged

Add AzDO builds for iOS#33424
akoeplinger merged 16 commits into
dotnet:masterfrom
directhex:akoeplinger-add-ios

Conversation

@directhex

@directhexdirecthex commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

This is based on #33292

@directhex

directhex commented Mar 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Dang I meant to make this a draft

@directhex
directhexforce-pushed the akoeplinger-add-ios branch 2 times, most recently from 667a43a to d82bb8fCompareMarch 10, 2020 16:22
@directhex

directhex commented Mar 10, 2020

Copy link
Copy Markdown
ContributorAuthor

@marek-safar on iOS only, or on OSX as well?

@marek-safar

marek-safar commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

ios only

@directhex

directhex commented Mar 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Well, this seems to be doing the expected thing?

@marek-safar

marek-safar commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

You need to hook up libraries build as well

@directhex

directhex commented Mar 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound

@directhex

directhex commented Mar 12, 2020

Copy link
Copy Markdown
ContributorAuthor

OK, I rebuilt the branch against master post-merge. Let's see what happens

@directhex

directhex commented Mar 12, 2020

Copy link
Copy Markdown
ContributorAuthor

Yeah that's looking OK. Ready for review I reckon.

@steveisok
steveisok requested a review from a teamMarch 12, 2020 14:04
@akoeplinger

akoeplinger commented Mar 12, 2020

Copy link
Copy Markdown
Member

@directhex can you try doing an official build to make sure it works there too?

@directhex

directhex commented Mar 12, 2020

Copy link
Copy Markdown
ContributorAuthor

@akoeplinger not until darc starts working again!

safern
safern reviewed Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/common/xplat-setup.yml Outdated
safern
safern reviewed Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml Outdated
@directhex

directhex commented Mar 13, 2020

Copy link
Copy Markdown
ContributorAuthor

@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261

Suggestions?

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called.

/Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols

safern
safern reviewed Mar 16, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml Outdated
@directhex

directhex commented Mar 16, 2020

Copy link
Copy Markdown
ContributorAuthor

@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be)

In eng/pipelines/libraries/base-job.yml, the variable _stripSymbolsArg is conditionally defined as -stripSymbols on non-Windows. It is then passed as a parameter to ./libraries.sh, i.e. I get a run of ./libraries.sh -build -configuration Release -ci -arch x64 -stripSymbols -os iOS /p:OfficialBuildId=20200316.5 /p:RuntimeArtifactsPath=/Users/runner/runners/2.165.0/work/1/s/artifacts/transport/coreclr - however, all variables in AzDO are exported as environment... so in src/libraries/Native/build-native.proj, _stripSymbolsArg is redefined as -stripsymbols (note the leading space) only when BuildNativeStripSymbols is true, and TargetOS is NOT wasm (or iOS in the specific case of this PR).

As a result, during command line construction in build-native.proj, $(_BuildNativeArgs)$(_ProcessCountArg)$(_StripSymbolsArg) has a leading space on _StripSymbolsArg only when TargetOS is NOT iOS/wasm, or when reproducing locally (when you aren't going to be exporting the no-space value from the YAML)

Is the expectation that -stripSymbols should be EMPTY on iOS, or not? (if not, why is it in the conditional in build-native.proj)

@safern

safern commented Mar 16, 2020

Copy link
Copy Markdown
Member

Arrgg I hate when that happens 😠

So I would leave -stripSymbols definition in the yml with the current conditions as is and without any quotes or spaces. What I would recommend doing is just rename the yml variable to be, _stripSymbolsArgYaml and add a comment on why the name and to not rename.

Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS.

@directhex

directhex commented Mar 16, 2020

Copy link
Copy Markdown
ContributorAuthor

I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS?

@directhex

directhex commented Mar 16, 2020

Copy link
Copy Markdown
ContributorAuthor

OK, 'Mismatched MVIDs in ibc data' means nothing to me

https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288

@akoeplinger

akoeplinger commented Mar 17, 2020

Copy link
Copy Markdown
Member

should symbol stripping happen or not on iOS?

I didn't really know which is why I just copied webassembly for now 😄

@directhex

directhex commented Mar 17, 2020

Copy link
Copy Markdown
ContributorAuthor

I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario

@steveisoksteveisok mentioned this pull request Mar 17, 2020
Closed
@akoeplinger

akoeplinger commented Mar 17, 2020

Copy link
Copy Markdown
Member

Failures are unrelated, merging.

@akoeplinger
akoeplinger merged commit 65a1d2c into dotnet:masterMar 17, 2020
jashook pushed a commit that referenced this pull request Mar 19, 2020
Jarret Shook
Revert "Add AzDO builds for iOS (#33424)"
5442e09
This reverts commit 65a1d2c.
@jashookjashook mentioned this pull request Mar 19, 2020
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@safernsafernsafern approved these changes
@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@EgorBoEgorBoAwaiting requested review from EgorBo
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewurmlewurmAwaiting requested review from lewurm
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees

No one assigned

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@directhex@marek-safar@akoeplinger@safern@steveisok@Dotnet-GitSync-Bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add AzDO builds for iOS - #33424
Merged
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Mar 17, 2020
Merged
Add AzDO builds for iOS#33424
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Conversation
@directhex
@directhexdirecthex
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
This is based on #33292
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Dang I meant to make this a draft
@directhex
directhexforce-pushed
the
akoeplinger-add-ios
branch
2 times, most recently
from
667a43a to
d82bb8fCompareMarch 10, 2020 16:22
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar on iOS only, or on OSX as well?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
ios only
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Well, this seems to be doing the expected thing?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
You need to hook up libraries build as well
@directhex
directhex
commented
Mar 11, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, I rebuilt the branch against master post-merge. Let's see what happens
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
Yeah that's looking OK. Ready for review I reckon.
@steveisok
steveisok
requested a review
from a teamMarch 12, 2020 14:04
@akoeplinger
akoeplinger
commented
Mar 12, 2020

Copy link


Copy Markdown

Member
@directhex can you try doing an official build to make sure it works there too?
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
@akoeplinger not until darc starts working again!
safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/common/xplat-setup.yml
Outdated

safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261
Suggestions?
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called.
/Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols
safern
safern
reviewed
Mar 16, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be)
In eng/pipelines/libraries/base-job.yml, the variable _stripSymbolsArg is conditionally defined as -stripSymbols on non-Windows. It is then passed as a parameter to ./libraries.sh, i.e. I get a run of ./libraries.sh -build -configuration Release -ci -arch x64 -stripSymbols -os iOS /p:OfficialBuildId=20200316.5 /p:RuntimeArtifactsPath=/Users/runner/runners/2.165.0/work/1/s/artifacts/transport/coreclr - however, all variables in AzDO are exported as environment... so in src/libraries/Native/build-native.proj, _stripSymbolsArg is redefined as  -stripsymbols (note the leading space) only when BuildNativeStripSymbols is true, and TargetOS is NOT wasm (or iOS in the specific case of this PR).
As a result, during command line construction in build-native.proj, $(_BuildNativeArgs)$(_ProcessCountArg)$(_StripSymbolsArg) has a leading space on _StripSymbolsArg only when TargetOS is NOT iOS/wasm, or when reproducing locally (when you aren't going to be exporting the no-space value from the YAML)
Is the expectation that -stripSymbols should be EMPTY on iOS, or not? (if not, why is it in the conditional in build-native.proj)
@safern
safern
commented
Mar 16, 2020

Copy link


Copy Markdown

Member
Arrgg I hate when that happens 😠
So I would leave -stripSymbols definition in the yml with the current conditions as is and without any quotes or spaces. What I would recommend doing is just rename the yml variable to be, _stripSymbolsArgYaml and add a comment on why the name and to not rename.
Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS.
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS?
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, 'Mismatched MVIDs in ibc data' means nothing to me
https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288
@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
should symbol stripping happen or not on iOS?
I didn't really know which is why I just copied webassembly for now 😄
@directhex
directhex
commented
Mar 17, 2020

Copy link


Copy Markdown

ContributorAuthor
I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario
@steveisoksteveisok
mentioned this pull request
Mar 17, 2020

Closed

@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Failures are unrelated, merging.
@akoeplinger
akoeplinger
merged commit 65a1d2c
into
dotnet:masterMar 17, 2020
jashook pushed a commit
that referenced
this pull request
Mar 19, 2020
Jarret Shook
Revert "Add AzDO builds for iOS (#33424)"
5442e09
This reverts commit 65a1d2c.
@jashookjashook
mentioned this pull request
Mar 19, 2020
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@safernsafernsafern approved these changes
@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@EgorBoEgorBoAwaiting requested review from EgorBo
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewurmlewurmAwaiting requested review from lewurm
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@directhex@marek-safar@akoeplinger@safern@steveisok@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add AzDO builds for iOS - #33424
Merged
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Mar 17, 2020
Merged
Add AzDO builds for iOS#33424
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Conversation
@directhex
@directhexdirecthex
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
This is based on #33292
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Dang I meant to make this a draft
@directhex
directhexforce-pushed
the
akoeplinger-add-ios
branch
2 times, most recently
from
667a43a to
d82bb8fCompareMarch 10, 2020 16:22
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar on iOS only, or on OSX as well?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
ios only
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Well, this seems to be doing the expected thing?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
You need to hook up libraries build as well
@directhex
directhex
commented
Mar 11, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, I rebuilt the branch against master post-merge. Let's see what happens
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
Yeah that's looking OK. Ready for review I reckon.
@steveisok
steveisok
requested a review
from a teamMarch 12, 2020 14:04
@akoeplinger
akoeplinger
commented
Mar 12, 2020

Copy link


Copy Markdown

Member
@directhex can you try doing an official build to make sure it works there too?
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
@akoeplinger not until darc starts working again!
safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/common/xplat-setup.yml
Outdated

safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261
Suggestions?
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called.
/Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols
safern
safern
reviewed
Mar 16, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be)
In eng/pipelines/libraries/base-job.yml, the variable _stripSymbolsArg is conditionally defined as -stripSymbols on non-Windows. It is then passed as a parameter to ./libraries.sh, i.e. I get a run of ./libraries.sh -build -configuration Release -ci -arch x64 -stripSymbols -os iOS /p:OfficialBuildId=20200316.5 /p:RuntimeArtifactsPath=/Users/runner/runners/2.165.0/work/1/s/artifacts/transport/coreclr - however, all variables in AzDO are exported as environment... so in src/libraries/Native/build-native.proj, _stripSymbolsArg is redefined as  -stripsymbols (note the leading space) only when BuildNativeStripSymbols is true, and TargetOS is NOT wasm (or iOS in the specific case of this PR).
As a result, during command line construction in build-native.proj, $(_BuildNativeArgs)$(_ProcessCountArg)$(_StripSymbolsArg) has a leading space on _StripSymbolsArg only when TargetOS is NOT iOS/wasm, or when reproducing locally (when you aren't going to be exporting the no-space value from the YAML)
Is the expectation that -stripSymbols should be EMPTY on iOS, or not? (if not, why is it in the conditional in build-native.proj)
@safern
safern
commented
Mar 16, 2020

Copy link


Copy Markdown

Member
Arrgg I hate when that happens 😠
So I would leave -stripSymbols definition in the yml with the current conditions as is and without any quotes or spaces. What I would recommend doing is just rename the yml variable to be, _stripSymbolsArgYaml and add a comment on why the name and to not rename.
Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS.
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS?
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, 'Mismatched MVIDs in ibc data' means nothing to me
https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288
@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
should symbol stripping happen or not on iOS?
I didn't really know which is why I just copied webassembly for now 😄
@directhex
directhex
commented
Mar 17, 2020

Copy link


Copy Markdown

ContributorAuthor
I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario
@steveisoksteveisok
mentioned this pull request
Mar 17, 2020

Closed

@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Failures are unrelated, merging.
@akoeplinger
akoeplinger
merged commit 65a1d2c
into
dotnet:masterMar 17, 2020
jashook pushed a commit
that referenced
this pull request
Mar 19, 2020
Jarret Shook
Revert "Add AzDO builds for iOS (#33424)"
5442e09
This reverts commit 65a1d2c.
@jashookjashook
mentioned this pull request
Mar 19, 2020
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@safernsafernsafern approved these changes
@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@EgorBoEgorBoAwaiting requested review from EgorBo
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewurmlewurmAwaiting requested review from lewurm
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@directhex@marek-safar@akoeplinger@safern@steveisok@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add AzDO builds for iOS - #33424
Merged
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Mar 17, 2020
Merged
Add AzDO builds for iOS#33424
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Conversation
@directhex
@directhexdirecthex
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
This is based on #33292
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Dang I meant to make this a draft
@directhex
directhexforce-pushed
the
akoeplinger-add-ios
branch
2 times, most recently
from
667a43a to
d82bb8fCompareMarch 10, 2020 16:22
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar on iOS only, or on OSX as well?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
ios only
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Well, this seems to be doing the expected thing?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
You need to hook up libraries build as well
@directhex
directhex
commented
Mar 11, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, I rebuilt the branch against master post-merge. Let's see what happens
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
Yeah that's looking OK. Ready for review I reckon.
@steveisok
steveisok
requested a review
from a teamMarch 12, 2020 14:04
@akoeplinger
akoeplinger
commented
Mar 12, 2020

Copy link


Copy Markdown

Member
@directhex can you try doing an official build to make sure it works there too?
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
@akoeplinger not until darc starts working again!
safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/common/xplat-setup.yml
Outdated

safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261
Suggestions?
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called.
/Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols
safern
safern
reviewed
Mar 16, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be)
In eng/pipelines/libraries/base-job.yml, the variable _stripSymbolsArg is conditionally defined as -stripSymbols on non-Windows. It is then passed as a parameter to ./libraries.sh, i.e. I get a run of ./libraries.sh -build -configuration Release -ci -arch x64 -stripSymbols -os iOS /p:OfficialBuildId=20200316.5 /p:RuntimeArtifactsPath=/Users/runner/runners/2.165.0/work/1/s/artifacts/transport/coreclr - however, all variables in AzDO are exported as environment... so in src/libraries/Native/build-native.proj, _stripSymbolsArg is redefined as  -stripsymbols (note the leading space) only when BuildNativeStripSymbols is true, and TargetOS is NOT wasm (or iOS in the specific case of this PR).
As a result, during command line construction in build-native.proj, $(_BuildNativeArgs)$(_ProcessCountArg)$(_StripSymbolsArg) has a leading space on _StripSymbolsArg only when TargetOS is NOT iOS/wasm, or when reproducing locally (when you aren't going to be exporting the no-space value from the YAML)
Is the expectation that -stripSymbols should be EMPTY on iOS, or not? (if not, why is it in the conditional in build-native.proj)
@safern
safern
commented
Mar 16, 2020

Copy link


Copy Markdown

Member
Arrgg I hate when that happens 😠
So I would leave -stripSymbols definition in the yml with the current conditions as is and without any quotes or spaces. What I would recommend doing is just rename the yml variable to be, _stripSymbolsArgYaml and add a comment on why the name and to not rename.
Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS.
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS?
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, 'Mismatched MVIDs in ibc data' means nothing to me
https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288
@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
should symbol stripping happen or not on iOS?
I didn't really know which is why I just copied webassembly for now 😄
@directhex
directhex
commented
Mar 17, 2020

Copy link


Copy Markdown

ContributorAuthor
I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario
@steveisoksteveisok
mentioned this pull request
Mar 17, 2020

Closed

@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Failures are unrelated, merging.
@akoeplinger
akoeplinger
merged commit 65a1d2c
into
dotnet:masterMar 17, 2020
jashook pushed a commit
that referenced
this pull request
Mar 19, 2020
Jarret Shook
Revert "Add AzDO builds for iOS (#33424)"
5442e09
This reverts commit 65a1d2c.
@jashookjashook
mentioned this pull request
Mar 19, 2020
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@safernsafernsafern approved these changes
@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@EgorBoEgorBoAwaiting requested review from EgorBo
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewurmlewurmAwaiting requested review from lewurm
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@directhex@marek-safar@akoeplinger@safern@steveisok@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add AzDO builds for iOS - #33424
Merged
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Mar 17, 2020
Merged
Add AzDO builds for iOS#33424
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Conversation
@directhex
@directhexdirecthex
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
This is based on #33292
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Dang I meant to make this a draft
@directhex
directhexforce-pushed
the
akoeplinger-add-ios
branch
2 times, most recently
from
667a43a to
d82bb8fCompareMarch 10, 2020 16:22
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar on iOS only, or on OSX as well?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
ios only
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Well, this seems to be doing the expected thing?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
You need to hook up libraries build as well
@directhex
directhex
commented
Mar 11, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, I rebuilt the branch against master post-merge. Let's see what happens
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
Yeah that's looking OK. Ready for review I reckon.
@steveisok
steveisok
requested a review
from a teamMarch 12, 2020 14:04
@akoeplinger
akoeplinger
commented
Mar 12, 2020

Copy link


Copy Markdown

Member
@directhex can you try doing an official build to make sure it works there too?
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
@akoeplinger not until darc starts working again!
safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/common/xplat-setup.yml
Outdated

safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261
Suggestions?
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called.
/Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols
safern
safern
reviewed
Mar 16, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be)
In eng/pipelines/libraries/base-job.yml, the variable _stripSymbolsArg is conditionally defined as -stripSymbols on non-Windows. It is then passed as a parameter to ./libraries.sh, i.e. I get a run of ./libraries.sh -build -configuration Release -ci -arch x64 -stripSymbols -os iOS /p:OfficialBuildId=20200316.5 /p:RuntimeArtifactsPath=/Users/runner/runners/2.165.0/work/1/s/artifacts/transport/coreclr - however, all variables in AzDO are exported as environment... so in src/libraries/Native/build-native.proj, _stripSymbolsArg is redefined as  -stripsymbols (note the leading space) only when BuildNativeStripSymbols is true, and TargetOS is NOT wasm (or iOS in the specific case of this PR).
As a result, during command line construction in build-native.proj, $(_BuildNativeArgs)$(_ProcessCountArg)$(_StripSymbolsArg) has a leading space on _StripSymbolsArg only when TargetOS is NOT iOS/wasm, or when reproducing locally (when you aren't going to be exporting the no-space value from the YAML)
Is the expectation that -stripSymbols should be EMPTY on iOS, or not? (if not, why is it in the conditional in build-native.proj)
@safern
safern
commented
Mar 16, 2020

Copy link


Copy Markdown

Member
Arrgg I hate when that happens 😠
So I would leave -stripSymbols definition in the yml with the current conditions as is and without any quotes or spaces. What I would recommend doing is just rename the yml variable to be, _stripSymbolsArgYaml and add a comment on why the name and to not rename.
Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS.
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS?
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, 'Mismatched MVIDs in ibc data' means nothing to me
https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288
@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
should symbol stripping happen or not on iOS?
I didn't really know which is why I just copied webassembly for now 😄
@directhex
directhex
commented
Mar 17, 2020

Copy link


Copy Markdown

ContributorAuthor
I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario
@steveisoksteveisok
mentioned this pull request
Mar 17, 2020

Closed

@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Failures are unrelated, merging.
@akoeplinger
akoeplinger
merged commit 65a1d2c
into
dotnet:masterMar 17, 2020
jashook pushed a commit
that referenced
this pull request
Mar 19, 2020
Jarret Shook
Revert "Add AzDO builds for iOS (#33424)"
5442e09
This reverts commit 65a1d2c.
@jashookjashook
mentioned this pull request
Mar 19, 2020
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@safernsafernsafern approved these changes
@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@EgorBoEgorBoAwaiting requested review from EgorBo
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewurmlewurmAwaiting requested review from lewurm
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@directhex@marek-safar@akoeplinger@safern@steveisok@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add AzDO builds for iOS - #33424
Merged
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Mar 17, 2020
Merged
Add AzDO builds for iOS#33424
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Conversation
@directhex
@directhexdirecthex
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
This is based on #33292
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Dang I meant to make this a draft
@directhex
directhexforce-pushed
the
akoeplinger-add-ios
branch
2 times, most recently
from
667a43a to
d82bb8fCompareMarch 10, 2020 16:22
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar on iOS only, or on OSX as well?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
ios only
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Well, this seems to be doing the expected thing?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
You need to hook up libraries build as well
@directhex
directhex
commented
Mar 11, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, I rebuilt the branch against master post-merge. Let's see what happens
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
Yeah that's looking OK. Ready for review I reckon.
@steveisok
steveisok
requested a review
from a teamMarch 12, 2020 14:04
@akoeplinger
akoeplinger
commented
Mar 12, 2020

Copy link


Copy Markdown

Member
@directhex can you try doing an official build to make sure it works there too?
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
@akoeplinger not until darc starts working again!
safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/common/xplat-setup.yml
Outdated

safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261
Suggestions?
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called.
/Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols
safern
safern
reviewed
Mar 16, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be)
In eng/pipelines/libraries/base-job.yml, the variable _stripSymbolsArg is conditionally defined as -stripSymbols on non-Windows. It is then passed as a parameter to ./libraries.sh, i.e. I get a run of ./libraries.sh -build -configuration Release -ci -arch x64 -stripSymbols -os iOS /p:OfficialBuildId=20200316.5 /p:RuntimeArtifactsPath=/Users/runner/runners/2.165.0/work/1/s/artifacts/transport/coreclr - however, all variables in AzDO are exported as environment... so in src/libraries/Native/build-native.proj, _stripSymbolsArg is redefined as  -stripsymbols (note the leading space) only when BuildNativeStripSymbols is true, and TargetOS is NOT wasm (or iOS in the specific case of this PR).
As a result, during command line construction in build-native.proj, $(_BuildNativeArgs)$(_ProcessCountArg)$(_StripSymbolsArg) has a leading space on _StripSymbolsArg only when TargetOS is NOT iOS/wasm, or when reproducing locally (when you aren't going to be exporting the no-space value from the YAML)
Is the expectation that -stripSymbols should be EMPTY on iOS, or not? (if not, why is it in the conditional in build-native.proj)
@safern
safern
commented
Mar 16, 2020

Copy link


Copy Markdown

Member
Arrgg I hate when that happens 😠
So I would leave -stripSymbols definition in the yml with the current conditions as is and without any quotes or spaces. What I would recommend doing is just rename the yml variable to be, _stripSymbolsArgYaml and add a comment on why the name and to not rename.
Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS.
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS?
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, 'Mismatched MVIDs in ibc data' means nothing to me
https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288
@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
should symbol stripping happen or not on iOS?
I didn't really know which is why I just copied webassembly for now 😄
@directhex
directhex
commented
Mar 17, 2020

Copy link


Copy Markdown

ContributorAuthor
I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario
@steveisoksteveisok
mentioned this pull request
Mar 17, 2020

Closed

@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Failures are unrelated, merging.
@akoeplinger
akoeplinger
merged commit 65a1d2c
into
dotnet:masterMar 17, 2020
jashook pushed a commit
that referenced
this pull request
Mar 19, 2020
Jarret Shook
Revert "Add AzDO builds for iOS (#33424)"
5442e09
This reverts commit 65a1d2c.
@jashookjashook
mentioned this pull request
Mar 19, 2020
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@safernsafernsafern approved these changes
@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@EgorBoEgorBoAwaiting requested review from EgorBo
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewurmlewurmAwaiting requested review from lewurm
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@directhex@marek-safar@akoeplinger@safern@steveisok@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add AzDO builds for iOS - #33424
Merged
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Mar 17, 2020
Merged
Add AzDO builds for iOS#33424
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Conversation
@directhex
@directhexdirecthex
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
This is based on #33292
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Dang I meant to make this a draft
@directhex
directhexforce-pushed
the
akoeplinger-add-ios
branch
2 times, most recently
from
667a43a to
d82bb8fCompareMarch 10, 2020 16:22
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar on iOS only, or on OSX as well?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
ios only
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Well, this seems to be doing the expected thing?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
You need to hook up libraries build as well
@directhex
directhex
commented
Mar 11, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, I rebuilt the branch against master post-merge. Let's see what happens
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
Yeah that's looking OK. Ready for review I reckon.
@steveisok
steveisok
requested a review
from a teamMarch 12, 2020 14:04
@akoeplinger
akoeplinger
commented
Mar 12, 2020

Copy link


Copy Markdown

Member
@directhex can you try doing an official build to make sure it works there too?
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
@akoeplinger not until darc starts working again!
safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/common/xplat-setup.yml
Outdated

safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261
Suggestions?
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called.
/Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols
safern
safern
reviewed
Mar 16, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be)
In eng/pipelines/libraries/base-job.yml, the variable _stripSymbolsArg is conditionally defined as -stripSymbols on non-Windows. It is then passed as a parameter to ./libraries.sh, i.e. I get a run of ./libraries.sh -build -configuration Release -ci -arch x64 -stripSymbols -os iOS /p:OfficialBuildId=20200316.5 /p:RuntimeArtifactsPath=/Users/runner/runners/2.165.0/work/1/s/artifacts/transport/coreclr - however, all variables in AzDO are exported as environment... so in src/libraries/Native/build-native.proj, _stripSymbolsArg is redefined as  -stripsymbols (note the leading space) only when BuildNativeStripSymbols is true, and TargetOS is NOT wasm (or iOS in the specific case of this PR).
As a result, during command line construction in build-native.proj, $(_BuildNativeArgs)$(_ProcessCountArg)$(_StripSymbolsArg) has a leading space on _StripSymbolsArg only when TargetOS is NOT iOS/wasm, or when reproducing locally (when you aren't going to be exporting the no-space value from the YAML)
Is the expectation that -stripSymbols should be EMPTY on iOS, or not? (if not, why is it in the conditional in build-native.proj)
@safern
safern
commented
Mar 16, 2020

Copy link


Copy Markdown

Member
Arrgg I hate when that happens 😠
So I would leave -stripSymbols definition in the yml with the current conditions as is and without any quotes or spaces. What I would recommend doing is just rename the yml variable to be, _stripSymbolsArgYaml and add a comment on why the name and to not rename.
Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS.
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS?
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, 'Mismatched MVIDs in ibc data' means nothing to me
https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288
@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
should symbol stripping happen or not on iOS?
I didn't really know which is why I just copied webassembly for now 😄
@directhex
directhex
commented
Mar 17, 2020

Copy link


Copy Markdown

ContributorAuthor
I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario
@steveisoksteveisok
mentioned this pull request
Mar 17, 2020

Closed

@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Failures are unrelated, merging.
@akoeplinger
akoeplinger
merged commit 65a1d2c
into
dotnet:masterMar 17, 2020
jashook pushed a commit
that referenced
this pull request
Mar 19, 2020
Jarret Shook
Revert "Add AzDO builds for iOS (#33424)"
5442e09
This reverts commit 65a1d2c.
@jashookjashook
mentioned this pull request
Mar 19, 2020
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@safernsafernsafern approved these changes
@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@EgorBoEgorBoAwaiting requested review from EgorBo
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewurmlewurmAwaiting requested review from lewurm
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@directhex@marek-safar@akoeplinger@safern@steveisok@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add AzDO builds for iOS - #33424
Merged
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Mar 17, 2020
Merged
Add AzDO builds for iOS#33424
akoeplinger merged 16 commits into
dotnet:masterfrom 
directhex:akoeplinger-add-ios
Conversation
@directhex
@directhexdirecthex
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
This is based on #33292
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Dang I meant to make this a draft
@directhex
directhexforce-pushed
the
akoeplinger-add-ios
branch
2 times, most recently
from
667a43a to
d82bb8fCompareMarch 10, 2020 16:22
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar on iOS only, or on OSX as well?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
ios only
@directhex
directhex
commented
Mar 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Well, this seems to be doing the expected thing?
@marek-safar
marek-safar
commented
Mar 10, 2020

Copy link


Copy Markdown

Contributor
You need to hook up libraries build as well
@directhex
directhex
commented
Mar 11, 2020

Copy link


Copy Markdown

ContributorAuthor
@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, I rebuilt the branch against master post-merge. Let's see what happens
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
Yeah that's looking OK. Ready for review I reckon.
@steveisok
steveisok
requested a review
from a teamMarch 12, 2020 14:04
@akoeplinger
akoeplinger
commented
Mar 12, 2020

Copy link


Copy Markdown

Member
@directhex can you try doing an official build to make sure it works there too?
@directhex
directhex
commented
Mar 12, 2020

Copy link


Copy Markdown

ContributorAuthor
@akoeplinger not until darc starts working again!
safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/common/xplat-setup.yml
Outdated

safern
safern
reviewed
Mar 12, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261
Suggestions?
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called.
/Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols
safern
safern
reviewed
Mar 16, 2020
View reviewed changes
Comment threadeng/pipelines/libraries/base-job.yml
Outdated

@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be)
In eng/pipelines/libraries/base-job.yml, the variable _stripSymbolsArg is conditionally defined as -stripSymbols on non-Windows. It is then passed as a parameter to ./libraries.sh, i.e. I get a run of ./libraries.sh -build -configuration Release -ci -arch x64 -stripSymbols -os iOS /p:OfficialBuildId=20200316.5 /p:RuntimeArtifactsPath=/Users/runner/runners/2.165.0/work/1/s/artifacts/transport/coreclr - however, all variables in AzDO are exported as environment... so in src/libraries/Native/build-native.proj, _stripSymbolsArg is redefined as  -stripsymbols (note the leading space) only when BuildNativeStripSymbols is true, and TargetOS is NOT wasm (or iOS in the specific case of this PR).
As a result, during command line construction in build-native.proj, $(_BuildNativeArgs)$(_ProcessCountArg)$(_StripSymbolsArg) has a leading space on _StripSymbolsArg only when TargetOS is NOT iOS/wasm, or when reproducing locally (when you aren't going to be exporting the no-space value from the YAML)
Is the expectation that -stripSymbols should be EMPTY on iOS, or not? (if not, why is it in the conditional in build-native.proj)
@safern
safern
commented
Mar 16, 2020

Copy link


Copy Markdown

Member
Arrgg I hate when that happens 😠
So I would leave -stripSymbols definition in the yml with the current conditions as is and without any quotes or spaces. What I would recommend doing is just rename the yml variable to be, _stripSymbolsArgYaml and add a comment on why the name and to not rename.
Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS.
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS?
@directhex
directhex
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
OK, 'Mismatched MVIDs in ibc data' means nothing to me
https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288
@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
should symbol stripping happen or not on iOS?
I didn't really know which is why I just copied webassembly for now 😄
@directhex
directhex
commented
Mar 17, 2020

Copy link


Copy Markdown

ContributorAuthor
I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario
@steveisoksteveisok
mentioned this pull request
Mar 17, 2020

Closed

@akoeplinger
akoeplinger
commented
Mar 17, 2020

Copy link


Copy Markdown

Member
Failures are unrelated, merging.
@akoeplinger
akoeplinger
merged commit 65a1d2c
into
dotnet:masterMar 17, 2020
jashook pushed a commit
that referenced
this pull request
Mar 19, 2020
Jarret Shook
Revert "Add AzDO builds for iOS (#33424)"
5442e09
This reverts commit 65a1d2c.
@jashookjashook
mentioned this pull request
Mar 19, 2020
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@safernsafernsafern approved these changes
@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@EgorBoEgorBoAwaiting requested review from EgorBo
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewurmlewurmAwaiting requested review from lewurm
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees


No one assigned


Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@directhex@marek-safar@akoeplinger@safern@steveisok@Dotnet-GitSync-Bot