[master] Update dependencies from dotnet/arcade dotnet/runtime-assets - #33562

Merged
safern merged 3 commits into
masterfrom
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Mar 14, 2020
Merged

[master] Update dependencies from dotnet/arcade dotnet/runtime-assets#33562
safern merged 3 commits into
masterfrom
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3

From https://github.com/dotnet/runtime-assets

  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:
    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20200…
8d4b127
…312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe

wtgodbe commented Mar 13, 2020

Copy link
Copy Markdown
Member

With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❓ Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
565e061
…ld 20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestrodotnet-maestroBot changed the title [master] Update dependencies from dotnet/arcade[master] Update dependencies from dotnet/arcade dotnet/runtime-assetsMar 13, 2020
This was referenced Mar 13, 2020
Closed
Merged
@wtgodbe

wtgodbe commented Mar 13, 2020

Copy link
Copy Markdown
Member

Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@GrabYourPitchforks

GrabYourPitchforks commented Mar 13, 2020

Copy link
Copy Markdown
Member

CI is failing:

.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe

wtgodbe commented Mar 13, 2020

Copy link
Copy Markdown
Member

There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98

@gugavaro could this impact what checks are triggered? CC @ericstj

@wtgodbe

wtgodbe commented Mar 13, 2020

Copy link
Copy Markdown
Member

Also CC @safern@Anipik@ViktorHofer

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?

@ericstj

ericstj commented Mar 13, 2020

Copy link
Copy Markdown
Member

I believe we already merged them. Just need to rerun against tip.

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

Yeah I saw that now: 4480bdb

I'll re-run.

@safernsafern closed this Mar 13, 2020
@safernsafern reopened this Mar 13, 2020
ericstj
ericstj reviewed Mar 13, 2020
View reviewed changes
Comment threadeng/Versions.props Outdated
<MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
<MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
<MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
<MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>

@ericstjericstjMar 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖

@safernsafernMar 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.

@wtgodbewtgodbeMar 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4

@safernsafernMar 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml

4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

Fixed.

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

@jaredpar@jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@jkotas

jkotas commented Mar 13, 2020

Copy link
Copy Markdown
Member

I have not see it. Do you see the same failures in the rolling builds on master?

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918

Looking at the commits.

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1

@AndyAyersMSAndyAyersMS mentioned this pull request Mar 13, 2020
Merged
@jkotas

jkotas commented Mar 13, 2020

Copy link
Copy Markdown
Member

Or the GCC change. Is it possible that we are running the tests against GCC built binaries?

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@jkotas

jkotas commented Mar 13, 2020

Copy link
Copy Markdown
Member

The GCC leg should be build-only. No tests.

@AndyAyersMS

AndyAyersMS commented Mar 13, 2020

Copy link
Copy Markdown
Member

I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.

@jkotas

jkotas commented Mar 13, 2020

Copy link
Copy Markdown
Member

I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.

This makes the GCC change more likely culprit.

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280

The GCC leg should be build-only. No tests.

I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.

@safern

safern commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz

I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@AndyAyersMS

AndyAyersMS commented Mar 13, 2020

Copy link
Copy Markdown
Member

In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?

Clang build

2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build

2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern

safern commented Mar 13, 2020

Copy link
Copy Markdown
Member

Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.

I put up a PR to fix it: #33580

@dotnet-maestro

dotnet-maestroBot commented Mar 13, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@echesakovechesakov mentioned this pull request Mar 14, 2020
Merged
@GrabYourPitchforksGrabYourPitchforks mentioned this pull request Mar 14, 2020
Merged
@safern

safern commented Mar 14, 2020

Copy link
Copy Markdown
Member

Failures are known and fixed: #33580

@safern
safern merged commit b22719b into masterMar 14, 2020
@safern
safern deleted the darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9 branch March 14, 2020 03:46
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@danmoseleydanmoseley added area-codeflow for labeling automated codeflow and removed area-Infrastructure labels Jul 28, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstjericstjericstj left review comments
@wtgodbewtgodbewtgodbe left review comments
@safernsafernsafern left review comments

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wtgodbe@GrabYourPitchforks@safern@ericstj@jkotas@AndyAyersMS@danmoseley@Dotnet-GitSync-Bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets - #33562
Merged
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Mar 14, 2020
Merged
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets#33562
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:

    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3
From https://github.com/dotnet/runtime-assets
  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:

    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20200…
8d4b127
…312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❓ Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
565e061
…ld 20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestrodotnet-maestroBot
changed the title
[master] Update dependencies from dotnet/arcade[master] Update dependencies from dotnet/arcade dotnet/runtime-assetsMar 13, 2020

This was referenced Mar 13, 2020
 Closed

 Merged

@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@GrabYourPitchforks
GrabYourPitchforks
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
CI is failing:
.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98
@gugavaro could this impact what checks are triggered? CC @ericstj
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Also CC @safern@Anipik@ViktorHofer
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?
@ericstj
ericstj
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I believe we already merged them. Just need to rerun against tip.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I saw that now: 4480bdb
I'll re-run.
@safernsafern
closed this
Mar 13, 2020
@safernsafern
reopened this
Mar 13, 2020
ericstj
ericstj
reviewed
Mar 13, 2020
View reviewed changes
Comment threadeng/Versions.props
Outdated

 <MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
 <MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
 <MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
 <MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>
@ericstjericstjMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.
@wtgodbewtgodbeMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml
4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Fixed.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
@jaredpar@jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I have not see it. Do you see the same failures in the rolling builds on master?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918
Looking at the commits.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1
@AndyAyersMSAndyAyersMS
mentioned this pull request
Mar 13, 2020
 Merged

@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Or the GCC change. Is it possible that we are running the tests against GCC built binaries?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
The GCC leg should be build-only. No tests.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
This makes the GCC change more likely culprit.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280
The GCC leg should be build-only. No tests.
I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.
@safern
safern
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz
I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?
Clang build
2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build
2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.
I put up a PR to fix it: #33580
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@echesakovechesakov
mentioned this pull request
Mar 14, 2020
 Merged

@GrabYourPitchforksGrabYourPitchforks
mentioned this pull request
Mar 14, 2020
 Merged

@safern
safern
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
Failures are known and fixed: #33580
@safern
safern
merged commit b22719b
into
masterMar 14, 2020
@safern
safern
deleted the

darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9

branch
March 14, 2020 03:46
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
@danmoseleydanmoseley
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure

labels
Jul 28, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@wtgodbewtgodbewtgodbe left review comments
@safernsafernsafern left review comments

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@wtgodbe@GrabYourPitchforks@safern@ericstj@jkotas@AndyAyersMS@danmoseley@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets - #33562
Merged
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Mar 14, 2020
Merged
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets#33562
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:

    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3
From https://github.com/dotnet/runtime-assets
  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:

    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20200…
8d4b127
…312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❓ Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
565e061
…ld 20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestrodotnet-maestroBot
changed the title
[master] Update dependencies from dotnet/arcade[master] Update dependencies from dotnet/arcade dotnet/runtime-assetsMar 13, 2020

This was referenced Mar 13, 2020
 Closed

 Merged

@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@GrabYourPitchforks
GrabYourPitchforks
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
CI is failing:
.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98
@gugavaro could this impact what checks are triggered? CC @ericstj
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Also CC @safern@Anipik@ViktorHofer
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?
@ericstj
ericstj
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I believe we already merged them. Just need to rerun against tip.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I saw that now: 4480bdb
I'll re-run.
@safernsafern
closed this
Mar 13, 2020
@safernsafern
reopened this
Mar 13, 2020
ericstj
ericstj
reviewed
Mar 13, 2020
View reviewed changes
Comment threadeng/Versions.props
Outdated

 <MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
 <MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
 <MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
 <MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>
@ericstjericstjMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.
@wtgodbewtgodbeMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml
4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Fixed.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
@jaredpar@jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I have not see it. Do you see the same failures in the rolling builds on master?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918
Looking at the commits.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1
@AndyAyersMSAndyAyersMS
mentioned this pull request
Mar 13, 2020
 Merged

@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Or the GCC change. Is it possible that we are running the tests against GCC built binaries?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
The GCC leg should be build-only. No tests.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
This makes the GCC change more likely culprit.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280
The GCC leg should be build-only. No tests.
I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.
@safern
safern
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz
I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?
Clang build
2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build
2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.
I put up a PR to fix it: #33580
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@echesakovechesakov
mentioned this pull request
Mar 14, 2020
 Merged

@GrabYourPitchforksGrabYourPitchforks
mentioned this pull request
Mar 14, 2020
 Merged

@safern
safern
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
Failures are known and fixed: #33580
@safern
safern
merged commit b22719b
into
masterMar 14, 2020
@safern
safern
deleted the

darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9

branch
March 14, 2020 03:46
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
@danmoseleydanmoseley
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure

labels
Jul 28, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@wtgodbewtgodbewtgodbe left review comments
@safernsafernsafern left review comments

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@wtgodbe@GrabYourPitchforks@safern@ericstj@jkotas@AndyAyersMS@danmoseley@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets - #33562
Merged
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Mar 14, 2020
Merged
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets#33562
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:

    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3
From https://github.com/dotnet/runtime-assets
  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:

    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20200…
8d4b127
…312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❓ Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
565e061
…ld 20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestrodotnet-maestroBot
changed the title
[master] Update dependencies from dotnet/arcade[master] Update dependencies from dotnet/arcade dotnet/runtime-assetsMar 13, 2020

This was referenced Mar 13, 2020
 Closed

 Merged

@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@GrabYourPitchforks
GrabYourPitchforks
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
CI is failing:
.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98
@gugavaro could this impact what checks are triggered? CC @ericstj
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Also CC @safern@Anipik@ViktorHofer
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?
@ericstj
ericstj
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I believe we already merged them. Just need to rerun against tip.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I saw that now: 4480bdb
I'll re-run.
@safernsafern
closed this
Mar 13, 2020
@safernsafern
reopened this
Mar 13, 2020
ericstj
ericstj
reviewed
Mar 13, 2020
View reviewed changes
Comment threadeng/Versions.props
Outdated

 <MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
 <MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
 <MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
 <MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>
@ericstjericstjMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.
@wtgodbewtgodbeMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml
4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Fixed.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
@jaredpar@jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I have not see it. Do you see the same failures in the rolling builds on master?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918
Looking at the commits.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1
@AndyAyersMSAndyAyersMS
mentioned this pull request
Mar 13, 2020
 Merged

@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Or the GCC change. Is it possible that we are running the tests against GCC built binaries?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
The GCC leg should be build-only. No tests.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
This makes the GCC change more likely culprit.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280
The GCC leg should be build-only. No tests.
I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.
@safern
safern
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz
I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?
Clang build
2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build
2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.
I put up a PR to fix it: #33580
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@echesakovechesakov
mentioned this pull request
Mar 14, 2020
 Merged

@GrabYourPitchforksGrabYourPitchforks
mentioned this pull request
Mar 14, 2020
 Merged

@safern
safern
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
Failures are known and fixed: #33580
@safern
safern
merged commit b22719b
into
masterMar 14, 2020
@safern
safern
deleted the

darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9

branch
March 14, 2020 03:46
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
@danmoseleydanmoseley
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure

labels
Jul 28, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@wtgodbewtgodbewtgodbe left review comments
@safernsafernsafern left review comments

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@wtgodbe@GrabYourPitchforks@safern@ericstj@jkotas@AndyAyersMS@danmoseley@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets - #33562
Merged
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Mar 14, 2020
Merged
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets#33562
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:

    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3
From https://github.com/dotnet/runtime-assets
  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:

    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20200…
8d4b127
…312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❓ Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
565e061
…ld 20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestrodotnet-maestroBot
changed the title
[master] Update dependencies from dotnet/arcade[master] Update dependencies from dotnet/arcade dotnet/runtime-assetsMar 13, 2020

This was referenced Mar 13, 2020
 Closed

 Merged

@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@GrabYourPitchforks
GrabYourPitchforks
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
CI is failing:
.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98
@gugavaro could this impact what checks are triggered? CC @ericstj
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Also CC @safern@Anipik@ViktorHofer
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?
@ericstj
ericstj
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I believe we already merged them. Just need to rerun against tip.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I saw that now: 4480bdb
I'll re-run.
@safernsafern
closed this
Mar 13, 2020
@safernsafern
reopened this
Mar 13, 2020
ericstj
ericstj
reviewed
Mar 13, 2020
View reviewed changes
Comment threadeng/Versions.props
Outdated

 <MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
 <MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
 <MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
 <MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>
@ericstjericstjMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.
@wtgodbewtgodbeMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml
4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Fixed.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
@jaredpar@jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I have not see it. Do you see the same failures in the rolling builds on master?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918
Looking at the commits.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1
@AndyAyersMSAndyAyersMS
mentioned this pull request
Mar 13, 2020
 Merged

@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Or the GCC change. Is it possible that we are running the tests against GCC built binaries?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
The GCC leg should be build-only. No tests.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
This makes the GCC change more likely culprit.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280
The GCC leg should be build-only. No tests.
I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.
@safern
safern
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz
I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?
Clang build
2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build
2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.
I put up a PR to fix it: #33580
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@echesakovechesakov
mentioned this pull request
Mar 14, 2020
 Merged

@GrabYourPitchforksGrabYourPitchforks
mentioned this pull request
Mar 14, 2020
 Merged

@safern
safern
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
Failures are known and fixed: #33580
@safern
safern
merged commit b22719b
into
masterMar 14, 2020
@safern
safern
deleted the

darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9

branch
March 14, 2020 03:46
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
@danmoseleydanmoseley
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure

labels
Jul 28, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@wtgodbewtgodbewtgodbe left review comments
@safernsafernsafern left review comments

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@wtgodbe@GrabYourPitchforks@safern@ericstj@jkotas@AndyAyersMS@danmoseley@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets - #33562
Merged
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Mar 14, 2020
Merged
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets#33562
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:

    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3
From https://github.com/dotnet/runtime-assets
  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:

    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20200…
8d4b127
…312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❓ Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
565e061
…ld 20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestrodotnet-maestroBot
changed the title
[master] Update dependencies from dotnet/arcade[master] Update dependencies from dotnet/arcade dotnet/runtime-assetsMar 13, 2020

This was referenced Mar 13, 2020
 Closed

 Merged

@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@GrabYourPitchforks
GrabYourPitchforks
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
CI is failing:
.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98
@gugavaro could this impact what checks are triggered? CC @ericstj
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Also CC @safern@Anipik@ViktorHofer
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?
@ericstj
ericstj
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I believe we already merged them. Just need to rerun against tip.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I saw that now: 4480bdb
I'll re-run.
@safernsafern
closed this
Mar 13, 2020
@safernsafern
reopened this
Mar 13, 2020
ericstj
ericstj
reviewed
Mar 13, 2020
View reviewed changes
Comment threadeng/Versions.props
Outdated

 <MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
 <MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
 <MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
 <MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>
@ericstjericstjMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.
@wtgodbewtgodbeMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml
4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Fixed.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
@jaredpar@jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I have not see it. Do you see the same failures in the rolling builds on master?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918
Looking at the commits.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1
@AndyAyersMSAndyAyersMS
mentioned this pull request
Mar 13, 2020
 Merged

@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Or the GCC change. Is it possible that we are running the tests against GCC built binaries?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
The GCC leg should be build-only. No tests.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
This makes the GCC change more likely culprit.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280
The GCC leg should be build-only. No tests.
I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.
@safern
safern
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz
I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?
Clang build
2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build
2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.
I put up a PR to fix it: #33580
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@echesakovechesakov
mentioned this pull request
Mar 14, 2020
 Merged

@GrabYourPitchforksGrabYourPitchforks
mentioned this pull request
Mar 14, 2020
 Merged

@safern
safern
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
Failures are known and fixed: #33580
@safern
safern
merged commit b22719b
into
masterMar 14, 2020
@safern
safern
deleted the

darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9

branch
March 14, 2020 03:46
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
@danmoseleydanmoseley
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure

labels
Jul 28, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@wtgodbewtgodbewtgodbe left review comments
@safernsafernsafern left review comments

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@wtgodbe@GrabYourPitchforks@safern@ericstj@jkotas@AndyAyersMS@danmoseley@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets - #33562
Merged
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Mar 14, 2020
Merged
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets#33562
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:

    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3
From https://github.com/dotnet/runtime-assets
  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:

    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20200…
8d4b127
…312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❓ Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
565e061
…ld 20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestrodotnet-maestroBot
changed the title
[master] Update dependencies from dotnet/arcade[master] Update dependencies from dotnet/arcade dotnet/runtime-assetsMar 13, 2020

This was referenced Mar 13, 2020
 Closed

 Merged

@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@GrabYourPitchforks
GrabYourPitchforks
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
CI is failing:
.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98
@gugavaro could this impact what checks are triggered? CC @ericstj
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Also CC @safern@Anipik@ViktorHofer
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?
@ericstj
ericstj
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I believe we already merged them. Just need to rerun against tip.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I saw that now: 4480bdb
I'll re-run.
@safernsafern
closed this
Mar 13, 2020
@safernsafern
reopened this
Mar 13, 2020
ericstj
ericstj
reviewed
Mar 13, 2020
View reviewed changes
Comment threadeng/Versions.props
Outdated

 <MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
 <MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
 <MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
 <MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>
@ericstjericstjMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.
@wtgodbewtgodbeMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml
4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Fixed.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
@jaredpar@jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I have not see it. Do you see the same failures in the rolling builds on master?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918
Looking at the commits.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1
@AndyAyersMSAndyAyersMS
mentioned this pull request
Mar 13, 2020
 Merged

@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Or the GCC change. Is it possible that we are running the tests against GCC built binaries?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
The GCC leg should be build-only. No tests.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
This makes the GCC change more likely culprit.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280
The GCC leg should be build-only. No tests.
I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.
@safern
safern
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz
I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?
Clang build
2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build
2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.
I put up a PR to fix it: #33580
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@echesakovechesakov
mentioned this pull request
Mar 14, 2020
 Merged

@GrabYourPitchforksGrabYourPitchforks
mentioned this pull request
Mar 14, 2020
 Merged

@safern
safern
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
Failures are known and fixed: #33580
@safern
safern
merged commit b22719b
into
masterMar 14, 2020
@safern
safern
deleted the

darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9

branch
March 14, 2020 03:46
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
@danmoseleydanmoseley
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure

labels
Jul 28, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@wtgodbewtgodbewtgodbe left review comments
@safernsafernsafern left review comments

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@wtgodbe@GrabYourPitchforks@safern@ericstj@jkotas@AndyAyersMS@danmoseley@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets - #33562
Merged
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Mar 14, 2020
Merged
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets#33562
safern merged 3 commits into
masterfrom 
darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:

    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3
From https://github.com/dotnet/runtime-assets
  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:

    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20200…
8d4b127
…312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❓ Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
565e061
…ld 20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestrodotnet-maestroBot
changed the title
[master] Update dependencies from dotnet/arcade[master] Update dependencies from dotnet/arcade dotnet/runtime-assetsMar 13, 2020

This was referenced Mar 13, 2020
 Closed

 Merged

@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@GrabYourPitchforks
GrabYourPitchforks
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
CI is failing:
.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98
@gugavaro could this impact what checks are triggered? CC @ericstj
@wtgodbe
wtgodbe
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Also CC @safern@Anipik@ViktorHofer
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?
@ericstj
ericstj
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I believe we already merged them. Just need to rerun against tip.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I saw that now: 4480bdb
I'll re-run.
@safernsafern
closed this
Mar 13, 2020
@safernsafern
reopened this
Mar 13, 2020
ericstj
ericstj
reviewed
Mar 13, 2020
View reviewed changes
Comment threadeng/Versions.props
Outdated

 <MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
 <MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
 <MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
 <MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>
@ericstjericstjMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.
@wtgodbewtgodbeMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4
@safernsafernMar 13, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml
4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Fixed.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
@jaredpar@jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I have not see it. Do you see the same failures in the rolling builds on master?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918
Looking at the commits.
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1
@AndyAyersMSAndyAyersMS
mentioned this pull request
Mar 13, 2020
 Merged

@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Or the GCC change. Is it possible that we are running the tests against GCC built binaries?
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
The GCC leg should be build-only. No tests.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
@jkotas
jkotas
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.
This makes the GCC change more likely culprit.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280
The GCC leg should be build-only. No tests.
I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.
@safern
safern
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz
I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@AndyAyersMS
AndyAyersMS
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?
Clang build
2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build
2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@safern
safern
commented
Mar 13, 2020

Copy link


Copy Markdown

Member
Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.
I put up a PR to fix it: #33580
@dotnet-maestro
dotnet-maestroBot
commented
Mar 13, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Auto-Merge Status
This pull request has not been merged because Maestro++ is waiting on the following merge policies.
  • ❌ Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
@echesakovechesakov
mentioned this pull request
Mar 14, 2020
 Merged

@GrabYourPitchforksGrabYourPitchforks
mentioned this pull request
Mar 14, 2020
 Merged

@safern
safern
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
Failures are known and fixed: #33580
@safern
safern
merged commit b22719b
into
masterMar 14, 2020
@safern
safern
deleted the

darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9

branch
March 14, 2020 03:46
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
@danmoseleydanmoseley
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure

labels
Jul 28, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@wtgodbewtgodbewtgodbe left review comments
@safernsafernsafern left review comments

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@wtgodbe@GrabYourPitchforks@safern@ericstj@jkotas@AndyAyersMS@danmoseley@Dotnet-GitSync-Bot