Skip to content

Enable Microsoft.Extensions.DependencyInjection - #33816

Merged
maryamariyan merged 11 commits into
dotnet:masterfrom
maryamariyan:fix-di-tests
Mar 22, 2020
Merged

Enable Microsoft.Extensions.DependencyInjection#33816
maryamariyan merged 11 commits into
dotnet:masterfrom
maryamariyan:fix-di-tests

Conversation

@maryamariyan

@maryamariyanmaryamariyan commented Mar 19, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Enables DI and Options.

@maryamariyanmaryamariyan self-assigned this Mar 19, 2020
@maryamariyanmaryamariyan mentioned this pull request Mar 19, 2020
Merged
@maryamariyanmaryamariyan mentioned this pull request Mar 19, 2020
Closed
safern
safern reviewed Mar 19, 2020
View reviewed changes
Comment thread...t.Extensions.DependencyInjection/tests/Microsoft.Extensions.DependencyInjection.Tests.csproj Outdated

@safernsafernMar 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this file should/could be converged with the AssertExtensions we have in our Private test utilities.

@maryamariyanmaryamariyanMar 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'll mark this as todo when I'm cleaning up the unused files. (future PR)

@maryamariyan

maryamariyan commented Mar 20, 2020

Copy link
Copy Markdown
ContributorAuthor

I see mono failure on the CI:
https://helix.dot.net/api/2019-06-17/jobs/97ba643d-68bb-4f46-81a3-a2094e58b3a3/workitems/Microsoft.Extensions.DependencyInjection.Tests/console

@ericstj

ericstj commented Mar 20, 2020

Copy link
Copy Markdown
Member

This one has a callstack: https://helix.dot.net/api/2019-06-17/jobs/80e913aa-a462-4f20-be32-a4a2e16fc14c/workitems/Microsoft.Extensions.DependencyInjection.Tests/console

maryamariyan
maryamariyan commented Mar 20, 2020
View reviewed changes
Comment threadsrc/mono/netcore/CoreFX.issues_linux.rsp Outdated
@maryamariyan
Enables DI and Options
e6bb861
- Moves files under DI/tests/Common to Logging/tests/DI.Common as they are Logging tests
- Simplifies and enables DI test csproj
- TODO: Fix test on "ServiceCollectionServiceExtensionsTest.cs"
@maryamariyan
TODO: fix
307b2e0
maryamariyanand others added 6 commits March 20, 2020 14:52
@maryamariyan

maryamariyan commented Mar 20, 2020

Copy link
Copy Markdown
ContributorAuthor

resolved conflict by rebase.

@ericstjericstj mentioned this pull request Mar 21, 2020
Closed
@ericstj

ericstj commented Mar 21, 2020

Copy link
Copy Markdown
Member

Mono failure is #32377. I'm seeing this on all recent builds, so I don't think it's related to this change.

@maryamariyan
maryamariyan merged commit 110804e into dotnet:masterMar 22, 2020
@davidfowl

davidfowl commented Mar 22, 2020

Copy link
Copy Markdown
Member

👏

@maryamariyanmaryamariyan mentioned this pull request Jun 12, 2020
Closed
11 tasks
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@safernsafernsafern left review comments
@ericstjericstjericstj approved these changes
@AnipikAnipikAwaiting requested review from Anipik
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@EgorBoEgorBoAwaiting requested review from EgorBo
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz

Assignees

@maryamariyanmaryamariyan

Labels

area-Extensions-DependencyInjection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maryamariyan@ericstj@davidfowl@steveisok@safern@Dotnet-GitSync-Bot