Uh oh!
There was an error while loading. Please reload this page.
[mono] Don't throw inheritance error on interfaces in GetCustomAttrs - #33942
Conversation
CoffeeFlux
commented
Mar 23, 2020
@stephentoub can you check the test and make sure it's in the right place? Wasn't sure where to put it. |
akoeplinger
left a comment
There was a problem hiding this comment.
I think I'd put it somewhere after
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CoffeeFlux
commented
Mar 24, 2020
From what I could tell, the GetCustomAttributes tests were all in the file for their parent class since their behavior differs some (e.g. MemberInfo tests have a bunch), which is why I put it here but wasn't sure. Can move if you still think that's the best place for it, and I'll fix the style. |
akoeplinger
commented
Mar 24, 2020
I have no strong feeling on that one, the place you picked is probably fine too :) |
3e92efa to
f625489CompareLooking at dotnet#7190, the .NET Core behavior here is strange and my changes in dotnet@0844cb7a6152 with the type checking may have been a mistake. I think this should be fine with the interface special-casing, but if deemed too great a concern I can revert that subset of my old changes. Additionally, if people come up with other scenarios where this might fail, I'll just revert until we can migrate to use a shared CustomAttribute implementation rather than try to play whack-a-mole.
f625489 to
6d224ceCompare
Fixes#33639
Looking at #7190, the .NET Core behavior here is strange and my changes in 0844cb7a6152 with the type checking may have been a mistake. I think this should be fine with the interface special-casing, but if deemed too great a concern I can revert that subset of my old changes. Additionally, if people come up with other scenarios where this might fail, I'll just revert until we can migrate to use a shared CustomAttribute implementation rather than try to play whack-a-mole.