Remove CoreFX.issues_linux.rsp file#33953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 6 commits into from
Mar 25, 2020
Merged

Remove CoreFX.issues_linux.rsp file #33953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40134e6
Enable some tests passing locally
MaximLipnin Mar 23, 2020
6580ee0
Disable several tests failing in linux CI due to the problem with
MaximLipnin Mar 24, 2020
ae94ba7
Enable tests passing locally on Ubuntu 18.04
MaximLipnin Mar 24, 2020
507fef4
Disable several tests failing in
MaximLipnin Mar 24, 2020
b879312
Remove CoreFX.issues_linux.rsp file
MaximLipnin Mar 25, 2020
84984d5
Fix condition for including rsp files
MaximLipnin Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eng/testing/tests.targets
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,11 +80,10 @@
<!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
<ItemGroup>
<_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
</ItemGroup>
<ItemGroup>
<_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" />
<_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />
</ItemGroup>

<WriteLinesToFile File="$(MonoRspFile)" Lines="@(_rspFileContent)" Overwrite="true" />
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public static void BinaryFormattedResources()
{
var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -300,6 +301,7 @@ public static void BinaryFormattedResources()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public static void BinaryFormattedResourcesWithoutTypeName()
{
var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -397,6 +399,7 @@ public static void TypeConverterStringResources()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public static void StreamResources()
{
var values = TestData.Activator;
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -268,6 +268,7 @@ public static IEnumerable<object[]> EnglishImageResourceData()
}

[ConditionalTheory(Helpers.IsDrawingSupported)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(EnglishImageResourceData))]
public static void GetObject_Images(string key, object expectedValue)
{
Expand All@@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue)
}

[ConditionalTheory(Helpers.IsDrawingSupported)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(EnglishImageResourceData))]
public static void GetObject_Images_ResourceSet(string key, object expectedValue)
{
Expand DownExpand Up@@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b
}

[ConditionalTheory(Helpers.IsDrawingSupported)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(EnglishImageResourceData))]
public static void GetResourceSet_Images(string key, object expectedValue)
{
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -747,6 +747,7 @@ public static void GetPermissionSet()
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
{
Expand DownExpand Up@@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
};

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
{
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit)

[Theory]
[SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(BasicObjectsRoundtrip_MemberData))]
public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat)
{
Expand DownExpand Up@@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void RoundtripManyObjectsInOneStream()
{
object[][] objects = SerializableObjects_MemberData().ToArray();
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Runtime/tests/System/ActivatorTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
{
Expand DownExpand Up@@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
};

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
{
Expand Down
49 changes: 0 additions & 49 deletions src/mono/netcore/CoreFX.issues_linux.rsp
View file
Open in desktop

This file was deleted.

, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Remove CoreFX.issues_linux.rsp file#33953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

stephentoub
merged 6 commits into

from

Mar 25, 2020
 Merged


Remove CoreFX.issues_linux.rsp file
#33953
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
40134e6

Enable some tests passing locally


MaximLipnin Mar 23, 2020
6580ee0

Disable several tests failing in linux CI due to the problem with


MaximLipnin Mar 24, 2020
ae94ba7

Enable tests passing locally on Ubuntu 18.04


MaximLipnin Mar 24, 2020
507fef4

Disable several tests failing in


MaximLipnin Mar 24, 2020
b879312

Remove CoreFX.issues_linux.rsp file


MaximLipnin Mar 25, 2020
84984d5

Fix condition for including rsp files


MaximLipnin Mar 25, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
eng/testing/tests.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -80,11 +80,10 @@
 <!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
 <ItemGroup>
 <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
 </ItemGroup>
 <ItemGroup>
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" />
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />
 </ItemGroup>

 <WriteLinesToFile File="$(MonoRspFile)" Lines="@(_rspFileContent)" Overwrite="true" />
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResources()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -300,6 +301,7 @@ public static void BinaryFormattedResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResourcesWithoutTypeName()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -397,6 +399,7 @@ public static void TypeConverterStringResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void StreamResources()
 {
 var values = TestData.Activator;
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -268,6 +268,7 @@ public static IEnumerable<object[]> EnglishImageResourceData()
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images(string key, object expectedValue)
 {
Expand All@@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue)
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images_ResourceSet(string key, object expectedValue)
 {
Expand DownExpand Up@@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetResourceSet_Images(string key, object expectedValue)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,6 +747,7 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit)

 [Theory]
 [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(BasicObjectsRoundtrip_MemberData))]
 public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat)
 {
Expand DownExpand Up@@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public void RoundtripManyObjectsInOneStream()
 {
 object[][] objects = SerializableObjects_MemberData().ToArray();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime/tests/System/ActivatorTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

49 changes: 0 additions & 49 deletions
src/mono/netcore/CoreFX.issues_linux.rsp

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove CoreFX.issues_linux.rsp file#33953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

stephentoub
merged 6 commits into

from

Mar 25, 2020
 Merged


Remove CoreFX.issues_linux.rsp file
#33953
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
40134e6

Enable some tests passing locally


MaximLipnin Mar 23, 2020
6580ee0

Disable several tests failing in linux CI due to the problem with


MaximLipnin Mar 24, 2020
ae94ba7

Enable tests passing locally on Ubuntu 18.04


MaximLipnin Mar 24, 2020
507fef4

Disable several tests failing in


MaximLipnin Mar 24, 2020
b879312

Remove CoreFX.issues_linux.rsp file


MaximLipnin Mar 25, 2020
84984d5

Fix condition for including rsp files


MaximLipnin Mar 25, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
eng/testing/tests.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -80,11 +80,10 @@
 <!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
 <ItemGroup>
 <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
 </ItemGroup>
 <ItemGroup>
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" />
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />
 </ItemGroup>

 <WriteLinesToFile File="$(MonoRspFile)" Lines="@(_rspFileContent)" Overwrite="true" />
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResources()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -300,6 +301,7 @@ public static void BinaryFormattedResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResourcesWithoutTypeName()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -397,6 +399,7 @@ public static void TypeConverterStringResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void StreamResources()
 {
 var values = TestData.Activator;
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -268,6 +268,7 @@ public static IEnumerable<object[]> EnglishImageResourceData()
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images(string key, object expectedValue)
 {
Expand All@@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue)
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images_ResourceSet(string key, object expectedValue)
 {
Expand DownExpand Up@@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetResourceSet_Images(string key, object expectedValue)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,6 +747,7 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit)

 [Theory]
 [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(BasicObjectsRoundtrip_MemberData))]
 public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat)
 {
Expand DownExpand Up@@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public void RoundtripManyObjectsInOneStream()
 {
 object[][] objects = SerializableObjects_MemberData().ToArray();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime/tests/System/ActivatorTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

49 changes: 0 additions & 49 deletions
src/mono/netcore/CoreFX.issues_linux.rsp

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove CoreFX.issues_linux.rsp file#33953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

stephentoub
merged 6 commits into

from

Mar 25, 2020
 Merged


Remove CoreFX.issues_linux.rsp file
#33953
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
40134e6

Enable some tests passing locally


MaximLipnin Mar 23, 2020
6580ee0

Disable several tests failing in linux CI due to the problem with


MaximLipnin Mar 24, 2020
ae94ba7

Enable tests passing locally on Ubuntu 18.04


MaximLipnin Mar 24, 2020
507fef4

Disable several tests failing in


MaximLipnin Mar 24, 2020
b879312

Remove CoreFX.issues_linux.rsp file


MaximLipnin Mar 25, 2020
84984d5

Fix condition for including rsp files


MaximLipnin Mar 25, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
eng/testing/tests.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -80,11 +80,10 @@
 <!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
 <ItemGroup>
 <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
 </ItemGroup>
 <ItemGroup>
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" />
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />
 </ItemGroup>

 <WriteLinesToFile File="$(MonoRspFile)" Lines="@(_rspFileContent)" Overwrite="true" />
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResources()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -300,6 +301,7 @@ public static void BinaryFormattedResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResourcesWithoutTypeName()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -397,6 +399,7 @@ public static void TypeConverterStringResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void StreamResources()
 {
 var values = TestData.Activator;
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -268,6 +268,7 @@ public static IEnumerable<object[]> EnglishImageResourceData()
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images(string key, object expectedValue)
 {
Expand All@@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue)
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images_ResourceSet(string key, object expectedValue)
 {
Expand DownExpand Up@@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetResourceSet_Images(string key, object expectedValue)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,6 +747,7 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit)

 [Theory]
 [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(BasicObjectsRoundtrip_MemberData))]
 public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat)
 {
Expand DownExpand Up@@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public void RoundtripManyObjectsInOneStream()
 {
 object[][] objects = SerializableObjects_MemberData().ToArray();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime/tests/System/ActivatorTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

49 changes: 0 additions & 49 deletions
src/mono/netcore/CoreFX.issues_linux.rsp

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Remove CoreFX.issues_linux.rsp file#33953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

stephentoub
merged 6 commits into

from

Mar 25, 2020
 Merged


Remove CoreFX.issues_linux.rsp file
#33953
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
40134e6

Enable some tests passing locally


MaximLipnin Mar 23, 2020
6580ee0

Disable several tests failing in linux CI due to the problem with


MaximLipnin Mar 24, 2020
ae94ba7

Enable tests passing locally on Ubuntu 18.04


MaximLipnin Mar 24, 2020
507fef4

Disable several tests failing in


MaximLipnin Mar 24, 2020
b879312

Remove CoreFX.issues_linux.rsp file


MaximLipnin Mar 25, 2020
84984d5

Fix condition for including rsp files


MaximLipnin Mar 25, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
eng/testing/tests.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -80,11 +80,10 @@
 <!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
 <ItemGroup>
 <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
 </ItemGroup>
 <ItemGroup>
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" />
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />
 </ItemGroup>

 <WriteLinesToFile File="$(MonoRspFile)" Lines="@(_rspFileContent)" Overwrite="true" />
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResources()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -300,6 +301,7 @@ public static void BinaryFormattedResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResourcesWithoutTypeName()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -397,6 +399,7 @@ public static void TypeConverterStringResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void StreamResources()
 {
 var values = TestData.Activator;
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -268,6 +268,7 @@ public static IEnumerable<object[]> EnglishImageResourceData()
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images(string key, object expectedValue)
 {
Expand All@@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue)
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images_ResourceSet(string key, object expectedValue)
 {
Expand DownExpand Up@@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetResourceSet_Images(string key, object expectedValue)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,6 +747,7 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit)

 [Theory]
 [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(BasicObjectsRoundtrip_MemberData))]
 public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat)
 {
Expand DownExpand Up@@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public void RoundtripManyObjectsInOneStream()
 {
 object[][] objects = SerializableObjects_MemberData().ToArray();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime/tests/System/ActivatorTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

49 changes: 0 additions & 49 deletions
src/mono/netcore/CoreFX.issues_linux.rsp

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove CoreFX.issues_linux.rsp file#33953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

stephentoub
merged 6 commits into

from

Mar 25, 2020
 Merged


Remove CoreFX.issues_linux.rsp file
#33953
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
40134e6

Enable some tests passing locally


MaximLipnin Mar 23, 2020
6580ee0

Disable several tests failing in linux CI due to the problem with


MaximLipnin Mar 24, 2020
ae94ba7

Enable tests passing locally on Ubuntu 18.04


MaximLipnin Mar 24, 2020
507fef4

Disable several tests failing in


MaximLipnin Mar 24, 2020
b879312

Remove CoreFX.issues_linux.rsp file


MaximLipnin Mar 25, 2020
84984d5

Fix condition for including rsp files


MaximLipnin Mar 25, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
eng/testing/tests.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -80,11 +80,10 @@
 <!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
 <ItemGroup>
 <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
 </ItemGroup>
 <ItemGroup>
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" />
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />
 </ItemGroup>

 <WriteLinesToFile File="$(MonoRspFile)" Lines="@(_rspFileContent)" Overwrite="true" />
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResources()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -300,6 +301,7 @@ public static void BinaryFormattedResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResourcesWithoutTypeName()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -397,6 +399,7 @@ public static void TypeConverterStringResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void StreamResources()
 {
 var values = TestData.Activator;
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -268,6 +268,7 @@ public static IEnumerable<object[]> EnglishImageResourceData()
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images(string key, object expectedValue)
 {
Expand All@@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue)
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images_ResourceSet(string key, object expectedValue)
 {
Expand DownExpand Up@@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetResourceSet_Images(string key, object expectedValue)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,6 +747,7 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit)

 [Theory]
 [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(BasicObjectsRoundtrip_MemberData))]
 public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat)
 {
Expand DownExpand Up@@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public void RoundtripManyObjectsInOneStream()
 {
 object[][] objects = SerializableObjects_MemberData().ToArray();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime/tests/System/ActivatorTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

49 changes: 0 additions & 49 deletions
src/mono/netcore/CoreFX.issues_linux.rsp

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove CoreFX.issues_linux.rsp file#33953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

stephentoub
merged 6 commits into

from

Mar 25, 2020
 Merged


Remove CoreFX.issues_linux.rsp file
#33953
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
40134e6

Enable some tests passing locally


MaximLipnin Mar 23, 2020
6580ee0

Disable several tests failing in linux CI due to the problem with


MaximLipnin Mar 24, 2020
ae94ba7

Enable tests passing locally on Ubuntu 18.04


MaximLipnin Mar 24, 2020
507fef4

Disable several tests failing in


MaximLipnin Mar 24, 2020
b879312

Remove CoreFX.issues_linux.rsp file


MaximLipnin Mar 25, 2020
84984d5

Fix condition for including rsp files


MaximLipnin Mar 25, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
eng/testing/tests.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -80,11 +80,10 @@
 <!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
 <ItemGroup>
 <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
 </ItemGroup>
 <ItemGroup>
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" />
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />
 </ItemGroup>

 <WriteLinesToFile File="$(MonoRspFile)" Lines="@(_rspFileContent)" Overwrite="true" />
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResources()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -300,6 +301,7 @@ public static void BinaryFormattedResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResourcesWithoutTypeName()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -397,6 +399,7 @@ public static void TypeConverterStringResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void StreamResources()
 {
 var values = TestData.Activator;
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -268,6 +268,7 @@ public static IEnumerable<object[]> EnglishImageResourceData()
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images(string key, object expectedValue)
 {
Expand All@@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue)
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images_ResourceSet(string key, object expectedValue)
 {
Expand DownExpand Up@@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetResourceSet_Images(string key, object expectedValue)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,6 +747,7 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit)

 [Theory]
 [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(BasicObjectsRoundtrip_MemberData))]
 public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat)
 {
Expand DownExpand Up@@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public void RoundtripManyObjectsInOneStream()
 {
 object[][] objects = SerializableObjects_MemberData().ToArray();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime/tests/System/ActivatorTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

49 changes: 0 additions & 49 deletions
src/mono/netcore/CoreFX.issues_linux.rsp

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Remove CoreFX.issues_linux.rsp file#33953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

stephentoub
merged 6 commits into

from

Mar 25, 2020
 Merged


Remove CoreFX.issues_linux.rsp file
#33953
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
40134e6

Enable some tests passing locally


MaximLipnin Mar 23, 2020
6580ee0

Disable several tests failing in linux CI due to the problem with


MaximLipnin Mar 24, 2020
ae94ba7

Enable tests passing locally on Ubuntu 18.04


MaximLipnin Mar 24, 2020
507fef4

Disable several tests failing in


MaximLipnin Mar 24, 2020
b879312

Remove CoreFX.issues_linux.rsp file


MaximLipnin Mar 25, 2020
84984d5

Fix condition for including rsp files


MaximLipnin Mar 25, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
eng/testing/tests.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -80,11 +80,10 @@
 <!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
 <ItemGroup>
 <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
 <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
 </ItemGroup>
 <ItemGroup>
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" />
 <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />
 </ItemGroup>

 <WriteLinesToFile File="$(MonoRspFile)" Lines="@(_rspFileContent)" Overwrite="true" />
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResources()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -300,6 +301,7 @@ public static void BinaryFormattedResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void BinaryFormattedResourcesWithoutTypeName()
 {
 var values = TestData.BinaryFormatted;
Expand DownExpand Up@@ -397,6 +399,7 @@ public static void TypeConverterStringResources()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public static void StreamResources()
 {
 var values = TestData.Activator;
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -268,6 +268,7 @@ public static IEnumerable<object[]> EnglishImageResourceData()
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images(string key, object expectedValue)
 {
Expand All@@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue)
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetObject_Images_ResourceSet(string key, object expectedValue)
 {
Expand DownExpand Up@@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b
 }

 [ConditionalTheory(Helpers.IsDrawingSupported)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(EnglishImageResourceData))]
 public static void GetResourceSet_Images(string key, object expectedValue)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,6 +747,7 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit)

 [Theory]
 [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(BasicObjectsRoundtrip_MemberData))]
 public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat)
 {
Expand DownExpand Up@@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 public void RoundtripManyObjectsInOneStream()
 {
 object[][] objects = SerializableObjects_MemberData().ToArray();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/System.Runtime/tests/System/ActivatorTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
Expand Down

49 changes: 0 additions & 49 deletions
src/mono/netcore/CoreFX.issues_linux.rsp

View file


Open in desktop


This file was deleted.