Add build configuration to generate runtime packs for iOS by steveisok · Pull Request #34050 · dotnet/runtime

steveisok · 2020-03-25T00:52:59Z

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

jaredpar · 2020-03-31T02:50:57Z

If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?

I'd prefer doing that in another PR.

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

…epeat iOS_x64. This was causing the installer leg creation to fail

Added cross and include into the native part of the runtime pack Addressed feedback

…n the official build.

steveisok · 2020-03-25T00:52:59Z

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

jaredpar · 2020-03-31T02:50:57Z

If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?

I'd prefer doing that in another PR.

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

…epeat iOS_x64. This was causing the installer leg creation to fail

Added cross and include into the native part of the runtime pack Addressed feedback

…n the official build.

steveisok · 2020-03-25T00:52:59Z

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

jaredpar · 2020-03-31T02:50:57Z

If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?

I'd prefer doing that in another PR.

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

…epeat iOS_x64. This was causing the installer leg creation to fail

Added cross and include into the native part of the runtime pack Addressed feedback

…n the official build.

steveisok · 2020-03-25T00:52:59Z

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

jaredpar · 2020-03-31T02:50:57Z

If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?

I'd prefer doing that in another PR.

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

…epeat iOS_x64. This was causing the installer leg creation to fail

Added cross and include into the native part of the runtime pack Addressed feedback

…n the official build.

steveisok · 2020-03-25T00:52:59Z

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

jaredpar · 2020-03-31T02:50:57Z

If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?

I'd prefer doing that in another PR.

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

…epeat iOS_x64. This was causing the installer leg creation to fail

Added cross and include into the native part of the runtime pack Addressed feedback

…n the official build.

steveisok · 2020-03-25T00:52:59Z

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

jaredpar · 2020-03-31T02:50:57Z

If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?

I'd prefer doing that in another PR.

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

…epeat iOS_x64. This was causing the installer leg creation to fail

Added cross and include into the native part of the runtime pack Addressed feedback

…n the official build.

steveisok · 2020-03-25T00:52:59Z

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

jaredpar · 2020-03-31T02:50:57Z

If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?

I'd prefer doing that in another PR.

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

…epeat iOS_x64. This was causing the installer leg creation to fail

Added cross and include into the native part of the runtime pack Addressed feedback

…n the official build.

steveisok · 2020-03-25T00:52:59Z

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

jaredpar · 2020-03-31T02:50:57Z

If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?

I'd prefer doing that in another PR.

This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

…epeat iOS_x64. This was causing the installer leg creation to fail

Added cross and include into the native part of the runtime pack Addressed feedback

…n the official build.

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Mar 25, 2020

steveisok requested review from NikolaMilosavljevic, akoeplinger and dagood March 25, 2020 00:53

steveisok mentioned this pull request Mar 25, 2020
Ensure correct packaging for iOS and Android #33690
Closed
6 tasks

marek-safar reviewed Mar 25, 2020
View reviewed changes

Comment threadeng/Subsets.props Outdated

akoeplinger reviewed Mar 25, 2020
View reviewed changes

Comment threadeng/Subsets.props Outdated
Comment threadeng/Subsets.props Outdated

mdh1418 reviewed Mar 25, 2020
View reviewed changes

Comment threadeng/liveBuilds.targets Outdated

dagood reviewed Mar 25, 2020
View reviewed changes

dagood requested a review from a teamMarch 25, 2020 15:33

jaredpar reviewed Mar 25, 2020
View reviewed changes

Comment threadeng/referenceFromRuntime.targets Outdated

dagood reviewed Mar 25, 2020
View reviewed changes

Comment threadeng/liveBuilds.targets Outdated

ericstj requested a review from ViktorHofer March 25, 2020 20:24

This was referenced Mar 25, 2020
Test Failed: GetAsync_SetCookieContainer_CookieSent failed #12043
Closed
Errors installing the SDK during builds #34015
Closed

mdh1418 reviewed Mar 26, 2020
View reviewed changes

Comment threadeng/liveBuilds.targets Outdated

mdh1418 mentioned this pull request Mar 27, 2020
Add build configuration to generate runtime packs for Android #34192
Merged

mdh1418 reviewed Mar 27, 2020
View reviewed changes

Comment threadsrc/installer/Directory.Build.props Outdated

mdh1418 reviewed Mar 27, 2020
View reviewed changes

Comment threadsrc/installer/Directory.Build.props Outdated

safern reviewed Mar 27, 2020
View reviewed changes

Comment threadeng/pipelines/runtime.yml Outdated

safern reviewed Mar 27, 2020
View reviewed changes

Comment threadeng/pipelines/installer/jobs/base-job.yml Outdated

jaredpar reviewed Mar 31, 2020
View reviewed changes

safern reviewed Mar 31, 2020
View reviewed changes

Comment threadeng/liveBuilds.targets Outdated

Steve Pfister added 7 commits March 31, 2020 17:41

Add build configuration to generate runtime packs for iOS
6c61240
This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.

Take away unnecessary subsets / fix syntax error
f88d464

Addressed some feedback
f7a6dd7

Attempt to add iOS installer lanes
013d727

Trying a single platform to see if it'll work
ff4c087

I guess there's one already?
b997ec4

Adding ios installer ci back in. It's gonna fail
bb866f8

Steve Pfister added 6 commits March 31, 2020 17:41

Tweaked platform matrix for ios_arm & ios_arm64 so that they do not r…
a7e7237
…epeat iOS_x64. This was causing the installer leg creation to fail

Added iOS as part of the base job check
5fa7c8f

Added os and archType to the ios installer args
4eff34f

yml syntax :-(
2479df0

Yml syntax
5c6f78f

Pushed skipping unnecessary pkgproj into installer/pkg area
f3b3b0a
Added cross and include into the native part of the runtime pack Addressed feedback

steveisok force-pushed the ios-stuff branch from 2b9f7ed to f3b3b0aCompare March 31, 2020 21:57

dagood reviewed Mar 31, 2020
View reviewed changes

Steve Pfister added 2 commits March 31, 2020 20:24

Adjusted skip props for host pkgproj
b8f457b

More feedback
7060904

dagood reviewed Apr 1, 2020
View reviewed changes

Comment threadsrc/installer/pkg/projects/Directory.Build.targets Outdated
Comment thread...r/pkg/projects/Microsoft.NETCore.DotNetHostPolicy/Microsoft.NETCore.DotNetHostPolicy.pkgproj Outdated

Steve Pfister added 2 commits April 1, 2020 11:11

More feedback
da25949

More feedback
0d7f48b

dagood approved these changes Apr 1, 2020
View reviewed changes

safern reviewed Apr 1, 2020
View reviewed changes

Comment threadsrc/installer/pkg/projects/Directory.Build.targets Outdated

yml syntax in runtime official
84e2f59

akoeplinger reviewed Apr 1, 2020
View reviewed changes

Comment threadsrc/installer/pkg/projects/Directory.Build.targets Outdated

Steve Pfister added 2 commits April 1, 2020 15:07

Last bit of nits
db8b257

Disabled useOfficialAllConfigurations and buildFullPlatformManifest o…
d0dafc3
…n the official build.

steveisok mentioned this pull request Apr 2, 2020
Remove the platform manifest from the iOS / Android Runtime Packs (Official build) #34470
Closed

steveisok merged commit 61d1e78 into dotnet:masterApr 2, 2020

jaredpar mentioned this pull request Apr 2, 2020
OSX machines are de-provisioned during CI / PR runs leading to failures #34472
Closed

ghost locked as resolved and limited conversation to collaborators Dec 10, 2020