Skip to content

Fixing opts.setSupportedISAs to use the computed instructionSetFlags value - #34139

Merged
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:fix-34135
Mar 26, 2020
Merged

Fixing opts.setSupportedISAs to use the computed instructionSetFlags value#34139
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:fix-34135

Conversation

@tannergooding

@tannergoodingtannergooding commented Mar 26, 2020

Copy link
Copy Markdown
Member

This should resolve#34135

@Dotnet-GitSync-BotDotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2020
@tannergooding

tannergooding commented Mar 26, 2020

Copy link
Copy Markdown
MemberAuthor

CC. @CarolEidt, @davidwrighton

The computed instructionSetFlags wasn't otherwise being used, so this looks to be the correct fix.

CarolEidt
CarolEidt approved these changes Mar 26, 2020
View reviewed changes

@CarolEidtCarolEidt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for finding & fixing this!

davidwrighton
davidwrighton approved these changes Mar 26, 2020
View reviewed changes

@davidwrightondavidwrighton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, I noticed it yesterday and didn't quite fix it all up yet.

@davidwrightondavidwrighton mentioned this pull request Mar 26, 2020
Merged
@tannergooding

tannergooding commented Mar 26, 2020

Copy link
Copy Markdown
MemberAuthor

@ViktorHofer, @safern; looks like an issue downloading the .NET SDK: https://dev.azure.com/dnceng/public/_build/results?buildId=574765&view=logs&j=9faa8814-1e1d-5dcb-3dbf-1c9ea62fd5f0&t=378c0a8c-7d34-5361-96eb-73148a466769

It looks like we are just trying to grab latest master so maybe a publishing issue where not everything is available at once?

@tannergooding
tannergooding merged commit 12e77a6 into dotnet:masterMar 26, 2020
@tannergoodingtannergooding mentioned this pull request Mar 26, 2020
Closed
@safern

safern commented Mar 26, 2020

Copy link
Copy Markdown
Member

It seems like it is trying to grab an SDK from a dev test branch: https://dev.azure.com/dnceng/internal/_build/results?buildId=575129

dotnet/installer#6572 (comment)

We're scaling this to get it fixed. cc: @mmitche

@MattGal

MattGal commented Mar 27, 2020

Copy link
Copy Markdown
Member

It seems like it is trying to grab an SDK from a dev test branch: https://dev.azure.com/dnceng/internal/_build/results?buildId=575129

dotnet/installer#6572 (comment)

We're scaling this to get it fixed. cc: @mmitche

To close the loop this was an issue with how channel-based publishing works and people spinning private branches on the offical build def; should be over now.

@tannergoodingtannergooding mentioned this pull request Apr 1, 2020
Merged
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@tannergooding
tannergooding deleted the fix-34135 branch November 11, 2022 15:30
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidwrightondavidwrightondavidwrighton approved these changes
+1 more reviewer
@CarolEidtCarolEidtCarolEidt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

COMPlus_EnableISA=0 variables no longer effect the IsSupported checks

6 participants

@tannergooding@safern@MattGal@CarolEidt@davidwrighton@Dotnet-GitSync-Bot