Uh oh!
There was an error while loading. Please reload this page.
Define dirent d_type for Solaris based OS - #34263
Conversation
am11
commented
Mar 29, 2020
With these changes: src/installer/corehost/build.sh -apphostver "5.0.0-dev" -hostver "5.0.0-dev" \
-fxrver "5.0.0-dev" -policyver "5.0.0-dev" -commithash $(git rev-parse HEAD) -gccsucceeds on SmartOS amd64. There is another layer of shared configuration for SunOS, which is based on top of #34211, I will create a separate PR once these are merged. cc @jkotas |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
am11
commented
Mar 30, 2020
Libraries tests failures are related to #28553. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
am11
commented
Apr 1, 2020
Resolved merge conflict and updated title to reflect what PR is doing now. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
am11
commented
Apr 4, 2020
@jkotas, seems like two CI legs are green on AzDo but GitHub hasn't sync in past two days:
|
On Solaris-like operating systems such as SmartOS,
struct direntdoes not contain a member calledd_type. Although we have a comment about it:runtime/src/installer/corehost/cli/hostmisc/pal.unix.cpp
Line 837 in 5eda36e
d_type. This delta definesd_type'sDT_UNKNOWNand friends for Solaris._Xis defined in one of the system header, so undef it before#define:GCC build of installer was broken even on Linux, due to missing dl link in test project. Align it with what we are already using in src projects:
runtime/src/installer/corehost/cli/common.cmake
Line 44 in 5eda36e
Contributes to #4173.