Test build target agnostic separately from target specific tests

[sdmaclea]

Part of #33066

Modifies build-test to add options to allow building target agnostic tests separately from target specific tests.

• Audited the TraitTags found a few cases where TraitTags were missed in Added OS and Bit Specific tags to accordingly .csproj files. #637. Also added ArchSpecific
• @VSadov is working on a generic filtering mechanism. While waiting for it this PR add an extra property CLRTestNeedTarget to indicate a test which is not target agnostic.
• I had originally tried to build the agnostic tests with AnyOS and AnyCPU, but I ran into lots of issues. So I reverted that.

[ghost]

Tagging @ViktorHofer as an area owner

[sdmaclea]

I tested manually building on Linux. It looks good to me.
I will try building tests on Windows too now.

[sdmaclea]

The simple filtering used in this PR is relatively slow. It takes a while for MSBuild to find the tests to build (when finding the small set of target specific tests).

Generic filtering may be slower.

It is possible we may need to build test lists to make this faster....

[jkoritzinsky]

Can we do a string for CLRTestNeedTargetToBuilds value instead of an opaque number that has to be documented somewhere else?

[sdmaclea]

Can we do a string for CLRTestNeedTargetToBuilds

You're going to make me do the hard work of naming the states.

Effectively right now the states are

• CLRTestNeedTargetToBuild == 0 : False
• CLRTestNeedTargetToBuild == 1: True
• CLRTestNeedTargetToBuild == ''BuildAll

@jkoritzinsky How does BuildTargetGenericTests and BuildTargetSpecificTests sound for strings. Keeping an empty string for the default behavior.

[jkoritzinsky]

Those work. We could also shorten them to "TargetGeneric" and "TargetSpecific" if you would like.

[sdmaclea]

What about the script option? Sounds like they should change to

• -buildTargetSpecific
• -buildTargetGeneric

or

• -targetSpecific
• -targetGeneric

[ivdiazsa]

I agree with @jkoritzinsky's suggestions. Other than that, LGTM! I'm assuming the test lists building would be done in a separate PR?

[ivdiazsa]

What about the script option? Sounds like they should change to

-buildTargetSpecific
-buildTargetGeneric

or

-targetSpecific
-targetGeneric

Both are fine by me. I would vote for the latter choices. Since the script is already called build-test, the former ones are a bit redundant.

[sdmaclea]

I'm assuming the test lists building would be done in a separate PR?

@VSadov Is working on generic filtering. I was assuming we would wait and see what he comes up with before engineering another solution,

[sdmaclea]

I made the renames per feedback.

I also did a quick benchmark of test building on my local Hyper-V Ubuntu machine. It took 10 minutes to build all the tests. When using testSpecific, the build time dropped to 3 minutes.

[sdmaclea]

quick benchmark - Windows results were about the same as Linux Hyper-V on the same machine.