Port Native libraries to SunOS

[am11]

Summary of changes:

• Add Solaris filesystems in MountPoints.FormatInfo.
• Set supported linker options.
• Remove negative index from __c_static_assert__.
  • possesses ub per C spec and GCC errors out.
• Separate i/o calls to set speed, as cfsetspeed is not supported.
• Set terminal initial flags manually, as cfmakeraw is not supported.
• Introspection for netpacket/packet.h and net/if_arp.h headers.
  • preferred feature detection to avoid further platform detection.
• Add fopen fallback, as getmntinfo is not supported.
• Add introspection for non legacy statfs(2) prototype.
  • Only legacy statfs(2) with different prototype is supported, preferred way is to use libc's statvfs(3).
• Some RLIMIT_* resources are different/non-supported, mapped them accordingly.
• Add fallback for getgrouplist(3).

Contributes to: #4173.

[wfurt]

LGTM.

[wfurt]

On Linux, cfmakeraw shows without the IMAXBEL. It was really just convenience and I'm wondering if we can get away without the fork and always list all options. (that can be done later)

[am11]

Yes. I think three things can be simplified:

• cfmakeraw -> list of options
• cfsetspeed -> i/o speed separately
• statfs -> statvfs
  • former is kernel call, latter is libc standard function, and Solaris/Illumos is known to err to the libc functions generally, without sysctl(2) like Linux or sysctl(3) like BSD.

I wanted to keep changes simple for the first pass, however, can make these changes and simplify the PR. Wdyt, should we make these three now or postpone it until later?

[wfurt]

I would do it later. cc: @krwq

[wfurt]

same as above. cfsetspeed() is a 4.4BSD extension. We may use cfsetispeed and cfsetospeed on all platforms.

[am11]

I think this work item can have os-sunos and area-Infrastructure-libraries labels.

[ghost]

Tagging @safern, @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.

[am11]

Summary of changes:

• Add Solaris filesystems in MountPoints.FormatInfo.
• Set supported linker options.
• Remove negative index from __c_static_assert__.
  • possesses ub per C spec and GCC errors out.
• Separate i/o calls to set speed, as cfsetspeed is not supported.
• Set terminal initial flags manually, as cfmakeraw is not supported.
• Introspection for netpacket/packet.h and net/if_arp.h headers.
  • preferred feature detection to avoid further platform detection.
• Add fopen fallback, as getmntinfo is not supported.
• Add introspection for non legacy statfs(2) prototype.
  • Only legacy statfs(2) with different prototype is supported, preferred way is to use libc's statvfs(3).
• Some RLIMIT_* resources are different/non-supported, mapped them accordingly.
• Add fallback for getgrouplist(3).

Contributes to: #4173.

[wfurt]

LGTM.

[wfurt]

On Linux, cfmakeraw shows without the IMAXBEL. It was really just convenience and I'm wondering if we can get away without the fork and always list all options. (that can be done later)

[am11]

Yes. I think three things can be simplified:

• cfmakeraw -> list of options
• cfsetspeed -> i/o speed separately
• statfs -> statvfs
  • former is kernel call, latter is libc standard function, and Solaris/Illumos is known to err to the libc functions generally, without sysctl(2) like Linux or sysctl(3) like BSD.

I wanted to keep changes simple for the first pass, however, can make these changes and simplify the PR. Wdyt, should we make these three now or postpone it until later?

[wfurt]

I would do it later. cc: @krwq

[wfurt]

same as above. cfsetspeed() is a 4.4BSD extension. We may use cfsetispeed and cfsetospeed on all platforms.

[am11]

I think this work item can have os-sunos and area-Infrastructure-libraries labels.

[ghost]

Tagging @safern, @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.

[am11]

Summary of changes:

• Add Solaris filesystems in MountPoints.FormatInfo.
• Set supported linker options.
• Remove negative index from __c_static_assert__.
  • possesses ub per C spec and GCC errors out.
• Separate i/o calls to set speed, as cfsetspeed is not supported.
• Set terminal initial flags manually, as cfmakeraw is not supported.
• Introspection for netpacket/packet.h and net/if_arp.h headers.
  • preferred feature detection to avoid further platform detection.
• Add fopen fallback, as getmntinfo is not supported.
• Add introspection for non legacy statfs(2) prototype.
  • Only legacy statfs(2) with different prototype is supported, preferred way is to use libc's statvfs(3).
• Some RLIMIT_* resources are different/non-supported, mapped them accordingly.
• Add fallback for getgrouplist(3).

Contributes to: #4173.

[wfurt]

LGTM.

[wfurt]

On Linux, cfmakeraw shows without the IMAXBEL. It was really just convenience and I'm wondering if we can get away without the fork and always list all options. (that can be done later)

[am11]

Yes. I think three things can be simplified:

• cfmakeraw -> list of options
• cfsetspeed -> i/o speed separately
• statfs -> statvfs
  • former is kernel call, latter is libc standard function, and Solaris/Illumos is known to err to the libc functions generally, without sysctl(2) like Linux or sysctl(3) like BSD.

I wanted to keep changes simple for the first pass, however, can make these changes and simplify the PR. Wdyt, should we make these three now or postpone it until later?

[wfurt]

I would do it later. cc: @krwq

[wfurt]

same as above. cfsetspeed() is a 4.4BSD extension. We may use cfsetispeed and cfsetospeed on all platforms.

[am11]

I think this work item can have os-sunos and area-Infrastructure-libraries labels.

[ghost]

Tagging @safern, @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.

[am11]

Summary of changes:

• Add Solaris filesystems in MountPoints.FormatInfo.
• Set supported linker options.
• Remove negative index from __c_static_assert__.
  • possesses ub per C spec and GCC errors out.
• Separate i/o calls to set speed, as cfsetspeed is not supported.
• Set terminal initial flags manually, as cfmakeraw is not supported.
• Introspection for netpacket/packet.h and net/if_arp.h headers.
  • preferred feature detection to avoid further platform detection.
• Add fopen fallback, as getmntinfo is not supported.
• Add introspection for non legacy statfs(2) prototype.
  • Only legacy statfs(2) with different prototype is supported, preferred way is to use libc's statvfs(3).
• Some RLIMIT_* resources are different/non-supported, mapped them accordingly.
• Add fallback for getgrouplist(3).

Contributes to: #4173.

[wfurt]

LGTM.

[wfurt]

On Linux, cfmakeraw shows without the IMAXBEL. It was really just convenience and I'm wondering if we can get away without the fork and always list all options. (that can be done later)

[am11]

Yes. I think three things can be simplified:

• cfmakeraw -> list of options
• cfsetspeed -> i/o speed separately
• statfs -> statvfs
  • former is kernel call, latter is libc standard function, and Solaris/Illumos is known to err to the libc functions generally, without sysctl(2) like Linux or sysctl(3) like BSD.

I wanted to keep changes simple for the first pass, however, can make these changes and simplify the PR. Wdyt, should we make these three now or postpone it until later?

[wfurt]

I would do it later. cc: @krwq

[wfurt]

same as above. cfsetspeed() is a 4.4BSD extension. We may use cfsetispeed and cfsetospeed on all platforms.

[am11]

I think this work item can have os-sunos and area-Infrastructure-libraries labels.

[ghost]

Tagging @safern, @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.

[am11]

Summary of changes:

• Add Solaris filesystems in MountPoints.FormatInfo.
• Set supported linker options.
• Remove negative index from __c_static_assert__.
  • possesses ub per C spec and GCC errors out.
• Separate i/o calls to set speed, as cfsetspeed is not supported.
• Set terminal initial flags manually, as cfmakeraw is not supported.
• Introspection for netpacket/packet.h and net/if_arp.h headers.
  • preferred feature detection to avoid further platform detection.
• Add fopen fallback, as getmntinfo is not supported.
• Add introspection for non legacy statfs(2) prototype.
  • Only legacy statfs(2) with different prototype is supported, preferred way is to use libc's statvfs(3).
• Some RLIMIT_* resources are different/non-supported, mapped them accordingly.
• Add fallback for getgrouplist(3).

Contributes to: #4173.

[wfurt]

LGTM.

[wfurt]

On Linux, cfmakeraw shows without the IMAXBEL. It was really just convenience and I'm wondering if we can get away without the fork and always list all options. (that can be done later)

[am11]

Yes. I think three things can be simplified:

• cfmakeraw -> list of options
• cfsetspeed -> i/o speed separately
• statfs -> statvfs
  • former is kernel call, latter is libc standard function, and Solaris/Illumos is known to err to the libc functions generally, without sysctl(2) like Linux or sysctl(3) like BSD.

I wanted to keep changes simple for the first pass, however, can make these changes and simplify the PR. Wdyt, should we make these three now or postpone it until later?

[wfurt]

I would do it later. cc: @krwq

[wfurt]

same as above. cfsetspeed() is a 4.4BSD extension. We may use cfsetispeed and cfsetospeed on all platforms.

[am11]

I think this work item can have os-sunos and area-Infrastructure-libraries labels.

[ghost]

Tagging @safern, @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.

[am11]

Summary of changes:

• Add Solaris filesystems in MountPoints.FormatInfo.
• Set supported linker options.
• Remove negative index from __c_static_assert__.
  • possesses ub per C spec and GCC errors out.
• Separate i/o calls to set speed, as cfsetspeed is not supported.
• Set terminal initial flags manually, as cfmakeraw is not supported.
• Introspection for netpacket/packet.h and net/if_arp.h headers.
  • preferred feature detection to avoid further platform detection.
• Add fopen fallback, as getmntinfo is not supported.
• Add introspection for non legacy statfs(2) prototype.
  • Only legacy statfs(2) with different prototype is supported, preferred way is to use libc's statvfs(3).
• Some RLIMIT_* resources are different/non-supported, mapped them accordingly.
• Add fallback for getgrouplist(3).

Contributes to: #4173.

[wfurt]

LGTM.

[wfurt]

On Linux, cfmakeraw shows without the IMAXBEL. It was really just convenience and I'm wondering if we can get away without the fork and always list all options. (that can be done later)

[am11]

Yes. I think three things can be simplified:

• cfmakeraw -> list of options
• cfsetspeed -> i/o speed separately
• statfs -> statvfs
  • former is kernel call, latter is libc standard function, and Solaris/Illumos is known to err to the libc functions generally, without sysctl(2) like Linux or sysctl(3) like BSD.

I wanted to keep changes simple for the first pass, however, can make these changes and simplify the PR. Wdyt, should we make these three now or postpone it until later?

[wfurt]

I would do it later. cc: @krwq

[wfurt]

same as above. cfsetspeed() is a 4.4BSD extension. We may use cfsetispeed and cfsetospeed on all platforms.

[am11]

I think this work item can have os-sunos and area-Infrastructure-libraries labels.

[ghost]

Tagging @safern, @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.

[am11]

Summary of changes:

• Add Solaris filesystems in MountPoints.FormatInfo.
• Set supported linker options.
• Remove negative index from __c_static_assert__.
  • possesses ub per C spec and GCC errors out.
• Separate i/o calls to set speed, as cfsetspeed is not supported.
• Set terminal initial flags manually, as cfmakeraw is not supported.
• Introspection for netpacket/packet.h and net/if_arp.h headers.
  • preferred feature detection to avoid further platform detection.
• Add fopen fallback, as getmntinfo is not supported.
• Add introspection for non legacy statfs(2) prototype.
  • Only legacy statfs(2) with different prototype is supported, preferred way is to use libc's statvfs(3).
• Some RLIMIT_* resources are different/non-supported, mapped them accordingly.
• Add fallback for getgrouplist(3).

Contributes to: #4173.

[wfurt]

LGTM.

[wfurt]

On Linux, cfmakeraw shows without the IMAXBEL. It was really just convenience and I'm wondering if we can get away without the fork and always list all options. (that can be done later)

[am11]

Yes. I think three things can be simplified:

• cfmakeraw -> list of options
• cfsetspeed -> i/o speed separately
• statfs -> statvfs
  • former is kernel call, latter is libc standard function, and Solaris/Illumos is known to err to the libc functions generally, without sysctl(2) like Linux or sysctl(3) like BSD.

I wanted to keep changes simple for the first pass, however, can make these changes and simplify the PR. Wdyt, should we make these three now or postpone it until later?

[wfurt]

I would do it later. cc: @krwq

[wfurt]

same as above. cfsetspeed() is a 4.4BSD extension. We may use cfsetispeed and cfsetospeed on all platforms.

[am11]

I think this work item can have os-sunos and area-Infrastructure-libraries labels.

[ghost]

Tagging @safern, @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.

[am11]

Summary of changes:

• Add Solaris filesystems in MountPoints.FormatInfo.
• Set supported linker options.
• Remove negative index from __c_static_assert__.
  • possesses ub per C spec and GCC errors out.
• Separate i/o calls to set speed, as cfsetspeed is not supported.
• Set terminal initial flags manually, as cfmakeraw is not supported.
• Introspection for netpacket/packet.h and net/if_arp.h headers.
  • preferred feature detection to avoid further platform detection.
• Add fopen fallback, as getmntinfo is not supported.
• Add introspection for non legacy statfs(2) prototype.
  • Only legacy statfs(2) with different prototype is supported, preferred way is to use libc's statvfs(3).
• Some RLIMIT_* resources are different/non-supported, mapped them accordingly.
• Add fallback for getgrouplist(3).

Contributes to: #4173.

[wfurt]

LGTM.

[wfurt]

On Linux, cfmakeraw shows without the IMAXBEL. It was really just convenience and I'm wondering if we can get away without the fork and always list all options. (that can be done later)

[am11]

Yes. I think three things can be simplified:

• cfmakeraw -> list of options
• cfsetspeed -> i/o speed separately
• statfs -> statvfs
  • former is kernel call, latter is libc standard function, and Solaris/Illumos is known to err to the libc functions generally, without sysctl(2) like Linux or sysctl(3) like BSD.

I wanted to keep changes simple for the first pass, however, can make these changes and simplify the PR. Wdyt, should we make these three now or postpone it until later?

[wfurt]

I would do it later. cc: @krwq

[wfurt]

same as above. cfsetspeed() is a 4.4BSD extension. We may use cfsetispeed and cfsetospeed on all platforms.

[am11]

I think this work item can have os-sunos and area-Infrastructure-libraries labels.

[ghost]

Tagging @safern, @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.