Skip to content

Use GDI+1.1 API set in Windows 8 and later - #35169

Merged
safern merged 5 commits into
dotnet:masterfrom
safern:SetGdi1.1
May 2, 2020
Merged

Use GDI+1.1 API set in Windows 8 and later#35169
safern merged 5 commits into
dotnet:masterfrom
safern:SetGdi1.1

Conversation

@safern

Copy link
Copy Markdown
Member

There are some bug fixes that we can benefit from using GDI+ 1.1 in Windows. An internal customer reported transforming from wmf to png files was messing up the image and after speaking with the GDI+ team they said it was because we were using the 1.0 API set. Said it shouldn't be a big difference but some fixes like this should be exposed by using the new API set.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @safern, @tannergooding
Notify danmosemsft if you want to be subscribed.

Comment threadsrc/libraries/System.Drawing.Common/src/System/Drawing/GdiplusNative.cs Outdated
Comment threadsrc/libraries/System.Drawing.Common/tests/GdiplusTests.cs Outdated
@safern

Copy link
Copy Markdown
MemberAuthor

This now depends on: dotnet/runtime-assets#72

Comment threadsrc/libraries/System.Drawing.Common/src/System/Drawing/GdiplusNative.cs Outdated
@safern

Copy link
Copy Markdown
MemberAuthor

Failures are: #35451 and #35752

@safern
safern merged commit 7bd9e4f into dotnet:masterMay 2, 2020
@safern
safern deleted the SetGdi1.1 branch May 2, 2020 19:58
@ghostghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@safern@danmoseley@jkotas@ericstj@tannergooding@Dotnet-GitSync-Bot