Uh oh!
There was an error while loading. Please reload this page.
Remove obsolete managedOsxBuild et. al - #35356
Conversation
ghost
commented
Apr 23, 2020
Tagging subscribers to this area: @ViktorHofer |
@trylek I assumed this is what you were looking for when you asked to clean up @naricc@directhex I am not sure if this will negatively impact Mono. I suspect I was too zealous with this and Mono needs to run test built for different arch, but I'll wait for feedback |
Remove managedOsxBuild Remove managedTestBuildOsGroup Remove managedTestBuildOsSubgroup
naricc
commented
Apr 24, 2020
I'm not sure if I appreciate what this PR does. What is managedTestBuildOsGroup/Subgroup vs OsGroup/Subgroup? What does removing it do? |
sdmaclea
commented
Apr 24, 2020
This was driven by @trylek comment
The PR he was referring to was splitting the build of AnyOS AnyCPU CoreCLR tests (
As I was removing this, I saw cases where Mono wasn't setting |
It seems like mono doesn't need this, so it should be ok to remove as far as mono builds go. |
trylek
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning this up!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ghost
commented
Apr 29, 2020
Hello @sdmaclea! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me ( |
Remove managedOsxBuild
Remove managedTestBuildOsGroup
Remove managedTestBuildOsSubgroup