Skip to content

Create CI Lane for Mono in Interpreter Mode running the runtime tests - #35648

Merged
naricc merged 15 commits into
dotnet:masterfrom
naricc:naricc/intepreter-ci
May 6, 2020
Merged

Create CI Lane for Mono in Interpreter Mode running the runtime tests#35648
naricc merged 15 commits into
dotnet:masterfrom
naricc:naricc/intepreter-ci

Conversation

@naricc

@nariccnaricc commented Apr 30, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Create CI Lane for Mono in Interpreter mode running the runtime tests. To do this we need to ensure that the environment variable MONO_ENV_OPTIONS contains "--interpreter" when running the tests.

@ghost

ghost commented Apr 30, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@naricc
naricc marked this pull request as ready for review May 1, 2020 21:33
@naricc
naricc requested review from ViktorHofer, akoeplinger, sacor, safern and trylek and removed request for sacorMay 1, 2020 21:33
safern
safern reviewed May 1, 2020
View reviewed changes
Comment threadeng/pipelines/common/templates/runtimes/run-test-job.yml
safern
safern reviewed May 1, 2020
View reviewed changes
Comment threadeng/pipelines/common/templates/runtimes/send-to-helix-step.yml Outdated
safern
safern reviewed May 1, 2020
View reviewed changes
Comment threadsrc/coreclr/tests/helixpublishwitharcade.proj Outdated
safern
safern reviewed May 2, 2020
View reviewed changes
Comment threadsrc/coreclr/tests/helixpublishwitharcade.proj Outdated
safern
safern reviewed May 2, 2020
View reviewed changes
Comment threadsrc/coreclr/tests/helixpublishwitharcade.proj
safern
safern reviewed May 2, 2020
View reviewed changes
Comment threadeng/pipelines/common/templates/runtimes/run-test-job.yml
@SamMonoRT

SamMonoRT commented May 5, 2020

Copy link
Copy Markdown
Member

LGTM - @safern any concerns before we can merge this ?

@safern

safern commented May 5, 2020

Copy link
Copy Markdown
Member

I’ll take a look in a few mins.

@jaredparjaredpar mentioned this pull request May 5, 2020
Closed
safern
safern reviewed May 5, 2020
View reviewed changes
Comment threadeng/pipelines/runtime.yml Outdated
safern
safern reviewed May 5, 2020
View reviewed changes
Comment threadsrc/coreclr/tests/helixpublishwitharcade.proj
safern
safern approved these changes May 5, 2020
View reviewed changes

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my two comments LGTM

@naricc
naricc merged commit d70a2a6 into dotnet:masterMay 6, 2020
@naricc
naricc deleted the naricc/intepreter-ci branch May 6, 2020 01:17
@sdmacleasdmaclea mentioned this pull request May 6, 2020
Merged
@ghostghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@safernsafernsafern approved these changes
@trylektrylekAwaiting requested review from trylek
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

No one assigned

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naricc@SamMonoRT@safern