Skip to content

Revert "Restore Seperate test builds, but fix broken pipe (#35378)" - #35696

Closed
echesakov wants to merge 1 commit into
dotnet:masterfrom
echesakov:Revert-PR-35378
Closed

Revert "Restore Seperate test builds, but fix broken pipe (#35378)"#35696
echesakov wants to merge 1 commit into
dotnet:masterfrom
echesakov:Revert-PR-35378

Conversation

@echesakov

@echesakovechesakov commented May 1, 2020

Copy link
Copy Markdown
Contributor

This reverts commit 6d64040.

@echesakovechesakov added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 1, 2020
@ghost

ghost commented May 1, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@hoyosjs

hoyosjs commented May 1, 2020

Copy link
Copy Markdown
Member

@echesakovMSFT looks like all workitems are back after this. Thanks!

@sdmaclea @dotnet/runtime-infrastructure

@sdmaclea

sdmaclea commented May 1, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

An explanation would be in order?
What workitems are missing?

@echesakov

echesakov commented May 1, 2020

Copy link
Copy Markdown
ContributorAuthor

An explanation would be in order?
What workitems are missing?

@sdmaclea The intention of this PR was to quick test whether #35378 has broke coreclr testing in terms of reduced number of Helix work items - I didn't want (and prefer not to) revert someone's changes. I am closing this since I see you have followed on this in #35699

@echesakov
echesakov deleted the Revert-PR-35378 branch May 1, 2020 17:06
@sdmaclea

sdmaclea commented May 1, 2020

Copy link
Copy Markdown
Contributor

@echesakovMSFT I initially assumed it had merged.

Not a problem. I just wanted to know what the issue was so that I could help with a/the fix.

Thanks

@jaredparjaredpar mentioned this pull request May 5, 2020
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area-InfrastructureNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@echesakov@hoyosjs@sdmaclea@Dotnet-GitSync-Bot