Skip to content

Use a different approach to optimize the indirect calls for R2R - #36712

Closed
kunalspathak wants to merge 1 commit into
dotnet:masterfrom
kunalspathak:3-adrp
Closed

Use a different approach to optimize the indirect calls for R2R#36712
kunalspathak wants to merge 1 commit into
dotnet:masterfrom
kunalspathak:3-adrp

Conversation

@kunalspathak

@kunalspathakkunalspathak commented May 19, 2020

Copy link
Copy Markdown
Contributor

During lowering, don't create a controlExpr for indirect call. Instead use
temp register for such calls and during codegen, load the indirect from x11
into that temp register before calling the address in that temp register.

@kunalspathak
Use a different approach to optimize the indirect calls for R2R
edcb6f1
During lowering, don't create a controlExpr for indirect call. Instead use
temp register for such calls and during codegen, load the indirect from x11
into that temp register before calling the address in that temp register.
@Dotnet-GitSync-BotDotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 19, 2020
@kunalspathakkunalspathak mentioned this pull request May 19, 2020
Merged
CarolEidt
CarolEidt approved these changes May 19, 2020
View reviewed changes

@CarolEidtCarolEidt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions

Comment threadsrc/coreclr/src/jit/codegenarmarch.cpp
Comment threadsrc/coreclr/src/jit/codegenarmarch.cpp
@kunalspathak

kunalspathak commented May 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Ported to #35675 and merged.

@ghostghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@CarolEidtCarolEidtCarolEidt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kunalspathak@CarolEidt@Dotnet-GitSync-Bot