Update Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk.

[jkoritzinsky]

Unblocks #36715

[ghost]

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

[ghost]

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[jkoritzinsky]

@chcosta I'm seeing failures here with uptaking dotnet/arcade#5442 and/or dotnet/arcade#5473

[jkoritzinsky]

Any chance you can take a look?

[jkoritzinsky]

It looks like the SharedFramework SDK doesn't gracefully fall back when EnableCreateLightCommandPackageDrop isn't set to true.

[chcosta]

Yikes, sorry about that. @jcagme, can you take a look?

[jcagme]

Yikes, sorry about that. @jcagme, can you take a look?

I have a rest of the day packed with meetings but I will take a look when I can for sure! @jkoritzinsky looks like setting EnableCreateLightCommandPackageDrop to true unblocked you?

[jkoritzinsky]

Yep! Setting it to true fixed the build thankfully. This bug will likely break uptake into dotnet/windowsdesktop as well.

[jcagme]

Could you please point me to the logs/errors you see when it is set to false?

[jkoritzinsky]

It’s not set by default anywhere that I could find. You need to explicitly set it to true currently.

[jcagme]

Yeah what I meant is that if you could share logs where this failed before enabled it.

[jkoritzinsky]

I've sent you a binlog in email.

[jkoritzinsky]

It looks like CI is failing, so we might not be out of the woods here yet.

[jkoritzinsky]

There's an additional race around creating the NonShipping packages folder. The LightCommandPackages paths assume that it already exists, which it might or might not depending on project build order.

[jkoritzinsky]

This is now blocked on an SDK update in dotnet/arcade#5552, which fixes the SDK issues found in this PR. If we can get that reviewed and merged in quickly, I'd highly appreciate it.