Skip to content

Add linux arm/arm64 libraries checked coreclr test runs - #36910

Merged
safern merged 3 commits into
dotnet:masterfrom
safern:LinuxArmLibsTestRuns
May 28, 2020
Merged

Add linux arm/arm64 libraries checked coreclr test runs#36910
safern merged 3 commits into
dotnet:masterfrom
safern:LinuxArmLibsTestRuns

Conversation

@safern

Copy link
Copy Markdown
Member

We should be running libraries tests on checked coreclr in arm/arm64 -- if we want to add these for mono as well, I'll let @naricc and @SamMonoRT to confirm... I can put up a follow up PR if needed.

This depends on: #36909

For more details: #36909 (comment)

cc: @dotnet/runtime-infrastructure @sdmaclea

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@jashook

Copy link
Copy Markdown
Contributor

Lets add one runtime at a time in case we hit capacity issues.

@safern

Copy link
Copy Markdown
MemberAuthor

Lets add one runtime at a time in case we hit capacity issues.

Makes sense.

@naricc

naricc commented May 23, 2020

Copy link
Copy Markdown
Contributor

I haven't actually been working on the libraries tests for mono, only the runtime tests, so I'm not sure if there is a reason they have not been enabled on arm64, although I think we will eventually want to. @EgorBo@steveisok Do you know?

@SamMonoRT

Copy link
Copy Markdown
Member

This is something we want to enable for Mono runtime too. This is being tracked via the first table in #33381@steveisok is tracking that work.

@jashook

Copy link
Copy Markdown
Contributor

@safern looks like there is a test that should be disabled?

@safern

Copy link
Copy Markdown
MemberAuthor

@safern looks like there is a test that should be disabled?

Yeah. I'll update the PR.

Also I think we should also include alpine_arm64, what do you think?

@sdmaclea

Copy link
Copy Markdown
Contributor

alpine_arm64 is apparently the only one which would have caught the libunwind regression.

@jkoritzinsky

Copy link
Copy Markdown
Member

We should definitely include an Alpine leg in PR runs if possible. We would have caught the issue with Alpine test runs using the dotnet CLI if we had an alpine run.

@jashook

Copy link
Copy Markdown
Contributor

Would this have been caught with alpine arm64 runtime tests?

@safern

Copy link
Copy Markdown
MemberAuthor

Would this have been caught with alpine arm64 runtime tests?

Yeah.

@jkoritzinsky

Copy link
Copy Markdown
Member

Actually, yes, that's where they would have been caught.

@jashook

Copy link
Copy Markdown
Contributor

That seems to be the larger issue then

@safern
safernforce-pushed the LinuxArmLibsTestRuns branch from 6ff7c64 to 0101947CompareMay 27, 2020 00:28
@safern

Copy link
Copy Markdown
MemberAuthor

@jashook looks good? In case this is green I'd like to merge.

@safern
safern merged commit 344085b into dotnet:masterMay 28, 2020
BruceForstall added a commit to BruceForstall/runtime that referenced this pull request Jul 30, 2020
Issue: dotnet#36910
See if this fails again in the CI
@BruceForstallBruceForstall mentioned this pull request Jul 30, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@safern@jashook@naricc@SamMonoRT@sdmaclea@jkoritzinsky@Dotnet-GitSync-Bot