Uh oh!
There was an error while loading. Please reload this page.
Add linux arm/arm64 libraries checked coreclr test runs - #36910
Conversation
ghost
commented
May 22, 2020
Tagging subscribers to this area: @ViktorHofer |
jashook
commented
May 22, 2020
Lets add one runtime at a time in case we hit capacity issues. |
safern
commented
May 23, 2020
Makes sense. |
I haven't actually been working on the libraries tests for mono, only the runtime tests, so I'm not sure if there is a reason they have not been enabled on arm64, although I think we will eventually want to. @EgorBo@steveisok Do you know? |
SamMonoRT
commented
May 26, 2020
This is something we want to enable for Mono runtime too. This is being tracked via the first table in #33381@steveisok is tracking that work. |
jashook
commented
May 26, 2020
@safern looks like there is a test that should be disabled? |
safern
commented
May 26, 2020
Yeah. I'll update the PR. Also I think we should also include alpine_arm64, what do you think? |
sdmaclea
commented
May 26, 2020
|
jkoritzinsky
commented
May 26, 2020
We should definitely include an Alpine leg in PR runs if possible. We would have caught the issue with Alpine test runs using the dotnet CLI if we had an alpine run. |
jashook
commented
May 26, 2020
Would this have been caught with alpine arm64 runtime tests? |
safern
commented
May 26, 2020
Yeah. |
jkoritzinsky
commented
May 26, 2020
Actually, yes, that's where they would have been caught. |
jashook
commented
May 26, 2020
That seems to be the larger issue then |
safern
commented
May 27, 2020
@jashook looks good? In case this is green I'd like to merge. |
Issue: dotnet#36910 See if this fails again in the CI
We should be running libraries tests on checked coreclr in arm/arm64 -- if we want to add these for mono as well, I'll let @naricc and @SamMonoRT to confirm... I can put up a follow up PR if needed.
This depends on: #36909
For more details: #36909 (comment)
cc: @dotnet/runtime-infrastructure @sdmaclea