Uh oh!
There was an error while loading. Please reload this page.
[Automated PR] master -> dev/infrastucture - #37086
Merged
Merged
Conversation
Large-bubble composite images are special in having more entries in the manifest metadata than in the component assembly table: When the build starts, all component assemblies get hard-injected into the manifest metadata and subsequently we lazily add those additional reference assemblies (within the same version bubble) as we need for encoding signatures. Thanks Tomas
It's no longer used.
…net/xharness (dotnet#36336) * Update dependencies from https://github.com/mono/linker build 20200512.1 - Microsoft.NET.ILLink.Tasks: 5.0.0-preview.3.20261.2 -> 5.0.0-preview.3.20262.1 * Update dependencies from https://github.com/dotnet/llvm-project build 20200512.1 - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: 6.0.1-alpha.1.20261.3 -> 9.0.1-alpha.1.20262.1 - runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: 6.0.1-alpha.1.20261.3 -> 9.0.1-alpha.1.20262.1 - runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: 6.0.1-alpha.1.20261.3 -> 9.0.1-alpha.1.20262.1 - runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: 6.0.1-alpha.1.20261.3 -> 9.0.1-alpha.1.20262.1 - runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: 6.0.1-alpha.1.20261.3 -> 9.0.1-alpha.1.20262.1 - runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: 6.0.1-alpha.1.20261.3 -> 9.0.1-alpha.1.20262.1 * Update dependencies from https://github.com/dotnet/xharness build 20200513.4 - Microsoft.DotNet.XHarness.Tests.Runners: 1.0.0-prerelease.20261.4 -> 1.0.0-prerelease.20263.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…t#36420) This test is optimization sensitive, but it invokes a subprocess that will inherit environment variables like `COMPlus_JITMinOpts` that can impact optimization of code jitted in the subprocess and cause the test to fail. So, update the parent process code to override `COMPlus_JITMinOpts` and `COMPlus_JitStress` for the child process. Closesdotnet#35742.
* Implement `GetEntrypointExecutableAbsolutePath`. * Fix a warning from newer gawk (v5.0.1 from 2019): > ```sh > awk: /runtime/src/coreclr/src/nativeresources/processrc.awk:54: > warning: regexp escape sequence `\"' is not a known regexp operator > ```
``` /Users/alexander/dev/runtime/src/mono/mono/mini/aot-runtime.c:5647:13: warning: unused variable 'image' [-Wunused-variable] /Users/alexander/dev/runtime/src/mono/mono/mini/simd-intrinsics-netcore.c:11:1: warning: no previous prototype for function 'mono_simd_intrinsics_init' [-Wmissing-prototypes] /Users/alexander/dev/runtime/src/mono/mono/utils/mono-state.c:1230:1: warning: no previous prototype for function 'mono_crash_save_failfast_msg' [-Wmissing-prototypes] /Users/alexander/dev/runtime/src/mono/mono/utils/mono-state.c:1236:1: warning: no previous prototype for function 'mono_crash_get_failfast_msg' [-Wmissing-prototypes] ```
) * Update windows prerequisites to be more specific about SDK * Global installation of nightly SDK is required to normally browse the solution files in VS, as there is no way to supply SDKs when the solution files are opened through VS. * Update windows prerequisites * allow newer versions of VS workloads
Removing some asserts and returning err_invalid_argument with an error message when it's possible. Fixesmono/mono#19651 Co-authored-by: thaystg <thaystg@users.noreply.github.com>
See mono/mono#19393. We can use the `-Werror=partial-availability` as a good alternative until the Xcode bug is fixed.
Consolidating subset projects into a single ProjectToBuild item type to allow specifying projects to build from different subsets after the subset was already built.
…arness (dotnet#36445) * Update dependencies from https://github.com/dotnet/arcade build 20200511.9 Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.GenFacades From Version 5.0.0-beta.20258.8 -> To Version 5.0.0-beta.20261.9 * Update dependencies from https://github.com/mono/linker build 20200514.1 Microsoft.NET.ILLink.Tasks From Version 5.0.0-preview.3.20262.1 -> To Version 5.0.0-preview.3.20264.1 * Update dependencies from https://github.com/dotnet/xharness build 20200514.1 Microsoft.DotNet.XHarness.Tests.Runners From Version 1.0.0-prerelease.20263.4 -> To Version 1.0.0-prerelease.20264.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Expand the name/OID table to support a m:m relationship (secp256r1 and nistP256 are both 1.2.840.10045.3.1.7; 1.3.14.7.2.3.1 and 1.2.840.113549.1.1.4 are both md5RSA) and add in the alternative names for the secp{size}r1 curves (size in 256, 384, 521).This works around Ubuntu's apparent lack of NO_ATEXIT support in their build of OpenSSL.
* Shrink Android apk size * bump xharness cli, use cmake config
* Update linux-instructions.md to use root build.sh
Fixesdotnet#36255 Depprojs depend on IntermediateOutputPath being set in a props file early enough as restore is happening per configuration. Even though it isn't recommended that the TargetFramework property is read before the project is loaded, we currently encode the TargetFramework in the IntermediateOutputPath for depproj files. The long-term fix is to get rid of per configuration restores by getting rid of our depproj files.
* [mono] Record MonoNativeThreadId of the main thread We would like to know the MonoNativeThreadId (pthread_t on Linux) of the main thread of the application. We can identify the main thread (on linux) because it is the one for which `gettid () == getpid ()`. (`gettid()` returns a `pid_t` which is not the same thing as a `pthread_t`, hence this roundabout way of detecting it.) A complication arises in embedding scenarios: the main thread is not necessarily the one that calls `mono_jit_init` or otherwise interacts with the runtime. Therefore we do the `gettid() == getpid ()` test at `MonoThreadInfo` creation time when we call `register_thread`. If the main thread never interacts with Mono, the main thread is not known to us. * [mono] Don't set name of main thread on Linux Setting the name of the main thread also changes the name of the process. Fixesdotnet#35908 The corresponding fix for CoreCLR is dotnet#34064 * Re-enable test from dotnet#34064
…#36446) During my work on fixing runtime crashes in composite build with large version bubble enabled I noticed room for startup perf improvement and a very slight working set optimization: For component assemblies of a composite image, we can basically share the cache of those manifest assembly references that have already been resolved (GetNativeMetadataAssemblyRefFromCache) within the native image because that is the logical owner of the manifest metadata. In the "asymptotic" case of composite images with many components, the pre-existing behavior was basically a quadratic O(n^2) algorithm in the number of component assemblies. This change reduces it to linear in the sense that all assembly references from the composite image get resolved only once. Thanks Tomas
…6156) * ARM64 intrisic for ToScalar() and GetElement() * Fixed GetElement to just operate on constants * Fix bug in rationalize for Vector64<long> * fix NotSupported issue for GetElement and ToScalar * Reuse the baseType/retType in impSpecialIntrinsic and impBaseIntrinsic * Update comment * fix breaks * add comments * ran jit-format * Refactored to move common logic inside isSupportedBaseType * review comments * reuse simdSize * formatting * one missing formatting
- Allow accessing a SIMD12 as 16 bytes if it's the single field of a parent struct of 16 bytes. - On x64/ux don't copy an argument just because it is promoted; the copy would force it to memory anyway. - Use block init for a promoted struct that's been marked lvDoNotEnregister. - Allow field-by-field copy of structs with the same fields
* Issue 36212: Remove space in parameter name * Update src/coreclr/src/vm/comutilnative.cpp Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
Allow compiling composite R2R images which reference assemblies not in the composite. For example, this would allow compiling a set of application assemblies with references to ASP.NET / Framework. Currently R2RTest treats all references as unrooted inputs for the composite image.
* more * commented * yml * Add an issue template for API proposals * Update .github/ISSUE_TEMPLATE/api-proposal.md Co-authored-by: Stephen Toub <stoub@microsoft.com> * Update .github/ISSUE_TEMPLATE/api-proposal.md Co-authored-by: Stephen Toub <stoub@microsoft.com> * Update .github/ISSUE_TEMPLATE/api-proposal.md Co-authored-by: Stephen Toub <stoub@microsoft.com> * comment out template instructions * apply consistent naming * feedback * add blank * H2 and H3 Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Add options to ignore default values during serialization * Address review feedback * Fix typo in test
jashook
requested review from
sdmaclea and trylek
and removed request for
BrzVlad, CoffeeFlux, EgorBo, SamMonoRT, akoeplinger, alexischr, imhameed, jozkee, lambdageek, lateralusX, layomia, marek-safar, steveharter, steveisok, thaystg and vargazMay 27, 2020 20:17
sdmaclea
approved these changes
May 27, 2020
sdmaclea
left a comment
Contributor
There was a problem hiding this comment.
I just get unicorns when I try to look at the list of commits.
I was wondering whether there was a merge commit in the list so the next merge isn't more painful.
Other than that I am assuming this was generated automatically and represents the master branch accurately.
trylek
approved these changes
May 27, 2020
trylek
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for doing the integration!
jashook
commented
May 27, 2020
ContributorAuthor
03469b5 has the commit fixing the merge conflicts |
sdmaclea
commented
May 29, 2020
Contributor
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr has been created automatically.