[browser][wasm] Implement JavaScript managed object reference counting by kjpou1 · Pull Request #37417 · dotnet/runtime

kjpou1 · 2020-06-04T13:53:45Z

Wrap the javascript handle in a SafeHandleZeroOrMinusOneIsInvalid implementation.

AnyRef
- Modify AnyRef to be abstract and deriving from SafeHandleZeroOrMinusOneIsInvalid
- Add extra parameter for ownsHandle
- The GCHandle.Alloc creates a normal allocation or a weak allocation depending on the ownsHandle value passed.
  - true - GCHandleType.Weak
  - false - GCHandleType.Normal
JSObject
- Implements ReleaseHandle that is overridden from AnyRef
- This removes the Dispose and Finalizers definitions from the objects. This will be taken care of by AnyRef which derives from SafeHandleZeroOrMinusOneIsInvalid
- Add extra parameter for ownsHandle
Runtime
- The _boundObjects dictionary that tracks all the objects that have been bound from JavaScript objects to managed code is now a WeakReference.
- Implement methods for obtaining a handle, adding a reference to a handle and releasing a handle. These are called from the javascript binding_support lib.
- Refactored the releasing a JSObject.
  - Involved multiple calls to the bindings and managed code.
  - Streamlined to only call the bindings code once to free handles.

Add support for marshaling the `AnyRef` SafeHandle.

When calling into the bindings from managed code the JSObject reference handle is incremented.
After execution of the call the JSObject reference is decremented.
Special processing for the GlobalObject where the object is set with ownsHandle = false so that it is not released.
Release reference counts on javascript exceptions.

Support freeing delegates marshaled to the bindings.

Every delegate that was passed to the bindings code was kept forever causing leaks.

Delegates are now not kept alive when GC'd.
Delegates using lambda expressions forced the developer to explicitly free the delegate.
- If a local is captured (used) by a lambda it becomes heap memory as we translate them into fields on an object.
- A delegate that used lambda expressions was never collected and never released the heap so it could be collected.
- This was a cause of memory leaks forcing the developer to explicitly call FreeObject (foreachAction);
If a delegate is collected and the javascript code calls that delegate function an exception is thrown instead of inexplicably crashing with null exception error.
- throw new Error("The delegate target that is being invoked is no longer available. Please check if it has been prematurely GC'd.");
- Uncaught Error: The delegate target that is being invoked is no longer available. Please check if it has been prematurely GC'd.

- This still needs to have the code implement nullable

…http-interop # Conflicts: # src/libraries/System.Net.Http/src/System.Net.Http.csproj

…ting format

- Throws `PlatformNotSupportedException` for properties and methods of the HttpMessageHandler abstract implementation.

- Addresses commit comments.

…http-interop

- For all of these vars, please replace them with the actual type, except when the type is obvious from a new or explicit cast on the right-hand side.

- Address review comments

Co-Authored-By: Marek Safar <marek.safar@gmail.com>

…reference-counting # Conflicts: # src/libraries/System.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/AnyRef.cs # src/libraries/System.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Runtime.cs

…dency attribute

marek-safar · 2020-06-11T07:13:08Z

+ }
+ else
+ {
+ Console.WriteLine($"\tSafeHandleReleaseByHandle: did not find active target {jsId} / target: {reference.Target}");


Why are these not asserts?

kjpou1and others added 30 commits April 28, 2020 12:15

Add Browser specific files to the project
d17e863

Browser specific file modification to not include Quic support
aafa4b0

Add Browser specific support files for Http Handler code
7d52436

Add Interop code for JavaScript support
242ade6

Remove unused reference
2ca93d8

Add Http handler bindings implementation
ab0e0de
- This still needs to have the code implement nullable

Nullable support
bc39563

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto wasm-…
b60ee5b
…http-interop # Conflicts: # src/libraries/System.Net.Http/src/System.Net.Http.csproj

Add browser files back after upstream merge conflict
92f74c4

Use attribute Link syntax for Common files to bring in sync with exis…
a9248de
…ting format

Address Missing license header
dc82e45

Code formatting and removal of comment code.
cc70c9f

Address PR comments.
c96a6f1

Address commit comments
bb9ff24

Add blank line between License and first line of code. Address comments
2f7ace0

Replace SocketsHttpHandler build for Browser.
ced6437
- Throws `PlatformNotSupportedException` for properties and methods of the HttpMessageHandler abstract implementation.

Cleanup SendAsync code when doing the call out to JavaScript Fetch.
5c89333
- Addresses commit comments.

Refactor BrowserHttpHandler code.
4eb5dd1

Cleanup
d5360b6

Remove null check as it should be checked in outer classes
d1b537d

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto wasm-…
39947b1
…http-interop

Cleanup var usage to use explicit type. Address commit comments
2d8e124
- For all of these vars, please replace them with the actual type, except when the type is obvious from a new or explicit cast on the right-hand side.

Move .ConfigureAwait(true) to .ConfigureAwait(false)
d443cfd
- Address review comments

Change accessor of Runtime javascript interop methods.
0d63762

Change accessor of Runtime javascript interop methods.
a91637c

Address review comments for unused code
cdbbf0f

Cleanup leftover debug WriteLines
5814d1d

Remove the AllowNull attributes as per review comments.
146b6d7

Update src/libraries/Common/src/Interop/Browser/Interop.Runtime.cs
1f510f4
Co-Authored-By: Marek Safar <marek.safar@gmail.com>

throw different exception type as per review comment
90b83f6

jkotas reviewed Jun 9, 2020
View reviewed changes

Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/AnyRef.cs Outdated

jkotas reviewed Jun 9, 2020
View reviewed changes

Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/AnyRef.cs Outdated

jkotas reviewed Jun 9, 2020
View reviewed changes

Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/AnyRef.cs

jkotas reviewed Jun 9, 2020
View reviewed changes

Comment thread....Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Runtime.cs Outdated

kjpou1 requested a review from jkotas June 10, 2020 07:35

Clean up
5377cd9

marek-safar requested changes Jun 10, 2020
View reviewed changes

kjpou1 added 6 commits June 10, 2020 12:09

Fix delegate code and address review comments
67330f1

Code clean up and change accessor on AnyRefHandle
acdf5e6

Move outside block
ed308a3

Remove unused method
05b0371

Remove nullable type from dictionary
2749f18

Remove comments
403bedd

kjpou1 requested a review from marek-safar June 10, 2020 12:45

kjpou1 added 3 commits June 10, 2020 15:40

Marking methods with Linker-friendly reflection by using DynamicDepen…
51e66a3
…dency attribute

address redundant using
4cc6fb4

Address lock review comment
31c640f

marek-safar reviewed Jun 10, 2020
View reviewed changes

kjpou1 added 2 commits June 11, 2020 06:31

Address review comments
2743369

remove nullable code
08a05cd

marek-safar reviewed Jun 11, 2020
View reviewed changes

kjpou1 added 3 commits June 11, 2020 12:52

Address review comments
9cee16a

Add Debug.Assert to address review comment
d504b30

Address assert comments and code formatting
9e74013

marek-safar approved these changes Jun 11, 2020
View reviewed changes

kjpou1 merged commit 208bce9 into dotnet:masterJun 12, 2020

kjpou1 mentioned this pull request Jun 13, 2020
[browser][wasm] Implement JavaScript managed object reference counting #37151
Closed

kjpou1 deleted the wasm-reference-counting branch June 16, 2020 04:56

ghost locked as resolved and limited conversation to collaborators Dec 8, 2020

Uh oh!

Conversation

kjpou1 commented Jun 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Wrap the javascript handle in a SafeHandleZeroOrMinusOneIsInvalid implementation.

Add support for marshaling the AnyRef SafeHandle.

Support freeing delegates marshaled to the bindings.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marek-safarJun 11, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kjpou1 commented Jun 4, 2020•
edited
Loading

Add support for marshaling the `AnyRef` SafeHandle.