Uh oh!
There was an error while loading. Please reload this page.
Enable nullable reference types for full facades - #37589
Merged
Merged
Conversation
ghost
commented
Jun 8, 2020
Tagging subscribers to this area: @ViktorHofer |
stephentoubforce-pushed
the
nullablefullfacades
branch
2 times, most recently
from
June 8, 2020 14:49
e871d63 to
bdbb489Comparestephentoubforce-pushed
the
nullablefullfacades
branch
from
June 8, 2020 19:52
bdbb489 to
5c903f3CompareSome of our full facades are missing `<Nullable>enable</Nullable>`. I don't think the lack of these causes any issues, but having them makes it easy to confirm what ref assemblies remain to be annotated.
stephentoubforce-pushed
the
nullablefullfacades
branch
from
June 9, 2020 00:13
5c903f3 to
73abb7fCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our full facades are missing
<Nullable>enable</Nullable>. I don't think the lack of these causes any issues, but having them makes it easy to confirm what ref assemblies remain to be annotated.Contributes to #2339
cc: @buyaa-n