Skip to content

Port EventPipeBuffer, EventPipeBufferList, EventPipeBufferManager to Mono. - #37756

Merged
lateralusX merged 1 commit into
dotnet:masterfrom
lateralusX:lateralusX/eventpipe-buffer-manager
Jun 30, 2020
Merged

Port EventPipeBuffer, EventPipeBufferList, EventPipeBufferManager to Mono.#37756
lateralusX merged 1 commit into
dotnet:masterfrom
lateralusX:lateralusX/eventpipe-buffer-manager

Conversation

@lateralusX

@lateralusXlateralusX commented Jun 11, 2020

Copy link
Copy Markdown
Member

Continuation of #34600, adding BufferManager into the library including unit tests, merging source files and additional library restructuring.

  • Port EventPipeBuffer.
  • Port EventPipeBufferList.
  • Port EventPipeManager.
  • Merge internals source files. Changed GETTER_SETTER to only mandate use of inlined functions when calling betweeen source files for different types. Upgraded all use within each source file for direct struct access.
  • Changed function entry error checkin strategy. Only apply active checks on outer library API, ep.h, and use EP_ASSERT for all other functions.
  • Dropped requires_lock_held in function naming, switch to comment in header or in forward declare for functions that validates that lock is held.
  • Removed currently unused GETTER/SETTERS.
  • Moved more comments into sources from corresponding CoreCLR EventPipe sources.
  • Add EventPipeBuffer/EventPipeBufferManager unit tests.

Next step after this PR will be to enable a file session during runtime and add more unit tests and then start getting diagnostic server component over to Mono.

@monojenkinsmonojenkins mentioned this pull request Jun 11, 2020
Merged
@josalem

josalem commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

CC - @noahfalk@sywhang

@lateralusXlateralusX mentioned this pull request Jun 12, 2020
Merged
@lateralusX
lateralusXforce-pushed the lateralusX/eventpipe-buffer-manager branch 2 times, most recently from 70dc7b0 to 946f9e0CompareJune 12, 2020 14:58
@jaredparjaredpar mentioned this pull request Jun 12, 2020
Closed
@lambdageeklambdageek mentioned this pull request Jun 15, 2020
Closed
@lateralusX
lateralusXforce-pushed the lateralusX/eventpipe-buffer-manager branch from e55477d to 46233c6CompareJune 19, 2020 10:15
@lateralusXlateralusX changed the title WIP: Port EventPipeBuffer, EventPipeBufferList, EventPipeBufferManager to Mono.Port EventPipeBuffer, EventPipeBufferList, EventPipeBufferManager to Mono.Jun 22, 2020
lambdageek
lambdageek approved these changes Jun 26, 2020
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I did have a couple of questions.

Comment threadsrc/mono/mono/eventpipe/ep.c Outdated
Comment threadsrc/mono/mono/eventpipe/ep.c Outdated
Comment threadsrc/mono/mono/mini/mini-runtime.c Outdated
Comment threadsrc/mono/mono/eventpipe/ep-event-source.c Outdated
Comment threadsrc/mono/mono/eventpipe/ep-event-source.c Outdated
Comment threadsrc/mono/mono/eventpipe/ep-rt-mono.h Outdated
Comment threadsrc/mono/mono/eventpipe/ep-rt-mono.h Outdated
Comment threadsrc/mono/mono/eventpipe/ep-config.h Outdated
@lateralusX
lateralusXforce-pushed the lateralusX/eventpipe-buffer-manager branch from 46233c6 to db9feefCompareJune 29, 2020 11:05
@lateralusX
lateralusX marked this pull request as ready for review June 29, 2020 11:21
@jaredparjaredpar mentioned this pull request Jun 29, 2020
Closed
@lambdageek

lambdageek commented Jun 29, 2020•
edited
Loading

Copy link
Copy Markdown
Member

(now disabled) WASM failure is due to #38573

@lateralusX
Port EventPipeBuffer, EventPipeBufferList, EventPipeBufferManager to …
998e2ad
…Mono.
* Port EventPipeBuffer.
* Port EventPipeBufferList.
* Port EventPipeManager.
* Merge internals source files. Changed GETTER_SETTER to only mandate use
of inlined functions when calling betweeen source files for different types.
Upgraded all use within each source file for direct struct access.
* Changed function entry error checkin strategy. Only apply active checks
on outer library API, ep.h, and use EP_ASSERT for all other functions.
* Dropped requires_lock_held in function naming, switch to comment in header
or in forward declare for functions that validates that lock is held.
* Removed currently unused GETTER/SETTERS.
* Moved more comments into sources from corresponding CoreCLR EventPipe
sources.
* Add EventPipeBuffer/EventPipeBufferManager unit tests.
* Align to changes in native CoreCLR eventpipe* sources.
* Add support starting default file session using env variables.
* Disable eventpipe callback on WASM due to platform issues with delegates.
@lateralusX
lateralusXforce-pushed the lateralusX/eventpipe-buffer-manager branch from 8df489a to 998e2adCompareJune 29, 2020 20:27
@lateralusX
lateralusX merged commit 3e0a169 into dotnet:masterJun 30, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@kgkgAwaiting requested review from kg
@marek-safarmarek-safarAwaiting requested review from marek-safar
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz

Assignees

No one assigned

Labels

area-Tracing-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lateralusX@josalem@lambdageek@Dotnet-GitSync-Bot