Make test libraries configuration agnostic

[safern]

In order to be able to build tests in one configuration and then use a shared framework that was built against another configuration we need to make our tests to test for specific behavior with an ||.

If this could introduce bugs where a Release code could be returning valid values for Debug but that's wrong, I'm happy to change this to do runtime checks instead, anyway we should not be testing framework configuration specific behavior based on the configuration the tests were built.

For Contracts tests, I did leave Configuration dependency, as that depends on what the test assembly was built against but not what shared framework we're running on. So Debug test assembly should work on Release and Debug shared framework. Also if the test assembly is built for Release mode it should work on any shared framework.

[jkotas]

Is there a good reason to keep TRACE defined?

[safern]

It doesn't seem like it. From doing a grep, I saw that there are only a few usages of this constant, but the projects that use it, either define it on the files or on the csproj itself.

https://github.com/dotnet/runtime/blob/master/src/libraries/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceSource.cs#L175

Should we just remove those conditionals and defines? It seems like it is always defined, therefore, those methods are always available?

[jkotas]

Configuration dependency, as that depends on what the test assembly was built against

A better way to do this may be to #define the conditional symbol in specific files. Look for #define DEBUG in System.Diagnostics.Debug tests for prior art.

[jkotas]

I would scope this change to:

• Fixing all cases where debug build of the test fails on release build of the product, and vice versa. Are there any actually?
• Improving the coverage of release builds of the tests such as removing DEBUG ifdefs around test cases in StackTraceTests.cs

But I would keep DEBUG defined for debug builds of the tests.

[ViktorHofer]

But I would keep DEBUG defined for debug builds of the tests.

I gave this more thought as well and I agree with Jan that we shouldn't undefine DEBUG.

[safern]

Are there any actually?

Yeah there where a couple in some Diagnostics tests.

But I would keep DEBUG defined for debug builds of the tests.

Ok. I will work on that.

[safern]

@jkotas@ViktorHofer could you please take a look?

[safern]

Fixed all comments. Thanks for the review.

[ViktorHofer]

Thanks, LGTM.