JIT: allow inlinees with delegate invoke - #38479

Merged
jkotas merged 1 commit into
dotnet:masterfrom
AndyAyersMS:AllowInlineeDelegateInvoke
Jun 27, 2020
Merged

JIT: allow inlinees with delegate invoke#38479
jkotas merged 1 commit into
dotnet:masterfrom
AndyAyersMS:AllowInlineeDelegateInvoke

Conversation

@AndyAyersMS

@AndyAyersMSAndyAyersMS commented Jun 26, 2020

Copy link
Copy Markdown
Member

RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.

Closes#10048. See also #37941.

@AndyAyersMS
JIT: allow inlinees with delegate invoke
fa018bc
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closesdotnet#10048. See also dotnet#37941.
@Dotnet-GitSync-BotDotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 26, 2020
@AndyAyersMS

AndyAyersMS commented Jun 26, 2020

Copy link
Copy Markdown
MemberAuthor

@erozenfeld PTAL cc @dotnet/jit-contrib

jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining.

PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: 30147 (0.064% of base)
diff is a regression.
Top file regressions (bytes):
13367 : CommandLine.dasm (3.039% of base)
3272 : Microsoft.CodeAnalysis.dasm (0.189% of base)
2144 : System.Management.dasm (0.554% of base)
2091 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (0.069% of base)
1932 : System.Private.Xml.dasm (0.054% of base)
1252 : Microsoft.CodeAnalysis.VisualBasic.dasm (0.022% of base)
1134 : System.Net.Sockets.dasm (0.577% of base)
650 : System.Threading.Tasks.Dataflow.dasm (0.077% of base)
498 : Newtonsoft.Json.dasm (0.057% of base)
465 : System.Data.Common.dasm (0.031% of base)
449 : Microsoft.CodeAnalysis.CSharp.dasm (0.010% of base)
380 : System.Private.CoreLib.dasm (0.008% of base)
342 : xunit.execution.dotnet.dasm (0.147% of base)
295 : Microsoft.Extensions.Primitives.dasm (1.124% of base)
233 : System.Runtime.Serialization.Formatters.dasm (0.242% of base)
215 : System.Security.Cryptography.Primitives.dasm (0.616% of base)
200 : System.Private.DataContractSerialization.dasm (0.026% of base)
193 : Microsoft.Extensions.Http.dasm (0.446% of base)
144 : xunit.runner.utility.netcoreapp10.dasm (0.076% of base)
112 : xunit.console.dasm (0.129% of base)
36 total files with Code Size differences (0 improved, 36 regressed), 232 unchanged.
Top method regressions (bytes):
2742 (78.253% of base) : CommandLine.dasm - Trial:Collect(IEnumerable`1):Result`2 (7 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
2670 (49.739% of base) : CommandLine.dasm - ResultExtensions:Flatten(Result`2):Result`2 (7 methods)
643 (7.180% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,Func`2,Func`2,bool,int):HelpText (7 methods)
540 (22.213% of base) : CommandLine.dasm - Trial:Flatten(Result`2):Result`2 (7 methods)
531 (42.277% of base) : CommandLine.dasm - Trial:MergeMessages(IEnumerable`1,Result`2):Result`2 (7 methods)
478 (61.997% of base) : CommandLine.dasm - Tokenizer:PreprocessDashDash(IEnumerable`1,Func`2):Result`2
399 (23.596% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaIntoTrivia>d__161:MoveNext():bool:this
353 (14.143% of base) : Microsoft.CodeAnalysis.dasm - <DescendantNodesAndTokensIntoTrivia>d__159:MoveNext():bool:this
333 (19.692% of base) : System.Private.Xml.dasm - XmlSchemaValidator:ElementValidationError(XmlQualifiedName,ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
324 (14.093% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - TraceLog:FastSerialization.IFastSerializable.ToStream(Serializer):this
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
294 (25.610% of base) : CommandLine.dasm - <>c__DisplayClass17_0`1:<DisplayHelp>b__0(IEnumerable`1):this (7 methods)
284 (39.281% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetPreviousToken(SyntaxTrivia,SyntaxTriviaList,Func`2,Func`2,byref):SyntaxToken:this
273 (2.549% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,int):HelpText (7 methods)
264 (49.811% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetLastToken(SyntaxTriviaList,Func`2,Func`2):SyntaxToken:this
232 (6.080% of base) : System.Private.CoreLib.dasm - ArraySortHelper`1:IntroSort(Span`1,int,Comparison`1) (8 methods)
228 (11.639% of base) : System.Private.Xml.dasm - XmlWellFormedWriter:AdvanceStateAsync(int):Task:this
220 (16.165% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaOnly>d__160:MoveNext():bool:this
215 (22.142% of base) : System.Private.Xml.dasm - XmlSchemaValidator:CompleteValidationError(ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
Top method improvements (bytes):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
Top method regressions (percentages):
64 (914.286% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_f(Object)
64 (640.000% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_t(Object)
31 (620.000% of base) : System.Management.dasm - ManagementOptions:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
31 (387.500% of base) : System.Management.dasm - EventWatcherOptions:set_BlockSize(int):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnSerializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserialized(Object,StreamingContext):this
31 (281.818% of base) : System.Management.dasm - ManagementScope:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
43 (215.000% of base) : Microsoft.CSharp.dasm - UnsafeMethods:IUnknownReleaseNotZero(long)
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Impersonation(int):this
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Authentication(int):this
30 (136.364% of base) : System.Management.dasm - ConnectionOptions:set_EnablePrivileges(bool):this
75 (131.579% of base) : System.Net.Sockets.dasm - SocketPal:Disconnect(Socket,SafeSocketHandle,bool):int
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Map(Maybe`1,Func`2):Maybe`1 (7 methods)
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Select(Maybe`1,Func`2):Maybe`1 (7 methods)
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
36 (94.737% of base) : System.Management.dasm - ObjectGetOptions:set_UseAmendedQualifiers(bool):this
90 (90.000% of base) : CommandLine.dasm - MaybeExtensions:Bind(Maybe`1,Func`2):Maybe`1 (7 methods)
26 (89.655% of base) : System.Management.dasm - ManagementNamedValueCollection:Remove(String):this
Top method improvements (percentages):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
445 total methods with Code Size differences (3 improved, 442 regressed), 243053 unchanged.

@jkotas

jkotas commented Jun 27, 2020

Copy link
Copy Markdown
Member

Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers.

@BruceForstall

BruceForstall commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Where is the CommandLine assembly coming from?

It's whatever is in Core_Root:

ProductVersion 2.0.275
FileVersion 2.0.275.0
Comments Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments.

erozenfeld
erozenfeld approved these changes Jun 27, 2020
View reviewed changes

@erozenfelderozenfeld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulieLeeMSFTJulieLeeMSFT added this to the 5.0.0 milestone Jun 27, 2020
@jkotas
jkotas merged commit dd10afe into dotnet:masterJun 27, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
+2 more reviewers
@erozenfelderozenfelderozenfeld approved these changes
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Allow to inline methods with delegate invocation (at least methods marked with AggressiveInlining)

6 participants

@AndyAyersMS@jkotas@BruceForstall@erozenfeld@Dotnet-GitSync-Bot@JulieLeeMSFT
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
JIT: allow inlinees with delegate invoke - #38479
Merged
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Jun 27, 2020
Merged
JIT: allow inlinees with delegate invoke#38479
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

Member
RyuJit would not inline methods that contained delegate invokes. Remove

this limitation.
Closes#10048. See also #37941.
@AndyAyersMS
JIT: allow inlinees with delegate invoke
fa018bc
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closesdotnet#10048. See also dotnet#37941.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 26, 2020
@AndyAyersMS
AndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

MemberAuthor
@erozenfeld PTAL cc @dotnet/jit-contrib
jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining.
PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: 30147 (0.064% of base)
diff is a regression.
Top file regressions (bytes):
13367 : CommandLine.dasm (3.039% of base)
3272 : Microsoft.CodeAnalysis.dasm (0.189% of base)
2144 : System.Management.dasm (0.554% of base)
2091 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (0.069% of base)
1932 : System.Private.Xml.dasm (0.054% of base)
1252 : Microsoft.CodeAnalysis.VisualBasic.dasm (0.022% of base)
1134 : System.Net.Sockets.dasm (0.577% of base)
650 : System.Threading.Tasks.Dataflow.dasm (0.077% of base)
498 : Newtonsoft.Json.dasm (0.057% of base)
465 : System.Data.Common.dasm (0.031% of base)
449 : Microsoft.CodeAnalysis.CSharp.dasm (0.010% of base)
380 : System.Private.CoreLib.dasm (0.008% of base)
342 : xunit.execution.dotnet.dasm (0.147% of base)
295 : Microsoft.Extensions.Primitives.dasm (1.124% of base)
233 : System.Runtime.Serialization.Formatters.dasm (0.242% of base)
215 : System.Security.Cryptography.Primitives.dasm (0.616% of base)
200 : System.Private.DataContractSerialization.dasm (0.026% of base)
193 : Microsoft.Extensions.Http.dasm (0.446% of base)
144 : xunit.runner.utility.netcoreapp10.dasm (0.076% of base)
112 : xunit.console.dasm (0.129% of base)
36 total files with Code Size differences (0 improved, 36 regressed), 232 unchanged.
Top method regressions (bytes):
2742 (78.253% of base) : CommandLine.dasm - Trial:Collect(IEnumerable`1):Result`2 (7 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
2670 (49.739% of base) : CommandLine.dasm - ResultExtensions:Flatten(Result`2):Result`2 (7 methods)
643 (7.180% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,Func`2,Func`2,bool,int):HelpText (7 methods)
540 (22.213% of base) : CommandLine.dasm - Trial:Flatten(Result`2):Result`2 (7 methods)
531 (42.277% of base) : CommandLine.dasm - Trial:MergeMessages(IEnumerable`1,Result`2):Result`2 (7 methods)
478 (61.997% of base) : CommandLine.dasm - Tokenizer:PreprocessDashDash(IEnumerable`1,Func`2):Result`2
399 (23.596% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaIntoTrivia>d__161:MoveNext():bool:this
353 (14.143% of base) : Microsoft.CodeAnalysis.dasm - <DescendantNodesAndTokensIntoTrivia>d__159:MoveNext():bool:this
333 (19.692% of base) : System.Private.Xml.dasm - XmlSchemaValidator:ElementValidationError(XmlQualifiedName,ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
324 (14.093% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - TraceLog:FastSerialization.IFastSerializable.ToStream(Serializer):this
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
294 (25.610% of base) : CommandLine.dasm - <>c__DisplayClass17_0`1:<DisplayHelp>b__0(IEnumerable`1):this (7 methods)
284 (39.281% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetPreviousToken(SyntaxTrivia,SyntaxTriviaList,Func`2,Func`2,byref):SyntaxToken:this
273 (2.549% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,int):HelpText (7 methods)
264 (49.811% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetLastToken(SyntaxTriviaList,Func`2,Func`2):SyntaxToken:this
232 (6.080% of base) : System.Private.CoreLib.dasm - ArraySortHelper`1:IntroSort(Span`1,int,Comparison`1) (8 methods)
228 (11.639% of base) : System.Private.Xml.dasm - XmlWellFormedWriter:AdvanceStateAsync(int):Task:this
220 (16.165% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaOnly>d__160:MoveNext():bool:this
215 (22.142% of base) : System.Private.Xml.dasm - XmlSchemaValidator:CompleteValidationError(ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
Top method improvements (bytes):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
Top method regressions (percentages):
64 (914.286% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_f(Object)
64 (640.000% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_t(Object)
31 (620.000% of base) : System.Management.dasm - ManagementOptions:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
31 (387.500% of base) : System.Management.dasm - EventWatcherOptions:set_BlockSize(int):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnSerializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserialized(Object,StreamingContext):this
31 (281.818% of base) : System.Management.dasm - ManagementScope:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
43 (215.000% of base) : Microsoft.CSharp.dasm - UnsafeMethods:IUnknownReleaseNotZero(long)
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Impersonation(int):this
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Authentication(int):this
30 (136.364% of base) : System.Management.dasm - ConnectionOptions:set_EnablePrivileges(bool):this
75 (131.579% of base) : System.Net.Sockets.dasm - SocketPal:Disconnect(Socket,SafeSocketHandle,bool):int
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Map(Maybe`1,Func`2):Maybe`1 (7 methods)
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Select(Maybe`1,Func`2):Maybe`1 (7 methods)
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
36 (94.737% of base) : System.Management.dasm - ObjectGetOptions:set_UseAmendedQualifiers(bool):this
90 (90.000% of base) : CommandLine.dasm - MaybeExtensions:Bind(Maybe`1,Func`2):Maybe`1 (7 methods)
26 (89.655% of base) : System.Management.dasm - ManagementNamedValueCollection:Remove(String):this
Top method improvements (percentages):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
445 total methods with Code Size differences (3 improved, 442 regressed), 243053 unchanged.

@jkotas
jkotas
commented
Jun 27, 2020

Copy link


Copy Markdown

Member
Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers.
@BruceForstall
BruceForstall
commented
Jun 27, 2020

Copy link


Copy Markdown

Contributor
Where is the CommandLine assembly coming from?
It's whatever is in Core_Root:
ProductVersion 2.0.275
FileVersion 2.0.275.0
Comments Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments.

erozenfeld
erozenfeld
approved these changes
Jun 27, 2020
View reviewed changes
@erozenfelderozenfeld
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@JulieLeeMSFTJulieLeeMSFT
added this to the 5.0.0 milestone
Jun 27, 2020
@jkotas
jkotas
merged commit dd10afe
into
dotnet:masterJun 27, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes

+2 more reviewers

@erozenfelderozenfelderozenfeld approved these changes
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Allow to inline methods with delegate invocation (at least methods marked with AggressiveInlining)


6 participants

@AndyAyersMS@jkotas@BruceForstall@erozenfeld@Dotnet-GitSync-Bot@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
JIT: allow inlinees with delegate invoke - #38479
Merged
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Jun 27, 2020
Merged
JIT: allow inlinees with delegate invoke#38479
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

Member
RyuJit would not inline methods that contained delegate invokes. Remove

this limitation.
Closes#10048. See also #37941.
@AndyAyersMS
JIT: allow inlinees with delegate invoke
fa018bc
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closesdotnet#10048. See also dotnet#37941.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 26, 2020
@AndyAyersMS
AndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

MemberAuthor
@erozenfeld PTAL cc @dotnet/jit-contrib
jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining.
PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: 30147 (0.064% of base)
diff is a regression.
Top file regressions (bytes):
13367 : CommandLine.dasm (3.039% of base)
3272 : Microsoft.CodeAnalysis.dasm (0.189% of base)
2144 : System.Management.dasm (0.554% of base)
2091 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (0.069% of base)
1932 : System.Private.Xml.dasm (0.054% of base)
1252 : Microsoft.CodeAnalysis.VisualBasic.dasm (0.022% of base)
1134 : System.Net.Sockets.dasm (0.577% of base)
650 : System.Threading.Tasks.Dataflow.dasm (0.077% of base)
498 : Newtonsoft.Json.dasm (0.057% of base)
465 : System.Data.Common.dasm (0.031% of base)
449 : Microsoft.CodeAnalysis.CSharp.dasm (0.010% of base)
380 : System.Private.CoreLib.dasm (0.008% of base)
342 : xunit.execution.dotnet.dasm (0.147% of base)
295 : Microsoft.Extensions.Primitives.dasm (1.124% of base)
233 : System.Runtime.Serialization.Formatters.dasm (0.242% of base)
215 : System.Security.Cryptography.Primitives.dasm (0.616% of base)
200 : System.Private.DataContractSerialization.dasm (0.026% of base)
193 : Microsoft.Extensions.Http.dasm (0.446% of base)
144 : xunit.runner.utility.netcoreapp10.dasm (0.076% of base)
112 : xunit.console.dasm (0.129% of base)
36 total files with Code Size differences (0 improved, 36 regressed), 232 unchanged.
Top method regressions (bytes):
2742 (78.253% of base) : CommandLine.dasm - Trial:Collect(IEnumerable`1):Result`2 (7 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
2670 (49.739% of base) : CommandLine.dasm - ResultExtensions:Flatten(Result`2):Result`2 (7 methods)
643 (7.180% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,Func`2,Func`2,bool,int):HelpText (7 methods)
540 (22.213% of base) : CommandLine.dasm - Trial:Flatten(Result`2):Result`2 (7 methods)
531 (42.277% of base) : CommandLine.dasm - Trial:MergeMessages(IEnumerable`1,Result`2):Result`2 (7 methods)
478 (61.997% of base) : CommandLine.dasm - Tokenizer:PreprocessDashDash(IEnumerable`1,Func`2):Result`2
399 (23.596% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaIntoTrivia>d__161:MoveNext():bool:this
353 (14.143% of base) : Microsoft.CodeAnalysis.dasm - <DescendantNodesAndTokensIntoTrivia>d__159:MoveNext():bool:this
333 (19.692% of base) : System.Private.Xml.dasm - XmlSchemaValidator:ElementValidationError(XmlQualifiedName,ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
324 (14.093% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - TraceLog:FastSerialization.IFastSerializable.ToStream(Serializer):this
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
294 (25.610% of base) : CommandLine.dasm - <>c__DisplayClass17_0`1:<DisplayHelp>b__0(IEnumerable`1):this (7 methods)
284 (39.281% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetPreviousToken(SyntaxTrivia,SyntaxTriviaList,Func`2,Func`2,byref):SyntaxToken:this
273 (2.549% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,int):HelpText (7 methods)
264 (49.811% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetLastToken(SyntaxTriviaList,Func`2,Func`2):SyntaxToken:this
232 (6.080% of base) : System.Private.CoreLib.dasm - ArraySortHelper`1:IntroSort(Span`1,int,Comparison`1) (8 methods)
228 (11.639% of base) : System.Private.Xml.dasm - XmlWellFormedWriter:AdvanceStateAsync(int):Task:this
220 (16.165% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaOnly>d__160:MoveNext():bool:this
215 (22.142% of base) : System.Private.Xml.dasm - XmlSchemaValidator:CompleteValidationError(ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
Top method improvements (bytes):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
Top method regressions (percentages):
64 (914.286% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_f(Object)
64 (640.000% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_t(Object)
31 (620.000% of base) : System.Management.dasm - ManagementOptions:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
31 (387.500% of base) : System.Management.dasm - EventWatcherOptions:set_BlockSize(int):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnSerializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserialized(Object,StreamingContext):this
31 (281.818% of base) : System.Management.dasm - ManagementScope:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
43 (215.000% of base) : Microsoft.CSharp.dasm - UnsafeMethods:IUnknownReleaseNotZero(long)
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Impersonation(int):this
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Authentication(int):this
30 (136.364% of base) : System.Management.dasm - ConnectionOptions:set_EnablePrivileges(bool):this
75 (131.579% of base) : System.Net.Sockets.dasm - SocketPal:Disconnect(Socket,SafeSocketHandle,bool):int
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Map(Maybe`1,Func`2):Maybe`1 (7 methods)
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Select(Maybe`1,Func`2):Maybe`1 (7 methods)
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
36 (94.737% of base) : System.Management.dasm - ObjectGetOptions:set_UseAmendedQualifiers(bool):this
90 (90.000% of base) : CommandLine.dasm - MaybeExtensions:Bind(Maybe`1,Func`2):Maybe`1 (7 methods)
26 (89.655% of base) : System.Management.dasm - ManagementNamedValueCollection:Remove(String):this
Top method improvements (percentages):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
445 total methods with Code Size differences (3 improved, 442 regressed), 243053 unchanged.

@jkotas
jkotas
commented
Jun 27, 2020

Copy link


Copy Markdown

Member
Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers.
@BruceForstall
BruceForstall
commented
Jun 27, 2020

Copy link


Copy Markdown

Contributor
Where is the CommandLine assembly coming from?
It's whatever is in Core_Root:
ProductVersion 2.0.275
FileVersion 2.0.275.0
Comments Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments.

erozenfeld
erozenfeld
approved these changes
Jun 27, 2020
View reviewed changes
@erozenfelderozenfeld
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@JulieLeeMSFTJulieLeeMSFT
added this to the 5.0.0 milestone
Jun 27, 2020
@jkotas
jkotas
merged commit dd10afe
into
dotnet:masterJun 27, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes

+2 more reviewers

@erozenfelderozenfelderozenfeld approved these changes
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Allow to inline methods with delegate invocation (at least methods marked with AggressiveInlining)


6 participants

@AndyAyersMS@jkotas@BruceForstall@erozenfeld@Dotnet-GitSync-Bot@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
JIT: allow inlinees with delegate invoke - #38479
Merged
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Jun 27, 2020
Merged
JIT: allow inlinees with delegate invoke#38479
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

Member
RyuJit would not inline methods that contained delegate invokes. Remove

this limitation.
Closes#10048. See also #37941.
@AndyAyersMS
JIT: allow inlinees with delegate invoke
fa018bc
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closesdotnet#10048. See also dotnet#37941.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 26, 2020
@AndyAyersMS
AndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

MemberAuthor
@erozenfeld PTAL cc @dotnet/jit-contrib
jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining.
PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: 30147 (0.064% of base)
diff is a regression.
Top file regressions (bytes):
13367 : CommandLine.dasm (3.039% of base)
3272 : Microsoft.CodeAnalysis.dasm (0.189% of base)
2144 : System.Management.dasm (0.554% of base)
2091 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (0.069% of base)
1932 : System.Private.Xml.dasm (0.054% of base)
1252 : Microsoft.CodeAnalysis.VisualBasic.dasm (0.022% of base)
1134 : System.Net.Sockets.dasm (0.577% of base)
650 : System.Threading.Tasks.Dataflow.dasm (0.077% of base)
498 : Newtonsoft.Json.dasm (0.057% of base)
465 : System.Data.Common.dasm (0.031% of base)
449 : Microsoft.CodeAnalysis.CSharp.dasm (0.010% of base)
380 : System.Private.CoreLib.dasm (0.008% of base)
342 : xunit.execution.dotnet.dasm (0.147% of base)
295 : Microsoft.Extensions.Primitives.dasm (1.124% of base)
233 : System.Runtime.Serialization.Formatters.dasm (0.242% of base)
215 : System.Security.Cryptography.Primitives.dasm (0.616% of base)
200 : System.Private.DataContractSerialization.dasm (0.026% of base)
193 : Microsoft.Extensions.Http.dasm (0.446% of base)
144 : xunit.runner.utility.netcoreapp10.dasm (0.076% of base)
112 : xunit.console.dasm (0.129% of base)
36 total files with Code Size differences (0 improved, 36 regressed), 232 unchanged.
Top method regressions (bytes):
2742 (78.253% of base) : CommandLine.dasm - Trial:Collect(IEnumerable`1):Result`2 (7 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
2670 (49.739% of base) : CommandLine.dasm - ResultExtensions:Flatten(Result`2):Result`2 (7 methods)
643 (7.180% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,Func`2,Func`2,bool,int):HelpText (7 methods)
540 (22.213% of base) : CommandLine.dasm - Trial:Flatten(Result`2):Result`2 (7 methods)
531 (42.277% of base) : CommandLine.dasm - Trial:MergeMessages(IEnumerable`1,Result`2):Result`2 (7 methods)
478 (61.997% of base) : CommandLine.dasm - Tokenizer:PreprocessDashDash(IEnumerable`1,Func`2):Result`2
399 (23.596% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaIntoTrivia>d__161:MoveNext():bool:this
353 (14.143% of base) : Microsoft.CodeAnalysis.dasm - <DescendantNodesAndTokensIntoTrivia>d__159:MoveNext():bool:this
333 (19.692% of base) : System.Private.Xml.dasm - XmlSchemaValidator:ElementValidationError(XmlQualifiedName,ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
324 (14.093% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - TraceLog:FastSerialization.IFastSerializable.ToStream(Serializer):this
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
294 (25.610% of base) : CommandLine.dasm - <>c__DisplayClass17_0`1:<DisplayHelp>b__0(IEnumerable`1):this (7 methods)
284 (39.281% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetPreviousToken(SyntaxTrivia,SyntaxTriviaList,Func`2,Func`2,byref):SyntaxToken:this
273 (2.549% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,int):HelpText (7 methods)
264 (49.811% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetLastToken(SyntaxTriviaList,Func`2,Func`2):SyntaxToken:this
232 (6.080% of base) : System.Private.CoreLib.dasm - ArraySortHelper`1:IntroSort(Span`1,int,Comparison`1) (8 methods)
228 (11.639% of base) : System.Private.Xml.dasm - XmlWellFormedWriter:AdvanceStateAsync(int):Task:this
220 (16.165% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaOnly>d__160:MoveNext():bool:this
215 (22.142% of base) : System.Private.Xml.dasm - XmlSchemaValidator:CompleteValidationError(ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
Top method improvements (bytes):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
Top method regressions (percentages):
64 (914.286% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_f(Object)
64 (640.000% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_t(Object)
31 (620.000% of base) : System.Management.dasm - ManagementOptions:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
31 (387.500% of base) : System.Management.dasm - EventWatcherOptions:set_BlockSize(int):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnSerializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserialized(Object,StreamingContext):this
31 (281.818% of base) : System.Management.dasm - ManagementScope:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
43 (215.000% of base) : Microsoft.CSharp.dasm - UnsafeMethods:IUnknownReleaseNotZero(long)
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Impersonation(int):this
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Authentication(int):this
30 (136.364% of base) : System.Management.dasm - ConnectionOptions:set_EnablePrivileges(bool):this
75 (131.579% of base) : System.Net.Sockets.dasm - SocketPal:Disconnect(Socket,SafeSocketHandle,bool):int
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Map(Maybe`1,Func`2):Maybe`1 (7 methods)
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Select(Maybe`1,Func`2):Maybe`1 (7 methods)
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
36 (94.737% of base) : System.Management.dasm - ObjectGetOptions:set_UseAmendedQualifiers(bool):this
90 (90.000% of base) : CommandLine.dasm - MaybeExtensions:Bind(Maybe`1,Func`2):Maybe`1 (7 methods)
26 (89.655% of base) : System.Management.dasm - ManagementNamedValueCollection:Remove(String):this
Top method improvements (percentages):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
445 total methods with Code Size differences (3 improved, 442 regressed), 243053 unchanged.

@jkotas
jkotas
commented
Jun 27, 2020

Copy link


Copy Markdown

Member
Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers.
@BruceForstall
BruceForstall
commented
Jun 27, 2020

Copy link


Copy Markdown

Contributor
Where is the CommandLine assembly coming from?
It's whatever is in Core_Root:
ProductVersion 2.0.275
FileVersion 2.0.275.0
Comments Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments.

erozenfeld
erozenfeld
approved these changes
Jun 27, 2020
View reviewed changes
@erozenfelderozenfeld
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@JulieLeeMSFTJulieLeeMSFT
added this to the 5.0.0 milestone
Jun 27, 2020
@jkotas
jkotas
merged commit dd10afe
into
dotnet:masterJun 27, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes

+2 more reviewers

@erozenfelderozenfelderozenfeld approved these changes
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Allow to inline methods with delegate invocation (at least methods marked with AggressiveInlining)


6 participants

@AndyAyersMS@jkotas@BruceForstall@erozenfeld@Dotnet-GitSync-Bot@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
JIT: allow inlinees with delegate invoke - #38479
Merged
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Jun 27, 2020
Merged
JIT: allow inlinees with delegate invoke#38479
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

Member
RyuJit would not inline methods that contained delegate invokes. Remove

this limitation.
Closes#10048. See also #37941.
@AndyAyersMS
JIT: allow inlinees with delegate invoke
fa018bc
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closesdotnet#10048. See also dotnet#37941.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 26, 2020
@AndyAyersMS
AndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

MemberAuthor
@erozenfeld PTAL cc @dotnet/jit-contrib
jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining.
PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: 30147 (0.064% of base)
diff is a regression.
Top file regressions (bytes):
13367 : CommandLine.dasm (3.039% of base)
3272 : Microsoft.CodeAnalysis.dasm (0.189% of base)
2144 : System.Management.dasm (0.554% of base)
2091 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (0.069% of base)
1932 : System.Private.Xml.dasm (0.054% of base)
1252 : Microsoft.CodeAnalysis.VisualBasic.dasm (0.022% of base)
1134 : System.Net.Sockets.dasm (0.577% of base)
650 : System.Threading.Tasks.Dataflow.dasm (0.077% of base)
498 : Newtonsoft.Json.dasm (0.057% of base)
465 : System.Data.Common.dasm (0.031% of base)
449 : Microsoft.CodeAnalysis.CSharp.dasm (0.010% of base)
380 : System.Private.CoreLib.dasm (0.008% of base)
342 : xunit.execution.dotnet.dasm (0.147% of base)
295 : Microsoft.Extensions.Primitives.dasm (1.124% of base)
233 : System.Runtime.Serialization.Formatters.dasm (0.242% of base)
215 : System.Security.Cryptography.Primitives.dasm (0.616% of base)
200 : System.Private.DataContractSerialization.dasm (0.026% of base)
193 : Microsoft.Extensions.Http.dasm (0.446% of base)
144 : xunit.runner.utility.netcoreapp10.dasm (0.076% of base)
112 : xunit.console.dasm (0.129% of base)
36 total files with Code Size differences (0 improved, 36 regressed), 232 unchanged.
Top method regressions (bytes):
2742 (78.253% of base) : CommandLine.dasm - Trial:Collect(IEnumerable`1):Result`2 (7 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
2670 (49.739% of base) : CommandLine.dasm - ResultExtensions:Flatten(Result`2):Result`2 (7 methods)
643 (7.180% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,Func`2,Func`2,bool,int):HelpText (7 methods)
540 (22.213% of base) : CommandLine.dasm - Trial:Flatten(Result`2):Result`2 (7 methods)
531 (42.277% of base) : CommandLine.dasm - Trial:MergeMessages(IEnumerable`1,Result`2):Result`2 (7 methods)
478 (61.997% of base) : CommandLine.dasm - Tokenizer:PreprocessDashDash(IEnumerable`1,Func`2):Result`2
399 (23.596% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaIntoTrivia>d__161:MoveNext():bool:this
353 (14.143% of base) : Microsoft.CodeAnalysis.dasm - <DescendantNodesAndTokensIntoTrivia>d__159:MoveNext():bool:this
333 (19.692% of base) : System.Private.Xml.dasm - XmlSchemaValidator:ElementValidationError(XmlQualifiedName,ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
324 (14.093% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - TraceLog:FastSerialization.IFastSerializable.ToStream(Serializer):this
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
294 (25.610% of base) : CommandLine.dasm - <>c__DisplayClass17_0`1:<DisplayHelp>b__0(IEnumerable`1):this (7 methods)
284 (39.281% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetPreviousToken(SyntaxTrivia,SyntaxTriviaList,Func`2,Func`2,byref):SyntaxToken:this
273 (2.549% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,int):HelpText (7 methods)
264 (49.811% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetLastToken(SyntaxTriviaList,Func`2,Func`2):SyntaxToken:this
232 (6.080% of base) : System.Private.CoreLib.dasm - ArraySortHelper`1:IntroSort(Span`1,int,Comparison`1) (8 methods)
228 (11.639% of base) : System.Private.Xml.dasm - XmlWellFormedWriter:AdvanceStateAsync(int):Task:this
220 (16.165% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaOnly>d__160:MoveNext():bool:this
215 (22.142% of base) : System.Private.Xml.dasm - XmlSchemaValidator:CompleteValidationError(ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
Top method improvements (bytes):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
Top method regressions (percentages):
64 (914.286% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_f(Object)
64 (640.000% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_t(Object)
31 (620.000% of base) : System.Management.dasm - ManagementOptions:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
31 (387.500% of base) : System.Management.dasm - EventWatcherOptions:set_BlockSize(int):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnSerializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserialized(Object,StreamingContext):this
31 (281.818% of base) : System.Management.dasm - ManagementScope:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
43 (215.000% of base) : Microsoft.CSharp.dasm - UnsafeMethods:IUnknownReleaseNotZero(long)
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Impersonation(int):this
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Authentication(int):this
30 (136.364% of base) : System.Management.dasm - ConnectionOptions:set_EnablePrivileges(bool):this
75 (131.579% of base) : System.Net.Sockets.dasm - SocketPal:Disconnect(Socket,SafeSocketHandle,bool):int
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Map(Maybe`1,Func`2):Maybe`1 (7 methods)
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Select(Maybe`1,Func`2):Maybe`1 (7 methods)
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
36 (94.737% of base) : System.Management.dasm - ObjectGetOptions:set_UseAmendedQualifiers(bool):this
90 (90.000% of base) : CommandLine.dasm - MaybeExtensions:Bind(Maybe`1,Func`2):Maybe`1 (7 methods)
26 (89.655% of base) : System.Management.dasm - ManagementNamedValueCollection:Remove(String):this
Top method improvements (percentages):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
445 total methods with Code Size differences (3 improved, 442 regressed), 243053 unchanged.

@jkotas
jkotas
commented
Jun 27, 2020

Copy link


Copy Markdown

Member
Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers.
@BruceForstall
BruceForstall
commented
Jun 27, 2020

Copy link


Copy Markdown

Contributor
Where is the CommandLine assembly coming from?
It's whatever is in Core_Root:
ProductVersion 2.0.275
FileVersion 2.0.275.0
Comments Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments.

erozenfeld
erozenfeld
approved these changes
Jun 27, 2020
View reviewed changes
@erozenfelderozenfeld
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@JulieLeeMSFTJulieLeeMSFT
added this to the 5.0.0 milestone
Jun 27, 2020
@jkotas
jkotas
merged commit dd10afe
into
dotnet:masterJun 27, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes

+2 more reviewers

@erozenfelderozenfelderozenfeld approved these changes
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Allow to inline methods with delegate invocation (at least methods marked with AggressiveInlining)


6 participants

@AndyAyersMS@jkotas@BruceForstall@erozenfeld@Dotnet-GitSync-Bot@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
JIT: allow inlinees with delegate invoke - #38479
Merged
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Jun 27, 2020
Merged
JIT: allow inlinees with delegate invoke#38479
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

Member
RyuJit would not inline methods that contained delegate invokes. Remove

this limitation.
Closes#10048. See also #37941.
@AndyAyersMS
JIT: allow inlinees with delegate invoke
fa018bc
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closesdotnet#10048. See also dotnet#37941.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 26, 2020
@AndyAyersMS
AndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

MemberAuthor
@erozenfeld PTAL cc @dotnet/jit-contrib
jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining.
PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: 30147 (0.064% of base)
diff is a regression.
Top file regressions (bytes):
13367 : CommandLine.dasm (3.039% of base)
3272 : Microsoft.CodeAnalysis.dasm (0.189% of base)
2144 : System.Management.dasm (0.554% of base)
2091 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (0.069% of base)
1932 : System.Private.Xml.dasm (0.054% of base)
1252 : Microsoft.CodeAnalysis.VisualBasic.dasm (0.022% of base)
1134 : System.Net.Sockets.dasm (0.577% of base)
650 : System.Threading.Tasks.Dataflow.dasm (0.077% of base)
498 : Newtonsoft.Json.dasm (0.057% of base)
465 : System.Data.Common.dasm (0.031% of base)
449 : Microsoft.CodeAnalysis.CSharp.dasm (0.010% of base)
380 : System.Private.CoreLib.dasm (0.008% of base)
342 : xunit.execution.dotnet.dasm (0.147% of base)
295 : Microsoft.Extensions.Primitives.dasm (1.124% of base)
233 : System.Runtime.Serialization.Formatters.dasm (0.242% of base)
215 : System.Security.Cryptography.Primitives.dasm (0.616% of base)
200 : System.Private.DataContractSerialization.dasm (0.026% of base)
193 : Microsoft.Extensions.Http.dasm (0.446% of base)
144 : xunit.runner.utility.netcoreapp10.dasm (0.076% of base)
112 : xunit.console.dasm (0.129% of base)
36 total files with Code Size differences (0 improved, 36 regressed), 232 unchanged.
Top method regressions (bytes):
2742 (78.253% of base) : CommandLine.dasm - Trial:Collect(IEnumerable`1):Result`2 (7 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
2670 (49.739% of base) : CommandLine.dasm - ResultExtensions:Flatten(Result`2):Result`2 (7 methods)
643 (7.180% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,Func`2,Func`2,bool,int):HelpText (7 methods)
540 (22.213% of base) : CommandLine.dasm - Trial:Flatten(Result`2):Result`2 (7 methods)
531 (42.277% of base) : CommandLine.dasm - Trial:MergeMessages(IEnumerable`1,Result`2):Result`2 (7 methods)
478 (61.997% of base) : CommandLine.dasm - Tokenizer:PreprocessDashDash(IEnumerable`1,Func`2):Result`2
399 (23.596% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaIntoTrivia>d__161:MoveNext():bool:this
353 (14.143% of base) : Microsoft.CodeAnalysis.dasm - <DescendantNodesAndTokensIntoTrivia>d__159:MoveNext():bool:this
333 (19.692% of base) : System.Private.Xml.dasm - XmlSchemaValidator:ElementValidationError(XmlQualifiedName,ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
324 (14.093% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - TraceLog:FastSerialization.IFastSerializable.ToStream(Serializer):this
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
294 (25.610% of base) : CommandLine.dasm - <>c__DisplayClass17_0`1:<DisplayHelp>b__0(IEnumerable`1):this (7 methods)
284 (39.281% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetPreviousToken(SyntaxTrivia,SyntaxTriviaList,Func`2,Func`2,byref):SyntaxToken:this
273 (2.549% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,int):HelpText (7 methods)
264 (49.811% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetLastToken(SyntaxTriviaList,Func`2,Func`2):SyntaxToken:this
232 (6.080% of base) : System.Private.CoreLib.dasm - ArraySortHelper`1:IntroSort(Span`1,int,Comparison`1) (8 methods)
228 (11.639% of base) : System.Private.Xml.dasm - XmlWellFormedWriter:AdvanceStateAsync(int):Task:this
220 (16.165% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaOnly>d__160:MoveNext():bool:this
215 (22.142% of base) : System.Private.Xml.dasm - XmlSchemaValidator:CompleteValidationError(ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
Top method improvements (bytes):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
Top method regressions (percentages):
64 (914.286% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_f(Object)
64 (640.000% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_t(Object)
31 (620.000% of base) : System.Management.dasm - ManagementOptions:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
31 (387.500% of base) : System.Management.dasm - EventWatcherOptions:set_BlockSize(int):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnSerializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserialized(Object,StreamingContext):this
31 (281.818% of base) : System.Management.dasm - ManagementScope:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
43 (215.000% of base) : Microsoft.CSharp.dasm - UnsafeMethods:IUnknownReleaseNotZero(long)
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Impersonation(int):this
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Authentication(int):this
30 (136.364% of base) : System.Management.dasm - ConnectionOptions:set_EnablePrivileges(bool):this
75 (131.579% of base) : System.Net.Sockets.dasm - SocketPal:Disconnect(Socket,SafeSocketHandle,bool):int
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Map(Maybe`1,Func`2):Maybe`1 (7 methods)
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Select(Maybe`1,Func`2):Maybe`1 (7 methods)
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
36 (94.737% of base) : System.Management.dasm - ObjectGetOptions:set_UseAmendedQualifiers(bool):this
90 (90.000% of base) : CommandLine.dasm - MaybeExtensions:Bind(Maybe`1,Func`2):Maybe`1 (7 methods)
26 (89.655% of base) : System.Management.dasm - ManagementNamedValueCollection:Remove(String):this
Top method improvements (percentages):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
445 total methods with Code Size differences (3 improved, 442 regressed), 243053 unchanged.

@jkotas
jkotas
commented
Jun 27, 2020

Copy link


Copy Markdown

Member
Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers.
@BruceForstall
BruceForstall
commented
Jun 27, 2020

Copy link


Copy Markdown

Contributor
Where is the CommandLine assembly coming from?
It's whatever is in Core_Root:
ProductVersion 2.0.275
FileVersion 2.0.275.0
Comments Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments.

erozenfeld
erozenfeld
approved these changes
Jun 27, 2020
View reviewed changes
@erozenfelderozenfeld
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@JulieLeeMSFTJulieLeeMSFT
added this to the 5.0.0 milestone
Jun 27, 2020
@jkotas
jkotas
merged commit dd10afe
into
dotnet:masterJun 27, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes

+2 more reviewers

@erozenfelderozenfelderozenfeld approved these changes
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Allow to inline methods with delegate invocation (at least methods marked with AggressiveInlining)


6 participants

@AndyAyersMS@jkotas@BruceForstall@erozenfeld@Dotnet-GitSync-Bot@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
JIT: allow inlinees with delegate invoke - #38479
Merged
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Jun 27, 2020
Merged
JIT: allow inlinees with delegate invoke#38479
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

Member
RyuJit would not inline methods that contained delegate invokes. Remove

this limitation.
Closes#10048. See also #37941.
@AndyAyersMS
JIT: allow inlinees with delegate invoke
fa018bc
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closesdotnet#10048. See also dotnet#37941.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 26, 2020
@AndyAyersMS
AndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

MemberAuthor
@erozenfeld PTAL cc @dotnet/jit-contrib
jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining.
PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: 30147 (0.064% of base)
diff is a regression.
Top file regressions (bytes):
13367 : CommandLine.dasm (3.039% of base)
3272 : Microsoft.CodeAnalysis.dasm (0.189% of base)
2144 : System.Management.dasm (0.554% of base)
2091 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (0.069% of base)
1932 : System.Private.Xml.dasm (0.054% of base)
1252 : Microsoft.CodeAnalysis.VisualBasic.dasm (0.022% of base)
1134 : System.Net.Sockets.dasm (0.577% of base)
650 : System.Threading.Tasks.Dataflow.dasm (0.077% of base)
498 : Newtonsoft.Json.dasm (0.057% of base)
465 : System.Data.Common.dasm (0.031% of base)
449 : Microsoft.CodeAnalysis.CSharp.dasm (0.010% of base)
380 : System.Private.CoreLib.dasm (0.008% of base)
342 : xunit.execution.dotnet.dasm (0.147% of base)
295 : Microsoft.Extensions.Primitives.dasm (1.124% of base)
233 : System.Runtime.Serialization.Formatters.dasm (0.242% of base)
215 : System.Security.Cryptography.Primitives.dasm (0.616% of base)
200 : System.Private.DataContractSerialization.dasm (0.026% of base)
193 : Microsoft.Extensions.Http.dasm (0.446% of base)
144 : xunit.runner.utility.netcoreapp10.dasm (0.076% of base)
112 : xunit.console.dasm (0.129% of base)
36 total files with Code Size differences (0 improved, 36 regressed), 232 unchanged.
Top method regressions (bytes):
2742 (78.253% of base) : CommandLine.dasm - Trial:Collect(IEnumerable`1):Result`2 (7 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
2670 (49.739% of base) : CommandLine.dasm - ResultExtensions:Flatten(Result`2):Result`2 (7 methods)
643 (7.180% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,Func`2,Func`2,bool,int):HelpText (7 methods)
540 (22.213% of base) : CommandLine.dasm - Trial:Flatten(Result`2):Result`2 (7 methods)
531 (42.277% of base) : CommandLine.dasm - Trial:MergeMessages(IEnumerable`1,Result`2):Result`2 (7 methods)
478 (61.997% of base) : CommandLine.dasm - Tokenizer:PreprocessDashDash(IEnumerable`1,Func`2):Result`2
399 (23.596% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaIntoTrivia>d__161:MoveNext():bool:this
353 (14.143% of base) : Microsoft.CodeAnalysis.dasm - <DescendantNodesAndTokensIntoTrivia>d__159:MoveNext():bool:this
333 (19.692% of base) : System.Private.Xml.dasm - XmlSchemaValidator:ElementValidationError(XmlQualifiedName,ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
324 (14.093% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - TraceLog:FastSerialization.IFastSerializable.ToStream(Serializer):this
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
294 (25.610% of base) : CommandLine.dasm - <>c__DisplayClass17_0`1:<DisplayHelp>b__0(IEnumerable`1):this (7 methods)
284 (39.281% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetPreviousToken(SyntaxTrivia,SyntaxTriviaList,Func`2,Func`2,byref):SyntaxToken:this
273 (2.549% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,int):HelpText (7 methods)
264 (49.811% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetLastToken(SyntaxTriviaList,Func`2,Func`2):SyntaxToken:this
232 (6.080% of base) : System.Private.CoreLib.dasm - ArraySortHelper`1:IntroSort(Span`1,int,Comparison`1) (8 methods)
228 (11.639% of base) : System.Private.Xml.dasm - XmlWellFormedWriter:AdvanceStateAsync(int):Task:this
220 (16.165% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaOnly>d__160:MoveNext():bool:this
215 (22.142% of base) : System.Private.Xml.dasm - XmlSchemaValidator:CompleteValidationError(ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
Top method improvements (bytes):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
Top method regressions (percentages):
64 (914.286% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_f(Object)
64 (640.000% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_t(Object)
31 (620.000% of base) : System.Management.dasm - ManagementOptions:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
31 (387.500% of base) : System.Management.dasm - EventWatcherOptions:set_BlockSize(int):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnSerializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserialized(Object,StreamingContext):this
31 (281.818% of base) : System.Management.dasm - ManagementScope:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
43 (215.000% of base) : Microsoft.CSharp.dasm - UnsafeMethods:IUnknownReleaseNotZero(long)
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Impersonation(int):this
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Authentication(int):this
30 (136.364% of base) : System.Management.dasm - ConnectionOptions:set_EnablePrivileges(bool):this
75 (131.579% of base) : System.Net.Sockets.dasm - SocketPal:Disconnect(Socket,SafeSocketHandle,bool):int
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Map(Maybe`1,Func`2):Maybe`1 (7 methods)
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Select(Maybe`1,Func`2):Maybe`1 (7 methods)
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
36 (94.737% of base) : System.Management.dasm - ObjectGetOptions:set_UseAmendedQualifiers(bool):this
90 (90.000% of base) : CommandLine.dasm - MaybeExtensions:Bind(Maybe`1,Func`2):Maybe`1 (7 methods)
26 (89.655% of base) : System.Management.dasm - ManagementNamedValueCollection:Remove(String):this
Top method improvements (percentages):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
445 total methods with Code Size differences (3 improved, 442 regressed), 243053 unchanged.

@jkotas
jkotas
commented
Jun 27, 2020

Copy link


Copy Markdown

Member
Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers.
@BruceForstall
BruceForstall
commented
Jun 27, 2020

Copy link


Copy Markdown

Contributor
Where is the CommandLine assembly coming from?
It's whatever is in Core_Root:
ProductVersion 2.0.275
FileVersion 2.0.275.0
Comments Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments.

erozenfeld
erozenfeld
approved these changes
Jun 27, 2020
View reviewed changes
@erozenfelderozenfeld
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@JulieLeeMSFTJulieLeeMSFT
added this to the 5.0.0 milestone
Jun 27, 2020
@jkotas
jkotas
merged commit dd10afe
into
dotnet:masterJun 27, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes

+2 more reviewers

@erozenfelderozenfelderozenfeld approved these changes
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Allow to inline methods with delegate invocation (at least methods marked with AggressiveInlining)


6 participants

@AndyAyersMS@jkotas@BruceForstall@erozenfeld@Dotnet-GitSync-Bot@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
JIT: allow inlinees with delegate invoke - #38479
Merged
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Jun 27, 2020
Merged
JIT: allow inlinees with delegate invoke#38479
jkotas merged 1 commit into
dotnet:masterfrom 
AndyAyersMS:AllowInlineeDelegateInvoke
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

Member
RyuJit would not inline methods that contained delegate invokes. Remove

this limitation.
Closes#10048. See also #37941.
@AndyAyersMS
JIT: allow inlinees with delegate invoke
fa018bc
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closesdotnet#10048. See also dotnet#37941.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 26, 2020
@AndyAyersMS
AndyAyersMS
commented
Jun 26, 2020

Copy link


Copy Markdown

MemberAuthor
@erozenfeld PTAL cc @dotnet/jit-contrib
jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining.
PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: 30147 (0.064% of base)
diff is a regression.
Top file regressions (bytes):
13367 : CommandLine.dasm (3.039% of base)
3272 : Microsoft.CodeAnalysis.dasm (0.189% of base)
2144 : System.Management.dasm (0.554% of base)
2091 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (0.069% of base)
1932 : System.Private.Xml.dasm (0.054% of base)
1252 : Microsoft.CodeAnalysis.VisualBasic.dasm (0.022% of base)
1134 : System.Net.Sockets.dasm (0.577% of base)
650 : System.Threading.Tasks.Dataflow.dasm (0.077% of base)
498 : Newtonsoft.Json.dasm (0.057% of base)
465 : System.Data.Common.dasm (0.031% of base)
449 : Microsoft.CodeAnalysis.CSharp.dasm (0.010% of base)
380 : System.Private.CoreLib.dasm (0.008% of base)
342 : xunit.execution.dotnet.dasm (0.147% of base)
295 : Microsoft.Extensions.Primitives.dasm (1.124% of base)
233 : System.Runtime.Serialization.Formatters.dasm (0.242% of base)
215 : System.Security.Cryptography.Primitives.dasm (0.616% of base)
200 : System.Private.DataContractSerialization.dasm (0.026% of base)
193 : Microsoft.Extensions.Http.dasm (0.446% of base)
144 : xunit.runner.utility.netcoreapp10.dasm (0.076% of base)
112 : xunit.console.dasm (0.129% of base)
36 total files with Code Size differences (0 improved, 36 regressed), 232 unchanged.
Top method regressions (bytes):
2742 (78.253% of base) : CommandLine.dasm - Trial:Collect(IEnumerable`1):Result`2 (7 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
2670 (49.739% of base) : CommandLine.dasm - ResultExtensions:Flatten(Result`2):Result`2 (7 methods)
643 (7.180% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,Func`2,Func`2,bool,int):HelpText (7 methods)
540 (22.213% of base) : CommandLine.dasm - Trial:Flatten(Result`2):Result`2 (7 methods)
531 (42.277% of base) : CommandLine.dasm - Trial:MergeMessages(IEnumerable`1,Result`2):Result`2 (7 methods)
478 (61.997% of base) : CommandLine.dasm - Tokenizer:PreprocessDashDash(IEnumerable`1,Func`2):Result`2
399 (23.596% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaIntoTrivia>d__161:MoveNext():bool:this
353 (14.143% of base) : Microsoft.CodeAnalysis.dasm - <DescendantNodesAndTokensIntoTrivia>d__159:MoveNext():bool:this
333 (19.692% of base) : System.Private.Xml.dasm - XmlSchemaValidator:ElementValidationError(XmlQualifiedName,ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
324 (14.093% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - TraceLog:FastSerialization.IFastSerializable.ToStream(Serializer):this
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
294 (25.610% of base) : CommandLine.dasm - <>c__DisplayClass17_0`1:<DisplayHelp>b__0(IEnumerable`1):this (7 methods)
284 (39.281% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetPreviousToken(SyntaxTrivia,SyntaxTriviaList,Func`2,Func`2,byref):SyntaxToken:this
273 (2.549% of base) : CommandLine.dasm - HelpText:AutoBuild(ParserResult`1,int):HelpText (7 methods)
264 (49.811% of base) : Microsoft.CodeAnalysis.dasm - AbstractSyntaxNavigator:GetLastToken(SyntaxTriviaList,Func`2,Func`2):SyntaxToken:this
232 (6.080% of base) : System.Private.CoreLib.dasm - ArraySortHelper`1:IntroSort(Span`1,int,Comparison`1) (8 methods)
228 (11.639% of base) : System.Private.Xml.dasm - XmlWellFormedWriter:AdvanceStateAsync(int):Task:this
220 (16.165% of base) : Microsoft.CodeAnalysis.dasm - <DescendantTriviaOnly>d__160:MoveNext():bool:this
215 (22.142% of base) : System.Private.Xml.dasm - XmlSchemaValidator:CompleteValidationError(ValidationState,ValidationEventHandler,Object,String,int,int,XmlSchemaSet)
Top method improvements (bytes):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
Top method regressions (percentages):
64 (914.286% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_f(Object)
64 (640.000% of base) : System.Private.CoreLib.dasm - _ThreadPoolWaitOrTimerCallback:WaitOrTimerCallback_Context_t(Object)
31 (620.000% of base) : System.Management.dasm - ManagementOptions:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
31 (387.500% of base) : System.Management.dasm - EventWatcherOptions:set_BlockSize(int):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnSerializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserializing(Object,StreamingContext):this
52 (288.889% of base) : System.Runtime.Serialization.Formatters.dasm - SerializationEvents:InvokeOnDeserialized(Object,StreamingContext):this
31 (281.818% of base) : System.Management.dasm - ManagementScope:HandleIdentifierChange(Object,IdentifierChangedEventArgs):this
43 (215.000% of base) : Microsoft.CSharp.dasm - UnsafeMethods:IUnknownReleaseNotZero(long)
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Impersonation(int):this
30 (214.286% of base) : System.Management.dasm - ConnectionOptions:set_Authentication(int):this
30 (136.364% of base) : System.Management.dasm - ConnectionOptions:set_EnablePrivileges(bool):this
75 (131.579% of base) : System.Net.Sockets.dasm - SocketPal:Disconnect(Socket,SafeSocketHandle,bool):int
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Map(Maybe`1,Func`2):Maybe`1 (7 methods)
116 (116.000% of base) : CommandLine.dasm - MaybeExtensions:Select(Maybe`1,Func`2):Maybe`1 (7 methods)
320 (96.677% of base) : Microsoft.CodeAnalysis.dasm - CryptographicHashProvider:TryGetAlgorithm(int):HashAlgorithm (2 methods)
2742 (95.540% of base) : CommandLine.dasm - ResultExtensions:Collect(IEnumerable`1):Result`2 (7 methods)
36 (94.737% of base) : System.Management.dasm - ObjectGetOptions:set_UseAmendedQualifiers(bool):this
90 (90.000% of base) : CommandLine.dasm - MaybeExtensions:Bind(Maybe`1,Func`2):Maybe`1 (7 methods)
26 (89.655% of base) : System.Management.dasm - ManagementNamedValueCollection:Remove(String):this
Top method improvements (percentages):
-18 (-0.708% of base) : System.Net.Http.WinHttpHandler.dasm - HttpKnownHeaderNames:TryGetHeaderName(__Canon,int,int,Func`3,Func`5,byref):bool
-2 (-0.412% of base) : xunit.performance.execution.dasm - BenchmarkEventSource:BenchmarkIterationStop(String,String,int,long):this
-4 (-0.219% of base) : CommandLine.dasm - <>c__DisplayClass0_2`1:<Build>b__15():__Canon:this
445 total methods with Code Size differences (3 improved, 442 regressed), 243053 unchanged.

@jkotas
jkotas
commented
Jun 27, 2020

Copy link


Copy Markdown

Member
Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers.
@BruceForstall
BruceForstall
commented
Jun 27, 2020

Copy link


Copy Markdown

Contributor
Where is the CommandLine assembly coming from?
It's whatever is in Core_Root:
ProductVersion 2.0.275
FileVersion 2.0.275.0
Comments Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments.

erozenfeld
erozenfeld
approved these changes
Jun 27, 2020
View reviewed changes
@erozenfelderozenfeld
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@JulieLeeMSFTJulieLeeMSFT
added this to the 5.0.0 milestone
Jun 27, 2020
@jkotas
jkotas
merged commit dd10afe
into
dotnet:masterJun 27, 2020
@ghostghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes

+2 more reviewers

@erozenfelderozenfelderozenfeld approved these changes
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Allow to inline methods with delegate invocation (at least methods marked with AggressiveInlining)


6 participants

@AndyAyersMS@jkotas@BruceForstall@erozenfeld@Dotnet-GitSync-Bot@JulieLeeMSFT