Uh oh!
There was an error while loading. Please reload this page.
Adds Console Log Formatting APIs - #38616
Conversation
Dotnet-GitSync-Bot
commented
Jun 30, 2020
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
10355e1 to
3d8de0cCompareUh oh!
There was an error while loading. Please reload this page.
tarekgh
commented
Jul 1, 2020
@maryamariyan I'll wait till the design review occur and then will review this PR. CC @davidfowl |
| public const string Json = "json"; | ||
| public const string Systemd = "systemd"; | ||
| } | ||
| [System.ObsoleteAttribute("ConsoleLoggerFormat has been deprecated.", false)] |
There was a problem hiding this comment.
ObsoleteAttribute [](start = 12, length = 17)
Do we need to file and fill the breaking change template for such changes?
There was a problem hiding this comment.
We actually do document APIs marked obsolete as a breaking change using https://github.com/dotnet/docs/issues/new?template=dotnet-breaking-change.md.
You can look up https://docs.microsoft.com/en-us/dotnet/core/compatibility/aspnetcore for examples.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jkotas
commented
Jul 16, 2020
Was CI green on this before this was merged? I am seeing failures introduced by this change in number of PRs. |
maryamariyan
commented
Jul 16, 2020
yes. it was green and I did a rebase to resolve a conflict on ConsoleLoggerTest |
this git page is incorrectly saying 168 files were changed, but it is actually 47 files: see 69d98ee |
safern
commented
Jul 16, 2020
I'm investigating the failure and I believe this is because of: #39209
I'm doing a run without #39209 |
Uh oh!
There was an error while loading. Please reload this page.