') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [Arm64] ASIMD InsertScalar and rename to ShiftLeftAndInsert ShiftRightAndInsert by echesakov · Pull Request #38680 · dotnet/runtime · GitHub
Skip to content

[Arm64] ASIMD InsertScalar and rename to ShiftLeftAndInsert ShiftRightAndInsert - #38680

Merged
echesakov merged 13 commits into
dotnet:masterfrom
echesakov:Arm64-ASIMD-InsertScalar-ShiftLeftAndInsert-ShiftRightAndInsert
Jul 2, 2020
Merged

[Arm64] ASIMD InsertScalar and rename to ShiftLeftAndInsert ShiftRightAndInsert #38680
echesakov merged 13 commits into
dotnet:masterfrom
echesakov:Arm64-ASIMD-InsertScalar-ShiftLeftAndInsert-ShiftRightAndInsert

Conversation

@echesakov

@echesakovechesakov commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

Fixes#38137

I attached JitDisasm for PMI-d System.Private.CoreLib.dll for Vector128<T>.WithLower and Vector128<T>.WithUpper
System.Private.CoreLib-PMI+JitDisasm.txt

echesakov added 13 commits July 1, 2020 11:01
@echesakov
Add InsertScalar in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
885d0d6
@echesakov
Update System.Runtime.Intrinsics.cs
8c9807b
@echesakov
Update Vector128.WithLower and Vector128.WithUpper to use InsertScala…
386b1a5
…r in Vector128.cs
@echesakov
Add InsertScalarTest.template and add InsertScalar in GenerateTests.csx
0dc578f
@echesakov
Implement InsertScalar in JIT
a1283d9
@echesakov
Update AdvSimd/
b1e2aa3
@echesakov
Rename ShiftLeftLogicalAndInsert->ShiftLeftAndInsert, ShiftLeftLogica…
6232a26
…lAndInsertScalar->ShiftLeftAndInsertScalar, ShiftRightLogicalAndInsertScalar->ShiftRightAndInsertScalar in hwintrinsiclistarm64.h
@echesakov
Rename ShiftLeftLogicalAndInsert->ShiftLeftAndInsert, ShiftLeftLogica…
6236e48
…lAndInsertScalar->ShiftLeftAndInsertScalar, ShiftRightLogicalAndInsertScalar->ShiftRightAndInsertScalar in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
@echesakov
Re-order ShiftLeftAndInsert and ShiftRightAndInsert in AdvSimd.cs Adv…
7b6add4
…Simd.PlatformNotSupported.cs
@echesakov
Update System.Runtime.Intrinsics.cs
6352a6b
@echesakov
Update GenerateTests.csx
9c7d3b9
@echesakov
Update Helpers.cs Helpers.tt
02f5347
@echesakov
Update AdvSimd/
9fc108a
@ghost

ghost commented Jul 1, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot

Dotnet-GitSync-Bot commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@echesakov

echesakov commented Jul 1, 2020

Copy link
Copy Markdown
ContributorAuthor

@CarolEidt@tannergooding@TamarChristinaArm PTAL

cc @kunalspathak for changes in WithLower and WithUpper

kunalspathak
kunalspathak reviewed Jul 1, 2020
View reviewed changes
Comment threadsrc/coreclr/src/jit/hwintrinsiccodegenarm64.cpp
kunalspathak
kunalspathak approved these changes Jul 1, 2020
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echesakov
echesakov merged commit eaf3c78 into dotnet:masterJul 2, 2020
@echesakov
echesakov deleted the Arm64-ASIMD-InsertScalar-ShiftLeftAndInsert-ShiftRightAndInsert branch July 2, 2020 17:14
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
+1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-arm64area-System.Runtime.Intrinsics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Arm64] ASIMD InsertScalar

4 participants

@echesakov@Dotnet-GitSync-Bot@tannergooding@kunalspathak