Apply arm64 intrinsics to System.Text.Encodings.Web by eiriktsarpalis · Pull Request #38707 · dotnet/runtime

eiriktsarpalis · 2020-07-02T13:03:17Z

No description provided.

ghost · 2020-07-02T13:03:31Z

Tagging subscribers to this area: @tarekgh
Notify danmosemsft if you want to be subscribed.

tarekgh · 2020-07-02T16:07:29Z

CC @GrabYourPitchforks

kunalspathak · 2020-07-10T01:14:17Z

@eiriktsarpalis - Can you also share the performance improvements you get?

eiriktsarpalis · 2020-07-10T16:00:40Z

Can you also share the performance improvements you get?

There seems to be no performance suite for the particular library. Would probably need to write one up and compare.

… into architecture-specific helper methods

eiriktsarpalis · 2020-07-15T14:50:27Z

CI failures are unrelated test failures, merging away.

Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 2, 2020

eiriktsarpalis added the area-System.Text.Encodings.Web label Jul 2, 2020

eiriktsarpalis removed the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 2, 2020

eiriktsarpalis added this to the 5.0.0 milestone Jul 2, 2020

tarekgh reviewed Jul 2, 2020
View reviewed changes

Comment threadsrc/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/AdvSimdHelper.cs Outdated

eiriktsarpalis changed the title ~~[WIP] Apply arm64 intrinsics to System.Text.Encodings.Web~~Apply arm64 intrinsics to System.Text.Encodings.WebJul 7, 2020

eiriktsarpalis requested review from carlossanlop, echesakov and tannergooding July 7, 2020 20:16

eiriktsarpalis marked this pull request as ready for review July 7, 2020 20:17

eiriktsarpalis force-pushed the vectorize-encodings-web branch from 70fc184 to 5dc8ad3Compare July 8, 2020 16:16

safern mentioned this pull request Jul 8, 2020
Builds timing out on CI #38964
Closed

carlossanlop reviewed Jul 9, 2020
View reviewed changes

Comment thread...ystem.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultJavaScriptEncoderBasicLatin.cs Outdated

eiriktsarpalis force-pushed the vectorize-encodings-web branch from 5dc8ad3 to ca7e6a8Compare July 9, 2020 11:29

eiriktsarpalis added the arch-arm64 label Jul 9, 2020

jeffhandley requested a review from pgovind July 9, 2020 19:34

tannergooding reviewed Jul 9, 2020
View reviewed changes

Comment threadsrc/libraries/System.Text.Encodings.Web/src/System/Runtime/Intrinsics/ArmIntrinsics.Shims.cs Outdated

tannergooding reviewed Jul 9, 2020
View reviewed changes

Comment threadsrc/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/BitHelper.cs Outdated

carlossanlop reviewed Jul 9, 2020
View reviewed changes

Comment threadsrc/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/AdvSimdHelper.cs Outdated