Skip to content

Fix GC heap dump - #38893

Merged
davmason merged 5 commits into
dotnet:masterfrom
davmason:fix_gcdump
Jul 9, 2020
Merged

Fix GC heap dump#38893
davmason merged 5 commits into
dotnet:masterfrom
davmason:fix_gcdump

Conversation

@davmason

Copy link
Copy Markdown
Contributor

#36932 had a typo that caused types to never be logged

Fixes#38639

@davmasondavmason added this to the 5.0.0 milestone Jul 7, 2020
@davmason
davmason requested review from a team, noahfalk and sywhangJuly 7, 2020 20:43
@davmasondavmason self-assigned this Jul 7, 2020
@ghost

ghost commented Jul 7, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

@davmason

Copy link
Copy Markdown
ContributorAuthor

@noahfalk@sywhang If I wanted to add a test to make sure we get at least some types from the bulk type event, is the right place for it the runtime or diagnostics repo?

@sywhang

Copy link
Copy Markdown
Contributor

@davmason Thanks for fixing this.. I think the right place would be the runtime repo.

Comment threadsrc/coreclr/tests/src/tracing/eventpipe/gcdump/gcdump.cs Outdated
@safernsafern mentioned this pull request Jul 8, 2020
@davmason
davmason merged commit 0716913 into dotnet:masterJul 9, 2020
@echesakov

Copy link
Copy Markdown
Contributor

@davmason I noticed that test in this PR was merged under src/coreclr/tests/src while after #38058 all the tests should be under src/tests. Can you move it to right location?

@davmason

Copy link
Copy Markdown
ContributorAuthor

@echesakovMSFT there's already a PR open #39057

@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@davmason
davmason deleted the fix_gcdump branch January 20, 2021 09:00
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet-gcdump and perfview's gcdump do not work on 5.0 runtimes

7 participants

@davmason@sywhang@echesakov@noahfalk@mikem8361@josalem@sdmaclea