Skip to content

addressing some missing feedback Relating to Browser - #38968

Merged
Anipik merged 4 commits into
dotnet:masterfrom
Anipik:followUp
Jul 10, 2020
Merged

addressing some missing feedback Relating to Browser#38968
Anipik merged 4 commits into
dotnet:masterfrom
Anipik:followUp

Conversation

@Anipik

@AnipikAnipik commented Jul 9, 2020

Copy link
Copy Markdown
Contributor

Related PR #37944

@ghost

ghost commented Jul 9, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@AnipikAnipik mentioned this pull request Jul 9, 2020
Merged
safern
safern reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Http/src/System.Net.Http.csproj Outdated
jkotas
jkotas reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Data.Odbc/ref/System.Data.Odbc.ODBC32.cs Outdated
safern
safern reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Http/src/System.Net.Http.csproj Outdated
safern
safern reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Http/src/System.Net.Http.csproj Outdated
jkotas
jkotas approved these changes Jul 9, 2020
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas

jkotas commented Jul 9, 2020

Copy link
Copy Markdown
Member

Could you please resolve conflicts?

marek-safar
marek-safar reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Http/src/System.Net.Http.csproj Outdated
@jaredparjaredpar mentioned this pull request Jul 9, 2020
Closed
stephentoub
stephentoub reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Data.Odbc/src/System/Data/Odbc/ODBC32.Common.cs Outdated
Anipikand others added 3 commits July 9, 2020 10:44
@Anipik

Anipik commented Jul 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@safern@ericstj@akoeplinger can you take another look ? i made some changes. (they are small but no harm in getting an another pair of eyes)

safern
safern reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Console/src/System.Console.csproj
</ItemGroup>
<!-- Unix -->
<ItemGroup Condition="'$(TargetsUnix)' == 'true' and '$(TargetsAndroid)' != 'true' and '$(TargetsiOS)' != 'true' and '$(TargetstvOS)' != 'true' and '$(TargetsBrowser)' != 'true'">
<ItemGroup Condition="'$(TargetsUnix)' == 'true' and '$(TargetsAndroid)' != 'true' and '$(TargetsiOS)' != 'true' and '$(TargetstvOS)' != 'true'">

@safernsafernJul 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: you can simplify this with TargetsMobile

@AnipikAnipikJul 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will make this change in the next follow up pr for browser

@Anipik
Anipik merged commit b62b16a into dotnet:masterJul 10, 2020
@Anipik
Anipik deleted the followUp branch July 10, 2020 06:45
ViktorHofer
ViktorHofer reviewed Jul 10, 2020
View reviewed changes

@ViktorHoferViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

akoeplinger
akoeplinger reviewed Jul 10, 2020
View reviewed changes

@akoeplingerakoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akoeplingerakoeplinger mentioned this pull request Jul 14, 2020
Merged
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@jkotasjkotasjkotas approved these changes
@safernsafernsafern approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

No one assigned

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Anipik@jkotas@marek-safar@akoeplinger@stephentoub@ViktorHofer@ericstj@safern@Dotnet-GitSync-Bot