Skip to content

[wasm] Addressing System.Runtime.Extensions failures - #38996

Merged
akoeplinger merged 22 commits into
dotnet:masterfrom
mdh1418:mdhwang/address_system_runtime_extensions_tests
Jul 13, 2020
Merged

[wasm] Addressing System.Runtime.Extensions failures#38996
akoeplinger merged 22 commits into
dotnet:masterfrom
mdh1418:mdhwang/address_system_runtime_extensions_tests

Conversation

@mdh1418

@mdh1418mdh1418 commented Jul 9, 2020•
edited by akoeplinger
Loading

Copy link
Copy Markdown
Member

Contributes towards #38422
Fixes#38164
This PR looks to address test failures in System.Runtime.Extensions when running on Browser wasm.
Tests run: 6875, Errors: 0, Failures: 0, Skipped: 50. Time: 23.8534559s
This PR's changes will be integrated with changes related to environment which would account for the one failure and some skips. @steveisok

Failures

@Dotnet-GitSync-Bot

Dotnet-GitSync-Bot commented Jul 9, 2020

Copy link
Copy Markdown
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

jkotas
jkotas reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.cs Outdated
jkotas
jkotas reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs Outdated
jkotas
jkotas reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/Environment.MachineName.cs Outdated
jkotas
jkotas reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs Outdated
jkotas
jkotas reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.cs Outdated
@mdh1418
mdh1418force-pushed the mdhwang/address_system_runtime_extensions_tests branch from 2e7ee4d to 6577263CompareJuly 9, 2020 15:07
steveisok
steveisok reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs Outdated
steveisok
steveisok reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs Outdated
steveisok
steveisok reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs Outdated
steveisok
steveisok reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/tests.proj Outdated
@mdh1418
mdh1418force-pushed the mdhwang/address_system_runtime_extensions_tests branch from 6577263 to d6c4841CompareJuly 9, 2020 15:29
jkotas
jkotas reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs Outdated
jkotas
jkotas reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs Outdated
@steveisoksteveisok mentioned this pull request Jul 9, 2020
Closed
99 tasks
akoeplinger
akoeplinger reviewed Jul 9, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.cs Outdated
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs Outdated
@marek-safarmarek-safar mentioned this pull request Jul 10, 2020
Merged
akoeplinger
akoeplinger reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs Outdated
jkotas
jkotas reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs Outdated
marek-safar
marek-safar reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs Outdated
marek-safar
marek-safar reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs Outdated
marek-safar
marek-safar reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs Outdated
safern
safern reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.cs Outdated
safern
safern reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs Outdated
safern
safern reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs Outdated
safern
safern reviewed Jul 10, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs Outdated
@akoeplingerakoeplinger mentioned this pull request Jul 11, 2020
Merged
marek-safar
marek-safar reviewed Jul 11, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated
marek-safar
marek-safar requested changes Jul 11, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs Outdated
@jaredparjaredpar mentioned this pull request Jul 13, 2020
Closed
@steveisok
steveisokforce-pushed the mdhwang/address_system_runtime_extensions_tests branch from 80c09c5 to c7343faCompareJuly 13, 2020 16:32
@akoeplinger
akoeplinger merged commit 927ced1 into dotnet:masterJul 13, 2020
@mdh1418
mdh1418 deleted the mdhwang/address_system_runtime_extensions_tests branch July 13, 2020 21:12
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Jul 29, 2020
@akoeplinger
[wasm] Remove unused icalls for Environment properties
2c2c29a
They are no longer needed after dotnet#38996 since we return values in managed code now.
@akoeplingerakoeplinger mentioned this pull request Jul 29, 2020
Merged
@monojenkinsmonojenkins mentioned this pull request Jul 29, 2020
Merged
monojenkins pushed a commit to monojenkins/mono that referenced this pull request Jul 29, 2020
@akoeplinger
[wasm] Remove unused icalls for Environment properties
ffb03eb
They are no longer needed after dotnet/runtime#38996 since we return values in managed code now.
marek-safar pushed a commit that referenced this pull request Jul 29, 2020
@akoeplinger
[wasm] Remove unused icalls for Environment properties (#40079)
bb82d67
They are no longer needed after #38996 since we return values in managed code now.
akoeplinger added a commit to mono/mono that referenced this pull request Jul 29, 2020
@monojenkins@akoeplinger
[wasm] Remove unused icalls for Environment properties (#20180)
b258af8
They are no longer needed after dotnet/runtime#38996 since we return values in managed code now.
Co-authored-by: akoeplinger <akoeplinger@users.noreply.github.com>
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@akoeplinger@Jacksondr5
[wasm] Remove unused icalls for Environment properties (dotnet#40079)
d311ae7
They are no longer needed after dotnet#38996 since we return values in managed code now.
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok left review comments
@stephentoubstephentoubstephentoub left review comments
@jkotasjkotasjkotas left review comments
@marek-safarmarek-safarmarek-safar approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@safernsafernsafern approved these changes
@MaximLipninMaximLipninAwaiting requested review from MaximLipnin
@jozkeejozkeeAwaiting requested review from jozkee
@layomialayomiaAwaiting requested review from layomia
@stevehartersteveharterAwaiting requested review from steveharter

Assignees

No one assigned

Labels

area-System.Runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WASM] Environment.UserName raises "not supported" exception

8 participants

@mdh1418@Dotnet-GitSync-Bot@marek-safar@steveisok@akoeplinger@stephentoub@jkotas@safern