Uh oh!
There was an error while loading. Please reload this page.
[browser][wasm] Configuring request options in Browser WebAssembly - #39182
Conversation
Dotnet-GitSync-Bot
commented
Jul 13, 2020
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Dotnet-GitSync-Bot
commented
Jul 13, 2020
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Jul 13, 2020
Tagging subscribers to this area: @dotnet/ncl |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stephentoub
commented
Jul 13, 2020
I started going through the PR, but it doesn't appear to match the approved API. I'll hold off reviewing further until that's resolved. Thanks. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…RequestOptionsKey<object>'
Uh oh!
There was an error while loading. Please reload this page.
kjpou1
commented
Jul 19, 2020
@marek-safar@stephentoub is this ready? |
stephentoub
commented
Jul 19, 2020
@scalablecory and/or @geoffkizer, can you review while I'm out? thanks. |
lewing
left a comment
There was a problem hiding this comment.
This looks ok to me now, can we get a review from libraries/networking
kjpou1
commented
Jul 24, 2020
Could someone from libraries/networking give this a look over? @scalablecory and/or @geoffkizer |
karelz
commented
Jul 28, 2020
@geoffkizer can you please help with code review here on behalf of ncl? Thanks! |
geoffkizer
commented
Jul 29, 2020
I haven't been part of the design discussions so I'm just assuming we're all happy with the design as approved -- with that said, code looks good to me. |
kjpou1
commented
Jul 29, 2020
Thanks @geoffkizer |
…otnet#39182) * [browser][wasm] Initial addition of configuring request options in Browser WebAssembly * Fix key code. Not what was proposed * Add TryGetValue<TValue> and Set<TValue> as per proposal * Add missing obsolete attribute * Address review comments * Update tests to use Options and not obsolete Properties. * Implement IDictionary<string, object?> explicitly * Update tests to use Options and not obsolete Properties. * Add HttpRequestOptions source to the System.Net.Http.Unit.Tests project to fix build. * Address review comments - explicit * Fix build error cannot convert from 'string' to 'System.Net.Http.HttpRequestOptionsKey<object>' * Add tests for HttpRequestOptions * Fix test build * Add special case code for NETFRAMEWORK for API change. * #endif out of place fix * #endif out of place fix
This dotnet/runtime PR marked Properties as obsolete: dotnet/runtime#39182 Since we use warnings as errors, we have to change our code.
This dotnet/runtime PR marked Properties as obsolete: dotnet/runtime#39182 Since we use warnings as errors, we have to change our code.
Initial implementation of request options used by Browser WebAssembly.
See proposal: #34168