Skip to content

[interp] Intrinsify span ctor - #39195

Merged
BrzVlad merged 4 commits into
dotnet:masterfrom
BrzVlad:feature-interp-span-ctor2
Jul 15, 2020
Merged

[interp] Intrinsify span ctor#39195
BrzVlad merged 4 commits into
dotnet:masterfrom
BrzVlad:feature-interp-span-ctor2

Conversation

@BrzVlad

@BrzVladBrzVlad commented Jul 13, 2020

Copy link
Copy Markdown
Member

No description provided.

@ghost

ghost commented Jul 13, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @BrzVlad, @lewurm
Notify danmosemsft if you want to be subscribed.

BrzVlad
BrzVlad commented Jul 13, 2020
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
@monojenkinsmonojenkins mentioned this pull request Jul 13, 2020
Merged
@BrzVlad
BrzVladforce-pushed the feature-interp-span-ctor2 branch from a0beba1 to dd80b7cCompareJuly 14, 2020 07:35
@BrzVlad
BrzVladforce-pushed the feature-interp-span-ctor2 branch from dd80b7c to 1bb4b05CompareJuly 14, 2020 11:16
@BrzVlad
[interp] Fix definition of instruction
5d2bd68
@BrzVlad
[interp] Intrinsify span ctor
0b226d5
It is heavily used in bcl for static read only spans.
In the future we should do copy propagation through its fields so we avoid creating the span in the first place and remove other unecessary opcodes.
@BrzVlad
[interp] Allow method inlining if constructor is intrinsified
9768870
@BrzVlad
Fix case where has_references is not yet initialized
d4f6b0c
@BrzVlad
BrzVladforce-pushed the feature-interp-span-ctor2 branch from db64b2f to d4f6b0cCompareJuly 15, 2020 12:37
@SamMonoRT

SamMonoRT commented Jul 15, 2020

Copy link
Copy Markdown
Member

What kind of perf gain are we looking at with this change ?

@BrzVladBrzVlad mentioned this pull request Jul 15, 2020
Merged
@BrzVlad
BrzVlad merged commit ef2ecfd into dotnet:masterJul 15, 2020
@steveharter

steveharter commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

I assume this would also help methods like Slice() since that returns a new Span.

@steveharter

steveharter commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

Here's a simple benchmark doing new Span<byte>(bytes).Slice() (100,000,000 iterations)

Core JITMono JITMono interpreter
23ms652 (28x slower than Core)7597 (330x slower than Core)

@ahsonkhanahsonkhan mentioned this pull request Jul 26, 2020
Merged
@karelzkarelz added this to the 5.0.0 milestone Aug 18, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexischralexischrAwaiting requested review from alexischr
@CoffeeFluxCoffeeFluxAwaiting requested review from CoffeeFlux
@lambdageeklambdageekAwaiting requested review from lambdageek
@thaystgthaystgAwaiting requested review from thaystg
1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Codegen-Interpreter-mono

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@BrzVlad@SamMonoRT@steveharter@vargaz@karelz@Dotnet-GitSync-Bot