Skip to content

Add tests to ensure the right exception is thrown for an invalid toke… - #39254

Merged
jozkee merged 1 commit into
dotnet:masterfrom
jozkee:json_1902
Jul 16, 2020
Merged

Add tests to ensure the right exception is thrown for an invalid toke…#39254
jozkee merged 1 commit into
dotnet:masterfrom
jozkee:json_1902

Conversation

@jozkee

Copy link
Copy Markdown
Member

…n after metadata properties

Closes#1902, the error was tied to the code used prior to the new converter model refactor so this was fixed on #2259

@jozkeejozkee added this to the 5.0.0 milestone Jul 14, 2020
@jozkeejozkee self-assigned this Jul 14, 2020

@layomialayomia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jozkee
jozkee merged commit ace324d into dotnet:masterJul 16, 2020
@jozkee
jozkee deleted the json_1902 branch July 16, 2020 18:39
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid NullReference when next token after reading $id or $ref is not a primitive

2 participants

@jozkee@layomia