Uh oh!
There was an error while loading. Please reload this page.
[WIP] Fix setting creation date for OSX - #39263
Conversation
There was a 'SIGSEGV Illegal memory access' that seemed related to this, this should fix it.
danmoseley
commented
Jul 15, 2020
You should be able to spread FileStatus over several files as a partial struct in order to share as much as possible with the "other Unix" and have an OSX file only for the Mac specific members. This is a pattern we use all over the sources. Eg., FileSystemEntry.*.cs |
hamarb123
commented
Jul 15, 2020
@danmosemsft okay, I will fix that shortly. |
danmoseley
commented
Jul 15, 2020
Thanks for working on this. It might be best to close this PR and reopen when you're ready for review. I assume you have a mac locally to build and test on. If you have it open like this, it uses up a lot of CI time. Each time you push it kicks off a gazillion new jobs involving 10's or 100 machines even if it's just to fix a typo. Better to work locally, get tests passing locally, then create the PR when you're ready for review and CI. |
hamarb123
commented
Jul 15, 2020
@danmosemsft okay, I will do that. |
See issue #39132. WIP.