Uh oh!
There was an error while loading. Please reload this page.
Narrow four utf16 chars to ascii and write to buffer - #39508
Merged
pgovind merged 6 commits intoJul 29, 2020
Conversation
pgovindforce-pushed
the
NarrowFourUtf16CharsToAsciiAndWriteToBuffer
branch
from
July 17, 2020 19:26
16ce598 to
b22083fCompareghost
commented
Jul 18, 2020
Tagging subscribers to this area: @tannergooding |
pgovind
commented
Jul 18, 2020
Author
There was a problem hiding this comment.
These are not strictly needed for this PR, but all of these APIs will be needed in subsequent PRs. Let me know if you'd rather that I keep this clean.
echesakov
suggested changes
Jul 20, 2020
Uh oh!
There was an error while loading. Please reload this page.
echesakov
approved these changes
Jul 20, 2020
Uh oh!
There was an error while loading. Please reload this page.
pgovindforce-pushed
the
NarrowFourUtf16CharsToAsciiAndWriteToBuffer
branch
2 times, most recently
from
July 20, 2020 23:31
40c7685 to
c719ddeCompare
pgovindforce-pushed
the
NarrowFourUtf16CharsToAsciiAndWriteToBuffer
branch
from
July 28, 2020 21:59
c719dde to
938efceComparepgovind
commented
Jul 28, 2020
Author
Rebasing on the latest master to see if CI passes |
pgovind
commented
Jul 29, 2020
Author
CI failures are unrelated. Merging. |
Jacksondr5 pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Shims * shim * Cherry-pick * NarrowFourUtf16CharsToAsciiAndWriteToBuffer * Address comments * Nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to split up my single PR into multiple ones so I can isolate CI bugs better. I believe this change should be good to go in.
In the process of splitting, I eventually found that the ARM64 CI legs seem to be broken currently. I opened #39582 to test that claim.
Perf results:
Before and After Arm64 optimizations
calope@calopearm:~/performance/src/tools/ResultsComparer$ dotnet run --base ~/pgovind_before/ --diff ~/pgovind_after/ --threshold 0.01%
summary:
better: 1, geomean: 1.244
total diff: 1
No Slower results for the provided threshold = 0.01% and noise filter = 0.3ns.