Skip to content

Clean up code following JSON number handling and field support PRs - #39716

Merged
layomia merged 2 commits into
dotnet:masterfrom
layomia:cleanup
Jul 21, 2020
Merged

Clean up code following JSON number handling and field support PRs#39716
layomia merged 2 commits into
dotnet:masterfrom
layomia:cleanup

Conversation

@layomia

@layomialayomia commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

Follow up for #39363 and #36986.

@layomialayomia added this to the 5.0.0 milestone Jul 21, 2020
@layomia
layomia requested a review from jozkeeJuly 21, 2020 16:14
@layomialayomia self-assigned this Jul 21, 2020
jozkee
jozkee approved these changes Jul 21, 2020
View reviewed changes

@jozkeejozkee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise; Lgtm.

Comment thread...libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Helpers.cs Outdated
@layomia
layomia merged commit b11aea3 into dotnet:masterJul 21, 2020
@layomia
layomia deleted the cleanup branch July 21, 2020 19:23
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@layomia@Jacksondr5
Clean up code following JSON number handling and field support PRs (d…
f19f060
…otnet#39716)
* Clean up code following JSON number handling and field support PRs
* Move IsValidNumberHandlingValue to better location
ahsonkhan
ahsonkhan reviewed Sep 1, 2020
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.cs
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonNumberHandling.cs
@layomialayomia mentioned this pull request Sep 20, 2020
Merged
@nathanpovonathanpovo mentioned this pull request Oct 11, 2020
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jozkeejozkeejozkee approved these changes
@stevehartersteveharterAwaiting requested review from steveharter
+1 more reviewer
@ahsonkhanahsonkhanahsonkhan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@layomialayomia

Labels

area-System.Text.Json

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@layomia@ahsonkhan@jozkee