') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); turn pauseonstart test off for Windows by josalem · Pull Request #39789 · dotnet/runtime · GitHub
Skip to content

turn pauseonstart test off for Windows - #39789

Merged
josalem merged 1 commit into
dotnet:masterfrom
josalem:dev/josalem/disable-pauseonstart-win-x86
Jul 23, 2020
Merged

turn pauseonstart test off for Windows#39789
josalem merged 1 commit into
dotnet:masterfrom
josalem:dev/josalem/disable-pauseonstart-win-x86

Conversation

@josalem

@josalemjosalem commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

There is an intermittent timeout only on Windows for the PauseOnStart tests. Work towards a solution is being tracked in #38847. This turns the test off for Windows CI legs.

CC @tommcdon

@josalemjosalem added the disabled-test The test is disabled in source code against the issue label Jul 22, 2020
@josalemjosalem added this to the 5.0.0 milestone Jul 22, 2020
@josalemjosalem self-assigned this Jul 22, 2020
@ghost

ghost commented Jul 22, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@ghost

ghost commented Jul 22, 2020

Copy link
Copy Markdown

Hello @josalem!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@josalemjosalem mentioned this pull request Jul 23, 2020
Merged
@josalem

josalem commented Jul 23, 2020

Copy link
Copy Markdown
ContributorAuthor

The automerge didn't happen because GH never updated to see the AzDO job complete successfully. I have a fix for the issue in #39807. Should we still merge this while that is being reviewed?

@BruceForstall

BruceForstall commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

have a fix for the issue in #39807. Should we still merge this while that is being reviewed?

Yes.

@josalem

josalem commented Jul 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Manually merging due to GH not seeing successful CI.

@josalem
josalem merged commit 56c882e into dotnet:masterJul 23, 2020
@josalem
josalem deleted the dev/josalem/disable-pauseonstart-win-x86 branch July 23, 2020 17:46
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
John Salem@Jacksondr5
turn pauseonstart test off for Windows (dotnet#39789)
067a0f8
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jashookjashookAwaiting requested review from jashook
1 more reviewer
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@josalemjosalem

Labels

area-Diagnostics-coreclrdisabled-testThe test is disabled in source code against the issue

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@josalem@BruceForstall@Dotnet-GitSync-Bot