Skip to content

Split Perf Helix Workitem - #39859

Merged
ooooolivia merged 11 commits into
dotnet:masterfrom
ooooolivia:crossgen-proj
Jul 29, 2020
Merged

Split Perf Helix Workitem#39859
ooooolivia merged 11 commits into
dotnet:masterfrom
ooooolivia:crossgen-proj

Conversation

@ooooolivia

@oooooliviaooooolivia commented Jul 23, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor
  • update crossgen perf job runkind to crossgen_scenarios
  • split perf jobs based on runkind in perf_job.yml

@Dotnet-GitSync-BotDotnet-GitSync-Bot added the area-Infrastructure-coreclr Only use for closed issues label Jul 23, 2020
@ooooolivia
ooooolivia marked this pull request as draft July 23, 2020 19:34
@jaredparjaredpar mentioned this pull request Jul 24, 2020
Closed
@oooooliviaooooolivia changed the title Crossgen projSplit Perf Helix WorkitemJul 24, 2020
@ooooolivia
ooooolivia marked this pull request as ready for review July 27, 2020 17:20
@ooooolivia

ooooolivia commented Jul 27, 2020

Copy link
Copy Markdown
ContributorAuthor

@billwert@DrewScoggins Can you review this? tagging here as there's no inviting review feature accessible for me

DrewScoggins
DrewScoggins reviewed Jul 28, 2020
View reviewed changes

@DrewScogginsDrewScoggins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all of these comments as well.

Comment threadeng/pipelines/coreclr/perf.yml Outdated
Comment threadeng/pipelines/coreclr/perf.yml Outdated
Comment threadeng/common/templates/steps/perf-send-to-helix.yml Outdated
@ooooolivia

ooooolivia commented Jul 28, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

PR merged for fixing format issue: #40035
PR merged for fixing HTTP functional test issue: #40015

@ooooolivia

ooooolivia commented Jul 29, 2020

Copy link
Copy Markdown
ContributorAuthor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jul 29, 2020

Copy link
Copy Markdown
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@ooooolivia

ooooolivia commented Jul 29, 2020

Copy link
Copy Markdown
ContributorAuthor

/azp run dotnet-runtime-perf

@azure-pipelines

azure-pipelinesBot commented Jul 29, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@DrewScoggins

DrewScoggins commented Jul 29, 2020

Copy link
Copy Markdown
Member

Once those checks pass on re-run LGTM.

@DrewScoggins
DrewScoggins self-requested a review July 29, 2020 16:42
@ooooolivia
ooooolivia merged commit 38c9792 into dotnet:masterJul 29, 2020
@oooooliviaooooolivia mentioned this pull request Jul 29, 2020
Merged
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@ooooolivia@Jacksondr5
Split Perf Helix Workitem (dotnet#39859)
eb36558
* wip
* split perf jobs into test categories
* add test category to run-performance-job.yml
* correct space
* add space to parameter var
* add $
* fix yaml
* revert extraparameters
* replace crossgen runkind
* change micro_mono tag
* remove space
@karelzkarelz added this to the 5.0.0 milestone Aug 18, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DrewScogginsDrewScogginsDrewScoggins approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ooooolivia@DrewScoggins@karelz@Dotnet-GitSync-Bot