Uh oh!
There was an error while loading. Please reload this page.
Only check inexact match when no exact match is found. - #39961
Conversation
Dotnet-GitSync-Bot
commented
Jul 27, 2020
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Jul 27, 2020
Tagging subscribers to this area: @roji, @ajcvickers |
Wraith2
commented
Jul 27, 2020
Tests? |
Infact, I don't know how and where to create an test for this internal api. And maybe it's not a problem due to it's internal and there is no dupe tables with different case actually used by public apis. |
David-Engel
left a comment
There was a problem hiding this comment.
I wouldn't close this PR just because you aren't adding tests. The bug is valid and benefits from being fixed, even though it doesn't surface with the existing *.SqlMetaData.xml embedded resources.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
danmoseley
commented
Dec 11, 2020
@cheenamalhotra this PR is pretty old now -- what's the next step? |
cheenamalhotra
commented
Dec 24, 2020
Since we don't have System.Data.SqlClient anymore, it can be closed. |
Fix#39620
Avoid the exact match result be overwrite by later inexact ones.
This may not happen due to limited callsites, just make the code more clear.