Skip to content

Fix mdarrays - #39984

Merged
davidwrighton merged 4 commits into
dotnet:masterfrom
davidwrighton:fix_mdarrays
Jul 28, 2020
Merged

Fix mdarrays#39984
davidwrighton merged 4 commits into
dotnet:masterfrom
davidwrighton:fix_mdarrays

Conversation

@davidwrighton

@davidwrightondavidwrighton commented Jul 28, 2020

Copy link
Copy Markdown
Member
  • MDArrays are special and method references to the methods needs to be encoded with their type in more cases than normal methods
  • Only generate the owner type if the memberref does not encode the same owner type
  • Add tests for various multidimensional array scenarios to crossgen2smoke

Fix issue #38260

@davidwrighton
Fix Multidimensional array method behavior in crossgen2
9940012
- MDArrays are special and method references to the methods needs to be encoded with their type
- Only generate the owner type if the memberref does not encode the same owner type
@davidwrighton
Update issues.targets
9016f42
@davidwrighton
Merge branch 'master' of github.com:dotnet/runtime into fix_mdarrays
cb3e2a1
@davidwrighton

davidwrighton commented Jul 28, 2020

Copy link
Copy Markdown
MemberAuthor

@dotnet/crossgen-contrib

@davidwrightondavidwrighton linked an issue Jul 28, 2020 that may be closed by this pull request
CG2: Test failure JIT\Generics\Arrays\TypeParameters\MultiDim\class01 and struct01 #38260
Closed
AntonLapounov
AntonLapounov reviewed Jul 28, 2020
View reviewed changes
Comment threadsrc/tests/readytorun/crossgen2/Program.cs Outdated
public override int GetHashCode() { return x; }
}

struct SomeClass : IEquatable<SomeClass>

@AntonLapounovAntonLapounovJul 28, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be class?

AntonLapounov
AntonLapounov reviewed Jul 28, 2020
View reviewed changes
Comment threadsrc/tests/readytorun/crossgen2/Program.cs
@davidwrighton
davidwrighton merged commit 36f0c48 into dotnet:masterJul 28, 2020
@davidwrightondavidwrighton mentioned this pull request Jul 28, 2020
Merged
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@davidwrighton@Jacksondr5
Fix mdarrays (dotnet#39984)
4115085
- MDArrays are special and method references to the methods needs to be encoded with their type in more cases than normal methods
- Only generate the owner type if the memberref does not encode the same owner type
- Add tests for various multidimensional array scenarios to crossgen2smoke
Fix issue dotnet#38260
@karelzkarelz added this to the 5.0.0 milestone Aug 18, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@davidwrighton
davidwrighton deleted the fix_mdarrays branch April 20, 2021 17:43
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylektrylekAwaiting requested review from trylek
1 more reviewer
@AntonLapounovAntonLapounovAntonLapounov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-ReadyToRun

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

CG2: Test failure JIT\Generics\Arrays\TypeParameters\MultiDim\class01 and struct01

4 participants

@davidwrighton@AntonLapounov@karelz@Dotnet-GitSync-Bot