Skip to content

[mono] Fix warnings on OSX netcore - #39997

Merged
CoffeeFlux merged 1 commit into
dotnet:masterfrom
CoffeeFlux:more-warning-fixes
Jul 28, 2020
Merged

[mono] Fix warnings on OSX netcore#39997
CoffeeFlux merged 1 commit into
dotnet:masterfrom
CoffeeFlux:more-warning-fixes

Conversation

@CoffeeFlux

@CoffeeFluxCoffeeFlux commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

This commit brings us back to zero warnings for the default build configuration.

@Dotnet-GitSync-BotDotnet-GitSync-Bot added the area-Infrastructure-coreclr Only use for closed issues label Jul 28, 2020
@ghost

ghost commented Jul 28, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

@CoffeeFluxCoffeeFlux removed the area-Infrastructure-coreclr Only use for closed issues label Jul 28, 2020
@monojenkinsmonojenkins mentioned this pull request Jul 28, 2020
Merged
@akoeplinger

akoeplinger commented Jul 28, 2020

Copy link
Copy Markdown
Member

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Jul 28, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

akoeplinger commented Jul 28, 2020

Copy link
Copy Markdown
Member

@CoffeeFlux looks like this causes a build failure on the Windows build:

 F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(695,93): error C4047: '=': 'char' differs in levels of indirection from 'gchar *' [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(696,61): error C4047: 'function': 'const char *' differs in levels of indirection from 'char' [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(696,61): warning C4024: 'mono_config_parse_file_with_context': different types for formal and actual parameter 2 [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(697,14): error C4022: 'monoeg_g_free': pointer mismatch for actual parameter 1 [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(701,91): error C4047: '=': 'char' differs in levels of indirection from 'gchar *' [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(702,61): error C4047: 'function': 'const char *' differs in levels of indirection from 'char' [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(702,61): warning C4024: 'mono_config_parse_file_with_context': different types for formal and actual parameter 2 [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(703,14): error C4022: 'monoeg_g_free': pointer mismatch for actual parameter 1 [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]

akoeplinger
akoeplinger reviewed Jul 28, 2020
View reviewed changes
Comment threadsrc/mono/mono/metadata/mono-config.c Outdated
@akoeplinger

akoeplinger commented Jul 28, 2020

Copy link
Copy Markdown
Member

Which also means we haven't kept these defines in sync with winconfig.h otherwise this code wouldn't have been compiled :D

@CoffeeFlux
[mono] Fix warnings on OSX netcore
bddb183
This commit brings us back to zero warnings for the default build configuration
@CoffeeFlux

CoffeeFlux commented Jul 28, 2020

Copy link
Copy Markdown
ContributorAuthor

Yep, and that one's on me. Addressed here: #40005

@jaredparjaredpar mentioned this pull request Jul 28, 2020
Closed
@CoffeeFlux
CoffeeFlux merged commit ad93942 into dotnet:masterJul 28, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@CoffeeFlux@Jacksondr5
[mono] Fix warnings on OSX netcore (dotnet#39997)
c0f98ad
This commit brings us back to zero warnings for the default build configuration
@karelzkarelz added this to the 5.0.0 milestone Aug 18, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@thaystgthaystgAwaiting requested review from thaystg
@lateralusXlateralusXAwaiting requested review from lateralusX
@alexischralexischrAwaiting requested review from alexischr
@lambdageeklambdageekAwaiting requested review from lambdageek
@marek-safarmarek-safarAwaiting requested review from marek-safar
+1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-meta-mono

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@CoffeeFlux@akoeplinger@vargaz@karelz@Dotnet-GitSync-Bot